From unknown Fri Jun 20 07:19:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#68810 <68810@debbugs.gnu.org> To: bug#68810 <68810@debbugs.gnu.org> Subject: Status: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary Reply-To: bug#68810 <68810@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:19:18 +0000 retitle 68810 29.1; Recommending setting transfer.fsckObjects of git to tru= e is not necessary reassign 68810 emacs submitter 68810 Lin Jian severity 68810 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 29 18:29:26 2024 Received: (at submit) by debbugs.gnu.org; 29 Jan 2024 23:29:26 +0000 Received: from localhost ([127.0.0.1]:33765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUb4A-000174-07 for submit@debbugs.gnu.org; Mon, 29 Jan 2024 18:29:26 -0500 Received: from lists.gnu.org ([2001:470:142::17]:58478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUb47-00016o-VA for submit@debbugs.gnu.org; Mon, 29 Jan 2024 18:29:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUb3u-0005Al-2F for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 18:29:10 -0500 Received: from mail.linj.tech ([5.255.109.209]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUb3r-0004ah-KX for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 18:29:09 -0500 From: Lin Jian DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail; t=1706570945; bh=QkGp6M3WTHOrBWCxwFYt928OhFW6Gyk8nM6D1nhrSzo=; h=From:To:Subject:Date; b=TWDC2pnicGQmU1dRkR+LlcS90DHtAcrSygWGc7XI70IE9xyrAh9wi/PRFBcMw4VLI neyckvHmRerJ6ms4nKvPYxYOhHXKdfZRIdMckYR2OM/tHQmkNAJSnuwMoOqD3FwfaO nuU8yBvhpK1/HYNBlPuqU+6PYAZ/LauHwgzaJOE2Zbxw36zWMAV/3+cKOSJjBvbU9N RBJ9I9xp9C9zxKYyv3aMcHDhj5XkHTU73lYEkMyCZzO+4b/9kkZT4NbeESr6iPia6N y5TuXGiy0Q1HNEILP7PPGDGGI+VF9p8eic3AHMDQyUPgCmirjxv0bizxLcCszIynUb v6dYaqfxtcb5Q== To: bug-gnu-emacs@gnu.org Subject: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary Date: Tue, 30 Jan 2024 07:16:45 +0800 Message-ID: <87a5onlnwk.fsf@linj.tech> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=5.255.109.209; envelope-from=me@linj.tech; helo=mail.linj.tech X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Recommendation about setting transfer.fsckObjects of git to true can be found in admin/notes/git-workflow and CONTRIBUTE. In addition, it is set in autogen.sh. This is triggered by a discussion[1] on emacs-devel. The first commit about this is cedd7cad092809a97c1ed7fb883b68fa844cea58 on 2016-01-31. However, on 2016-02-04, another discussion[2] shows that git is secure by default so setting this option is not necessary. What about removing this unnecessary recommendation? By the way, the same recommendation can be found on Emacswiki[3][4]. [1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29 [3]: https://www.emacswiki.org/emacs/GitQuickStartForEmacsDevs [4]: https://www.emacswiki.org/emacs/GitForEmacsDevs From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 29 19:40:14 2024 Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 00:40:14 +0000 Received: from localhost ([127.0.0.1]:33944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUcAf-0005mm-Sx for submit@debbugs.gnu.org; Mon, 29 Jan 2024 19:40:14 -0500 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:45331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUcAd-0005mT-5x for 68810@debbugs.gnu.org; Mon, 29 Jan 2024 19:40:12 -0500 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2d057b6df2aso3849501fa.3 for <68810@debbugs.gnu.org>; Mon, 29 Jan 2024 16:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706575196; x=1707179996; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=H111L9C6B5IGVS2edxOIY9GLuzqh4JfXCodxJ2EP8vA=; b=cC7rAJ6ydlOPVccpvTgzdT58Bx9k+nbd9HGZ5ailtWsdcry/jGWMQK6h2aYskNe1sT ml/2ZipNgfkboUZJ52h1rl12o1oGVEKpFgBjO92rwFkqxQeomrFjvvJB/nkoBqsXSBiv iLdReMlxX6QIgaSymuc0pjKCmhmHQFlgGOvecldvrvf+2+N2mbIRbee8GMgChxS7xadj Sjl97l7XZ86//lz192VC2AImpH0sNJREXxCEpnwuq9KU403ezC2NLhGKRDqNoe9zeZi4 nl5LR7G0Xv7XrDHquI0hHjHSNyRc6AjABNgON7IxGUXI5fD824z2+YatlAgeMavFchfq 7Aog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706575196; x=1707179996; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H111L9C6B5IGVS2edxOIY9GLuzqh4JfXCodxJ2EP8vA=; b=t+3g2lzGPicTBfnC5Qapfn+zvjnalJ/PiQP2g6qxeVRtUnmtmw4bUF1xCxPOIM7Lmg iEFSnSSlapmn5SobNfFEhyxtPN+60xAb4wDc/pJbjkH3lfnfJ4e98ePgOTGlBvxtgxR8 YCKKV+zx5DuMbA8lWNO6ladBW0rREwDuIqOOu8ytG6LDm6BDRxSjTaH08bPc0KbnQyLy mU54xqkRIhILYsGbnKaH/Z/CXRwpyPCiJBAcFgy+Mh2SOhmu12Ty39EtsLz2FQm4ZuRl 5MSaDeh1wyrFwawFo1Vxbd9Essy+EAj9kGFijLHwL9FSmCp8CT3LXRkXEUJ67AN0Be0f MeAw== X-Gm-Message-State: AOJu0YwV11lW95B6TYxkbpU/PVJEi0qu84H+XV8OWVB05xU4Pe42E76S AADzcelXDG+DYi04n9/Q+SIDnxbiGKoLg+t4d3M4KaSFIiqPkl6Vr34O9OZxr22SkTSwfhwbHwZ D6SKyjSkLimm9o3B+S54P38ewCNkgHNgw2N8= X-Google-Smtp-Source: AGHT+IFFmggKWcjLlGeLAfWR5QF2uO+fCEn5NBDN/O/XkzvVoJ+ca+BSkD/1Fygwn8/EfdHstKIGZurrA9EdKKg2AO0= X-Received: by 2002:a2e:b0f8:0:b0:2cf:3037:2a35 with SMTP id h24-20020a2eb0f8000000b002cf30372a35mr4789288ljl.48.1706575195704; Mon, 29 Jan 2024 16:39:55 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 29 Jan 2024 19:39:54 -0500 From: Stefan Kangas In-Reply-To: <87a5onlnwk.fsf@linj.tech> References: <87a5onlnwk.fsf@linj.tech> MIME-Version: 1.0 Date: Mon, 29 Jan 2024 19:39:54 -0500 Message-ID: Subject: Re: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary To: Lin Jian , 68810@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68810 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lin Jian via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Recommendation about setting transfer.fsckObjects of git to true can be > found in admin/notes/git-workflow and CONTRIBUTE. In addition, it is > set in autogen.sh. > > This is triggered by a discussion[1] on emacs-devel. The first commit > about this is cedd7cad092809a97c1ed7fb883b68fa844cea58 on 2016-01-31. > However, on 2016-02-04, another discussion[2] shows that git is secure > by default so setting this option is not necessary. > > What about removing this unnecessary recommendation? > > By the way, the same recommendation can be found on Emacswiki[3][4]. > > [1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html > [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29 > [3]: https://www.emacswiki.org/emacs/GitQuickStartForEmacsDevs > [4]: https://www.emacswiki.org/emacs/GitForEmacsDevs Are you sure? The git documentation says: transfer.fsckObjects When fetch.fsckObjects or receive.fsckObjects are not set, the value of this variable is used instead. Defaults to false. When set, the fetch or receive will abort in the case of a malformed object or a link to a nonexistent object. In addition, various other issues are checked for, including legacy issues (see fsck.), and potential security issues like the existence of a .GIT directory or a malicious .gitmodules file (see the release notes for v2.2.1 and v2.17.1 for details). Other sanity and security checks may be added in future releases. https://git-scm.com/docs/git-config#Documentation/git-config.txt-transferfsckObjects From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 29 19:41:37 2024 Received: (at control) by debbugs.gnu.org; 30 Jan 2024 00:41:37 +0000 Received: from localhost ([127.0.0.1]:33948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUcC1-0005pV-DY for submit@debbugs.gnu.org; Mon, 29 Jan 2024 19:41:37 -0500 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:58654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUcC0-0005pF-4N for control@debbugs.gnu.org; Mon, 29 Jan 2024 19:41:36 -0500 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-55a8fd60af0so3443269a12.1 for ; Mon, 29 Jan 2024 16:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706575281; x=1707180081; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=nHkKUlHhuPGsMd4BVALjRU1cbahxVUiToM2rTo1C6MY=; b=hpeVvcqmy1jaI6t95yhdx3Em3FEXcf4fFAFq+KEPVEetBKk+8/f3UJv3Udl35nmVan hzGU83eR4tJVYOfcFIl6+Lf5sGUdR2FRQrgW8aIogWG+abVzUgg85sX0QOzzZ0Rke9Bz PwB1EYKyiJ2X1vv0IkfI85iPXzkl9YHM2qz3gMknR9EVmy96HuZ9vS9nVvaZgyeyfv7e yndOjRlY/wpgKw0MJmMB696IuOD96XSaYd50j3g5FyzZI42i/7qaZLobeQdmYmlaNGLx FlDlZyRXPSk2BhsMd3UOYSPiza0ZGey6w8OUOMNOtDF9eJ+KgsVrHjaNb+6r6vFJi0UZ bJKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706575281; x=1707180081; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nHkKUlHhuPGsMd4BVALjRU1cbahxVUiToM2rTo1C6MY=; b=RSVHHgGeI+510wfoyuDMh6ZViKhPaZEKSowfnKJpz0Mgw9cyGIcdlE+HfSL35E6mrI /eteZwi+fJ/7qdM3Z/0vzC5ErG24j6ennYuy7l9AlTUb9YJuwfsKYU8lyh49f+ChbteG EXTOEiOtEq40ok8C8jnWYSMkZvFhBVVn58M9gFvHr1NIlBTmlpPnH9xMHrTcahwW4vf2 UgqepWEBTOtVffQ7Dw4jghyyoM4mT/oE1dwwX4ORCAPZIMVd0N9mVD6xtA8rMU9OzPAU 4TgzP7xinzcza9pLGNAK9eAlkSL/8n+ikT79IzUSe8lTAtXq1SzSNdLsYEZQ2/ZPivQ/ +GKQ== X-Gm-Message-State: AOJu0Yxzl5teuzAkRPRQciQnxXjh24tC1DWIN9PI+eHq1o1yoSxINuXv eKgfpSX2ANFWEhUFpURxYViZcfvDhXKoWsPtWbVbzjJsCKCSFiEy+Z8NlC+ip0XWmVqLLr29W0P rCChO2t0cAetP41NFD03AO9+RIaber2vERZA= X-Google-Smtp-Source: AGHT+IHDkBaFKaVthgRPNAifdbePBF/PQlPCLL4MZsw+9P48gHN48hbuC9Ew+a0u52KzTsxX52Cd2gjQgIS6IE3tC4s= X-Received: by 2002:a05:6402:2078:b0:55e:bbf5:d37d with SMTP id bd24-20020a056402207800b0055ebbf5d37dmr4586071edb.14.1706575281379; Mon, 29 Jan 2024 16:41:21 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 29 Jan 2024 19:41:21 -0500 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 29 Jan 2024 19:41:21 -0500 Message-ID: Subject: control message for bug #68810 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 68810 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 07:14:51 2024 Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 12:14:51 +0000 Received: from localhost ([127.0.0.1]:34507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUn0t-0007WB-4K for submit@debbugs.gnu.org; Tue, 30 Jan 2024 07:14:51 -0500 Received: from mail.linj.tech ([5.255.109.209]:58926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUn0r-0007W2-3R for 68810@debbugs.gnu.org; Tue, 30 Jan 2024 07:14:49 -0500 References: <87a5onlnwk.fsf@linj.tech> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail; t=1706616878; bh=DnkvkSjTT8GpY6KvpTHVARWqfsKx8MDZ52zTx5HWS6Q=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=rpsijOAuh4Mrn3DBm37ReW0VUVpNUP+9QFqT7dCABpn5yzCaV7lSXULiwgyPLYk0Z ixdG7lK7K1kZbQwtvK6Ky42FwRLb6E95fOQNwhNRlx9kaFTAjYaCGDW/+p4XZpWpNL +tuo+Uzsl5cCu1hG0Fym1RPgm5S4mbd2yafFrtDIkf62EckHXROcxAMfLXUtaGqNxK +QRd5JOMEt1l62ALWFYEGIFgFUvcE26MLjOlo5WvwPHFF98CSfSEkj+voLmemgwdeK covPTyZi+7QxJHwfT2mxDmWtDOGPsxTOTU7UQgQVZ9zvH++3ufcLPnFilqh/gtvU+c mPRrHP4s6CDcw== From: Lin Jian To: Stefan Kangas Subject: Re: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary Date: Tue, 30 Jan 2024 19:57:16 +0800 In-reply-to: Message-ID: <875xzbkogr.fsf@linj.tech> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68810 Cc: 68810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Are you sure? I am no expert of git. So I am not sure. That being said, have you read those links in my report? My point is that the motivation of setting transfer.fsckObjects in [1], i.e., security, is made invalid in [2] because git is secure by default. However, related commits are made before (and after) [2]. [1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 07:27:52 2024 Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 12:27:52 +0000 Received: from localhost ([127.0.0.1]:34530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUnDT-0007uy-Dx for submit@debbugs.gnu.org; Tue, 30 Jan 2024 07:27:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUnDQ-0007uj-RH for 68810@debbugs.gnu.org; Tue, 30 Jan 2024 07:27:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUnDC-0008Sf-8R; Tue, 30 Jan 2024 07:27:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fh3jf72NKxkSrp7bo2/e0Q8Es17dHugHwB2XgcnWtKo=; b=IXz4aODybRBv YeJlbb+aPtqn6lmRyDsKSFhvEbu1s7xOLG3IgS3tUj4SRAuLyHK3GQrKNd60wA6LU8DxsjDnARsdF /jVKkxjOIEY2YpogsAE3NshRXMH1LlEl1+zzSna6WZSAMC1De5PZIM0M2PiyPd5H7UAbZ91eEovUe 9sij9Csq+uLMqMzwSxUHXayQKrpIeC5INhOQVSL2KW8wzFIXS7C5LFMbln2wdD6Pu4/R4Lb/zog1T IHEPp3oGkpZ1fpoCgU59x4pBYbsb0YLlvJ4tJsdu0b4MOnuUN1E4URCsB+m1teajgy3Vb/TXulTWX lEaf2C2ZiSDfwGmEvrEQhw==; Date: Tue, 30 Jan 2024 14:27:07 +0200 Message-Id: <86mssn2ehw.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Mon, 29 Jan 2024 19:39:54 -0500) Subject: Re: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary References: <87a5onlnwk.fsf@linj.tech> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68810 Cc: me@linj.tech, 68810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Mon, 29 Jan 2024 19:39:54 -0500 > > Lin Jian via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" writes: > > > Recommendation about setting transfer.fsckObjects of git to true can be > > found in admin/notes/git-workflow and CONTRIBUTE. In addition, it is > > set in autogen.sh. > > > > This is triggered by a discussion[1] on emacs-devel. The first commit > > about this is cedd7cad092809a97c1ed7fb883b68fa844cea58 on 2016-01-31. > > However, on 2016-02-04, another discussion[2] shows that git is secure > > by default so setting this option is not necessary. > > > > What about removing this unnecessary recommendation? > > > > By the way, the same recommendation can be found on Emacswiki[3][4]. > > > > [1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html > > [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29 > > [3]: https://www.emacswiki.org/emacs/GitQuickStartForEmacsDevs > > [4]: https://www.emacswiki.org/emacs/GitForEmacsDevs > > Are you sure? The git documentation says: > > transfer.fsckObjects > > When fetch.fsckObjects or receive.fsckObjects are not set, the value > of this variable is used instead. Defaults to false. > > When set, the fetch or receive will abort in the case of a malformed > object or a link to a nonexistent object. In addition, various other > issues are checked for, including legacy issues (see fsck.), > and potential security issues like the existence of a .GIT directory > or a malicious .gitmodules file (see the release notes for v2.2.1 > and v2.17.1 for details). Other sanity and security checks may be > added in future releases. > > https://git-scm.com/docs/git-config#Documentation/git-config.txt-transferfsckObjects And I have another question: does this setting cause any harm, or can cause any harm in some situations? IOW, what are the downsides of using this setting? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 08:18:39 2024 Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 13:18:40 +0000 Received: from localhost ([127.0.0.1]:34578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUo0d-0003WY-J8 for submit@debbugs.gnu.org; Tue, 30 Jan 2024 08:18:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUo0b-0003WL-Ta for 68810@debbugs.gnu.org; Tue, 30 Jan 2024 08:18:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUo0M-0002vn-MS; Tue, 30 Jan 2024 08:18:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3utRjV6vkrrT6mveb41y5lY+5Lcv11tVKCPnQfar3Zw=; b=E/tvXcX3Vxqa BlBUdJH+GxilnObgxY8n2GxTPdLb0mCeD+II4HhLsFTrcdzZZphWop0yo77K7Hua65JDhRmrftURK KBf+wvT87AGt5ukEFS1iCSfilEiUQ1Ol+9LXDVIHBoLDHHlvSncd+fNOQPYYHn0hE4CbakLS+haZM 0/vkaD2GLgASxhyhCjas79X6agoGnw5T1GYXDzY3AUVQ7Xmy4bsKicjtkiUNkmX2uI9rC7G2FoBlB 7rmgnHh0cC2al8dWadjUFgH5KvxvBSX5784mMONoY6X5TfpIa0xS1gqaI+T99MeuF+TtVCW69YASz 1qZ2t3oXfMljr5rceoEUFw==; Date: Tue, 30 Jan 2024 15:18:18 +0200 Message-Id: <86eddz2c4l.fsf@gnu.org> From: Eli Zaretskii To: Lin Jian In-Reply-To: <875xzbkogr.fsf@linj.tech> (bug-gnu-emacs@gnu.org) Subject: Re: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary References: <87a5onlnwk.fsf@linj.tech> <875xzbkogr.fsf@linj.tech> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68810 Cc: stefankangas@gmail.com, 68810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 68810@debbugs.gnu.org > Date: Tue, 30 Jan 2024 19:57:16 +0800 > From: Lin Jian via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > Stefan Kangas writes: > > > Are you sure? > > I am no expert of git. So I am not sure. > > That being said, have you read those links in my report? My point is > that the motivation of setting transfer.fsckObjects in [1], i.e., > security, is made invalid in [2] because git is secure by default. AFAIR, we added that setting because of real problems, not because of some theoretical concerns. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 08:52:46 2024 Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 13:52:46 +0000 Received: from localhost ([127.0.0.1]:34652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUoXe-0004dL-8E for submit@debbugs.gnu.org; Tue, 30 Jan 2024 08:52:46 -0500 Received: from mail.linj.tech ([5.255.109.209]:58250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUoXc-0004dB-5r for 68810@debbugs.gnu.org; Tue, 30 Jan 2024 08:52:44 -0500 References: <87a5onlnwk.fsf@linj.tech> <86mssn2ehw.fsf@gnu.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail; t=1706622753; bh=qQ1hp42hl1V8a9FiunR+E1Vg0UBs2qhZoZ1A6MStCFs=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=cMLgaRXEargw5VnxrL4pKEboDTtOSKPWIeg9oQ2YrmapisP3QS9QLuW5n3g6fuacV V2Ouc+sjNjo5Vuk0/zA/b1AwnARw7dWHfHW+RD7FMGZovnShEZwdCupJyxg2rUEnfv SD2X8OCHy7orgmcc+qCf2fDc9DDhmmAANZ+1IG52VbZEBAE3aUAovhP761x7RH9zbV teCPezrie3ZZ5dHDU8omLqpUoeSFfHYDbEmgxGGSAPPR9Ucyx+2N/sf2ZdgdmMdx7y MW5RfOHIwkgFgItKI1yfwBAWN+UVR3lwW2Hfw7aonSAzIwXcbReC43kMMen/Ys0tZc UNC1bg1hFDsOw== From: Lin Jian To: Eli Zaretskii Subject: Re: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary Date: Tue, 30 Jan 2024 21:48:45 +0800 In-reply-to: <86mssn2ehw.fsf@gnu.org> Message-ID: <871q9zkjxg.fsf@linj.tech> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68810 Cc: Stefan Kangas , 68810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > And I have another question: does this setting cause any harm, or can > cause any harm in some situations? IOW, what are the downsides of > using this setting? I am not aware of any downsides of using this setting. My motivation is to remind Emacs developers that this setting is not necessary. How you deal with this unnecessary setting is up to you. I personally prefer upstream (git) default though. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 08:59:31 2024 Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 13:59:31 +0000 Received: from localhost ([127.0.0.1]:34656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUoeB-0004oe-4c for submit@debbugs.gnu.org; Tue, 30 Jan 2024 08:59:31 -0500 Received: from mail.linj.tech ([5.255.109.209]:57368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUoe8-0004oT-D4 for 68810@debbugs.gnu.org; Tue, 30 Jan 2024 08:59:29 -0500 References: <87a5onlnwk.fsf@linj.tech> <875xzbkogr.fsf@linj.tech> <86eddz2c4l.fsf@gnu.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail; t=1706623158; bh=5swqgWjVnsfG2ZbSMmWcSPccc3HxUyV4QsM36Bu8JIY=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=cC+VH/hh6Ziq8MLxGwkyEcbE36DGKwPczk9bCZu18GfprVuU9+WdiWcikR5wgIrH5 aaKsWkk9OtMiIIVXjJNjjSl0W+1TYAiNNXmwo8KchN/xbI7GSbAew5r1LZoNiCWN2q 8gVGy5zAH/8OKMWm6tBC4fv4b3lMBMOuohdPdAXwMY73R32stcNUcKGJmxbczwi4zt MZXWSs+CZ3zGsmkSAveoyQOgpKioHSNmx9u72gxmjd/8DpMolPCZCcUL/Dsjv/D7WK D6ZIel5APlb/N9GXdYhHBXlPYNmNnXpPT45enzLZKYXUHdqXW1Vqna+TR52v3xo5EA VPMlYjD/37EMg== From: Lin Jian To: Eli Zaretskii Subject: Re: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary Date: Tue, 30 Jan 2024 21:53:02 +0800 In-reply-to: <86eddz2c4l.fsf@gnu.org> Message-ID: <87wmrqkjm8.fsf@linj.tech> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68810 Cc: stefankangas@gmail.com, 68810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > AFAIR, we added that setting because of real problems, not because of > some theoretical concerns. Both related content in git-workflow and commit messages of related commits[1][2][3][4] point the motivation to only [5]. If there are indeed real problems I am not aware of, then my report is not valid and I am sorry for the noise. [1]: cedd7cad092809a97c1ed7fb883b68fa844cea58 [2]: d766ca8ff1e4ff1a30385508e1f456fad6bfe9f8 [3]: ee8b46699523cc1dea7b3d03e3cccff3d62cd847 [4]: f8bf1b35bf55ae1bb7703f86d3b526887f064b19 [5]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 09:23:04 2024 Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 14:23:04 +0000 Received: from localhost ([127.0.0.1]:34707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUp0y-0005XZ-5g for submit@debbugs.gnu.org; Tue, 30 Jan 2024 09:23:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUp0v-0005Wz-Qb for 68810@debbugs.gnu.org; Tue, 30 Jan 2024 09:23:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUp0g-0000OT-DB; Tue, 30 Jan 2024 09:22:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=y77MicwHKUu7Hhq37fFu2qhQKhFO0aQVJct8UrkxPPI=; b=QNg7BtcMRjXa UfEL6Au3AqvAbrcuGBQemLu1KS6tkZSSYr5EQhIfg0C4hc1bHzteLyEzS2jdcoAj+c0mYDZXjwte4 NYLXARB/w7g6zdiEqwdmXxlHEKenZbhefbpi3WzLq8xCuzayaM0zI282lvSGhttUiToOiW3Z6USiL ljSZp5yP9wPHY54ap9N3Wbpv8SpdYtCgjHxjR+GRKhfcjTcdbofzJ4FQJ4h571jrXW+GGj9rUdu05 ak7ulrbopcff51OUsk2yCEpHzkDPPKsBWR6rOl5jEy50UkhORZ+4AMHcdD+BBbHoxaYEkM/mfz3U6 Fwsmm6Kd/OOBCCSbEhtxLQ==; Date: Tue, 30 Jan 2024 16:22:43 +0200 Message-Id: <86a5om3npo.fsf@gnu.org> From: Eli Zaretskii To: Lin Jian In-Reply-To: <87wmrqkjm8.fsf@linj.tech> (message from Lin Jian on Tue, 30 Jan 2024 21:53:02 +0800) Subject: Re: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary References: <87a5onlnwk.fsf@linj.tech> <875xzbkogr.fsf@linj.tech> <86eddz2c4l.fsf@gnu.org> <87wmrqkjm8.fsf@linj.tech> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68810 Cc: stefankangas@gmail.com, 68810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lin Jian > Cc: stefankangas@gmail.com, 68810@debbugs.gnu.org > Date: Tue, 30 Jan 2024 21:53:02 +0800 > > > Eli Zaretskii writes: > > > AFAIR, we added that setting because of real problems, not because of > > some theoretical concerns. > > Both related content in git-workflow and commit messages of related > commits[1][2][3][4] point the motivation to only [5]. AFAIR, there were problems with fetching from elpa.git at some point, which would have been avoided if fsckObjects were used. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 15:49:53 2024 Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 20:49:53 +0000 Received: from localhost ([127.0.0.1]:36996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUv3I-0005KE-Q1 for submit@debbugs.gnu.org; Tue, 30 Jan 2024 15:49:53 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:50225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUv3G-0005K0-LK for 68810@debbugs.gnu.org; Tue, 30 Jan 2024 15:49:51 -0500 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-55ee686b5d5so3893149a12.0 for <68810@debbugs.gnu.org>; Tue, 30 Jan 2024 12:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706647775; x=1707252575; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=Rf5EHb/xb+fAx7QKOQohZlX8XtHcn7MenKsqoA5vLaA=; b=LYPc6IJqn2dX0xPvSEoCjURuA+J9FEL8+8Ff6W5SlVDOx4fTDK2JsZC1UhGC6SFGvS M127MZ/lEbJ1fWMngWbxfFHNgtzsOYBqGvS31j1FQkhQKv5M5ivJgWnYiwY2QRms7Uyd xeFNDd6dgitUc4m8fFkbgHPxa4X8D5vlNQmnUp513WL1a4pOMZlF69SIKaSN/2OLByiq tCKgc7zEzpdHSdVLazJy2KO+ZtCcny9R6+hoKq/atL2ttwAutyBDaSknQBF/p5AJ0XWz VsHOgSbWE53jlgpOXmL2HbOsVTk1IFSfn3flLqUfrCP9c6jU3EX7ppOIq7eQE9VitBPl FPTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706647775; x=1707252575; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rf5EHb/xb+fAx7QKOQohZlX8XtHcn7MenKsqoA5vLaA=; b=dOg44smFVp+fyR+qeH/jLl9W5dlqUBD1zQcu298Q8bJUo84Vvk9imNC4LqOlimsfFJ 8d6vgq5x6Z1xVUkP5uiEu9n/r5Uww5rL1rfRrNHkDxCw/mPMpaFTSgiq00iLNmA9Umyn vgtkWpNVhOOmjjGh1YNYFVtrKu+3MYroi+jbasuAU56j31pN1ZizNp8LxZ9Ex7pfd4sG IISkg1UynECOXuHbj58L75fquOaMH+WIxkFMBGXXZjcCyvNhusTCx3sAZI8PEpzXuVQy 9mjeraABCEtT9oLpNbOjUWLy6tWBvfh9if4j7hjc9gVV+5opzfW42QRcG9UZKDXWahIc PV4A== X-Gm-Message-State: AOJu0YxsZ96kgAveM8eTcZnNsQiuVTMeTVslKqJPCTL8PyjWbGUdSkv7 ys5gqIgBYGeFYmfijYZoBJzLUW3a8xSH58M/rOoREQy6lNrxHnPyVDwOyT2dv5Lf4YQKbuuLOfr iiR1Ur9o2JG1Q0JqSSLMoRiVlokY= X-Google-Smtp-Source: AGHT+IHi565WHCOXA25yYxxD9y4AY2qR6t337NJB3NknhP31msRyTU7nvWYKoajk66L1WsBHaKin5Zj9h9j2fLM7Ncs= X-Received: by 2002:aa7:da47:0:b0:55e:e74b:cc3c with SMTP id w7-20020aa7da47000000b0055ee74bcc3cmr5051303eds.29.1706647775473; Tue, 30 Jan 2024 12:49:35 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 30 Jan 2024 15:49:34 -0500 From: Stefan Kangas In-Reply-To: <875xzbkogr.fsf@linj.tech> References: <87a5onlnwk.fsf@linj.tech> <875xzbkogr.fsf@linj.tech> MIME-Version: 1.0 Date: Tue, 30 Jan 2024 15:49:34 -0500 Message-ID: Subject: Re: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary To: Lin Jian Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68810 Cc: 68810@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lin Jian writes: > Stefan Kangas writes: > >> Are you sure? > > I am no expert of git. So I am not sure. > > That being said, have you read those links in my report? My point is > that the motivation of setting transfer.fsckObjects in [1], i.e., > security, is made invalid in [2] because git is secure by default. > However, related commits are made before (and after) [2]. Yes, I read the links. But I tend to trust the official documentation more than some random opinions shared online, and the part I quoted says that this setting _does_ enable some checks that would otherwise not be done.