GNU bug report logs - #6881
23.2; bookmark-bmenu-search makes menu disappear

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6881 in the body.
You can then email your comments to 6881 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2; bookmark-bmenu-search makes menu disappear
Date: Wed, 18 Aug 2010 19:00:54 +0100

1. C-x r l to list bookmarks
2. M-g s and the menu bar becomes blank.

Tested on emacs 23.2 on OSX.

Leo

Message #8 received at 6881 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: 6881 <at> debbugs.gnu.org
Subject: Re: 23.2; bookmark-bmenu-search makes menu disappear
Date: Thu, 19 Aug 2010 08:10:34 +0100

This is a bug in read-key.

It appears using read-char solve this problem and the key echoing one.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6881: 23.2; bookmark-bmenu-search makes menu disappear
Date: Thu, 19 Aug 2010 11:22:08 +0200

Leo <sdl.web <at> gmail.com> writes:

> This is a bug in read-key.

read-key should not echo the command in minibuffer.

> It appears using read-char solve this problem and the key echoing one.

Note that if read-char is used in `bookmark-read-search-input'
`inhibit-quit' need to be set to t, as read-char is not aware of C-g
like read-key.
It is safe to use inhibit-quit in bookmark-read-search-input, i use it
without problems since months in bookmark-extensions.el (with
read-char).
An alternative to read-char is to use most of the time read-char and
when read-char fail use read-event instead:

(defun ioccur-read-char-or-event (prompt)
  "Replace `read-key' when not available using PROMPT."
  (if (fboundp 'read-key)
      (read-key prompt)
->      (let* ((chr (condition-case nil (read-char prompt) (error nil)))
->             (evt (unless chr (read-event prompt))))
->        (or chr evt))))


-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Message #14 received at 6881 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: 6881 <at> debbugs.gnu.org
Subject: Re: bug#6881: 23.2; bookmark-bmenu-search makes menu disappear
Date: Thu, 19 Aug 2010 16:47:58 +0200

> This is a bug in read-key.
> It appears using read-char solve this problem and the key echoing one.

I strongly encourage people to switch from read-char to read-key, so if
there's a problem with read-key, I'd rather try and fix it rather than
return to read-char.

I've just installed the patch below into emacs-23 which should fix it.


        Stefan


=== modified file 'lisp/subr.el'
--- lisp/subr.el	2010-07-10 18:52:53 +0000
+++ lisp/subr.el	2010-08-19 14:25:12 +0000
@@ -1842,7 +1842,12 @@
                       (throw 'read-key keys)))))))
     (unwind-protect
         (progn
-	  (use-global-map read-key-empty-map)
+	  (use-global-map
+           (let ((map (make-sparse-keymap)))
+             ;; Don't hide the menu-bar and tool-bar entries.
+             (define-key map [menu-bar] (lookup-key global-map [menu-bar]))
+             (define-key map [tool-bar] (lookup-key global-map [tool-bar]))
+             map))
 	  (aref	(catch 'read-key (read-key-sequence-vector prompt nil t)) 0))
       (cancel-timer timer)
       (use-global-map old-global-map))))

Message #17 received at 6881 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 6881 <at> debbugs.gnu.org
Subject: Re: bug#6881: 23.2; bookmark-bmenu-search makes menu disappear
Date: Thu, 19 Aug 2010 16:21:59 +0100

On 2010-08-19 15:47 +0100, Stefan Monnier wrote:
>> This is a bug in read-key.
>> It appears using read-char solve this problem and the key echoing one.
>
> I strongly encourage people to switch from read-char to read-key, so if
> there's a problem with read-key, I'd rather try and fix it rather than
> return to read-char.
>
> I've just installed the patch below into emacs-23 which should fix it.
>
[...]

I confirm the patch fixes the menu bar issue. There is another issue
regarding read-key. I have reported it as another bug and CC'd you.
Thanks.

Regards,
Leo

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6881: 23.2; bookmark-bmenu-search makes menu disappear
Date: Thu, 19 Aug 2010 17:30:23 +0200

Hi Stefan,

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> This is a bug in read-key.
>> It appears using read-char solve this problem and the key echoing one.
>
> I strongly encourage people to switch from read-char to read-key, so if
> there's a problem with read-key, I'd rather try and fix it rather than
> return to read-char.
>
> I've just installed the patch below into emacs-23 which should fix it.

Thanks to fix that so fast.

I didn't try, but that seem to fix the menu-bar problem but not the key
echoing in minibuffer that Leo have reported also.
Here on GNU/Linux, i can't reproduce it, so it's not annoying, but it
seem really annoying for OSX mac users.
It would be great read-key don't echo key in minibuffer.


-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Message #25 received at 6881-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Subject: Re: bug#6881: 23.2; bookmark-bmenu-search makes menu disappear
Date: Thu, 19 Aug 2010 23:37:49 +0200

>> I've just installed the patch below into emacs-23 which should fix it.
> Thanks to fix that so fast.

Closing this bug.  The echoing problem has a new bug number.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.