GNU bug report logs - #68804
[PATCH] Remove an unneeded sed command for emacs.service

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68804: closed ([PATCH] Remove an unneeded sed command for
 emacs.service)
Date: Wed, 12 Feb 2025 03:46:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 11 Feb 2025 19:45:44 -0800
with message-id <CADwFkmkChAR4QqOJAgADFJHqH424y==eRkxQo7O-u4nSN5jBww <at> mail.gmail.com>
and subject line Re: bug#68804: [PATCH] Remove an unneeded sed command for emacs.service
has caused the debbugs.gnu.org bug report #68804,
regarding [PATCH] Remove an unneeded sed command for emacs.service
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68804: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68804
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Lin Jian <me <at> linj.tech>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove an unneeded sed command for emacs.service
Date: Tue, 30 Jan 2024 06:19:09 +0800

[Message part 3 (text/plain, inline)]

Tags: patch


After commit e5348f125ff03ac70713e5b227f9e51f759a587b on
2020-12-14, there is no ExecStop in etc/emacs.service.

So there is no need to use sed to substitute emacsclient for the
ExecStop key.

I propose a patch to remove this unneeded sed command.

In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.18.0, Xaw3d scroll bars)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101010
System Description: NixOS 24.05 (Uakari)

Configured using:
 'configure
 --prefix=/nix/store/mzdvpxzkhlryxmbxwbih7bgvkzkw1ly7-emacs-29.1
 --disable-build-details --with-modules --with-x-toolkit=lucid
 --with-xft --with-cairo --with-compress-install
 --with-toolkit-scroll-bars --with-native-compilation
 --without-imagemagick --without-small-ja-dic --with-tree-sitter
 --with-xinput2 --without-xwidgets'

[0001-Remove-an-unneeded-sed-command-for-emacs.service.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lin Jian <me <at> linj.tech>
Cc: 68804-done <at> debbugs.gnu.org
Subject: Re: bug#68804: [PATCH] Remove an unneeded sed command for
 emacs.service
Date: Tue, 11 Feb 2025 19:45:44 -0800

Version: 31.1

Lin Jian <me <at> linj.tech> writes:

> After commit e5348f125ff03ac70713e5b227f9e51f759a587b on
> 2020-12-14, there is no ExecStop in etc/emacs.service.
>
> So there is no need to use sed to substitute emacsclient for the
> ExecStop key.
>
> I propose a patch to remove this unneeded sed command.

Thanks for the patch, and sorry for the delay in reviewing it.

Installed on master as commit 9e3359475f1.  I'm consequently closing
this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.