From unknown Sat Aug 16 20:58:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#68804 <68804@debbugs.gnu.org> To: bug#68804 <68804@debbugs.gnu.org> Subject: Status: [PATCH] Remove an unneeded sed command for emacs.service Reply-To: bug#68804 <68804@debbugs.gnu.org> Date: Sun, 17 Aug 2025 03:58:20 +0000 retitle 68804 [PATCH] Remove an unneeded sed command for emacs.service reassign 68804 emacs submitter 68804 Lin Jian severity 68804 wishlist tag 68804 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 29 17:21:36 2024 Received: (at submit) by debbugs.gnu.org; 29 Jan 2024 22:21:36 +0000 Received: from localhost ([127.0.0.1]:33644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUa0V-0007Yl-V8 for submit@debbugs.gnu.org; Mon, 29 Jan 2024 17:21:36 -0500 Received: from lists.gnu.org ([2001:470:142::17]:57062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUa0V-0007Ya-0w for submit@debbugs.gnu.org; Mon, 29 Jan 2024 17:21:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUa0A-00020T-DG for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 17:21:15 -0500 Received: from mail.linj.tech ([5.255.109.209]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUa08-0001IB-LB for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 17:21:14 -0500 From: Lin Jian DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail; t=1706566868; bh=lqx/4yLDlqCPozStgKVra984Kic38K+PXMjiTPEqIYk=; h=From:To:Subject:Date; b=w6yKilKjk02b6s0zHv/CT6mMcyUf7hq6h7TjcdcCugHahLTwMFjUrL2I3qNfxGGJE 5xSC/t2WaMPOxuRlz58Mi8/48Bp1dbJNk5KgWSb0dX5VjB7PS7sF3tWcRlUnu0J2mY weOAqJ982CO5R27QTrXaeMBXOMtqbyiUINMEf7epvUw0MR3Fh8ehKohUULSME76+AQ 64ODKoPgybwKABC/NHeNdbqale6ngj1sH9zbbZ9lrAfzE01qXIrftJFdtbj8bja/FR HJcAucWKC7tftz2z6Oo9S7WmPXGIMJBoFSRqRvHG48T9v7s7gQnWWUN7LYdELKce/q ALtjoitvIEeCg== To: bug-gnu-emacs@gnu.org Subject: [PATCH] Remove an unneeded sed command for emacs.service Date: Tue, 30 Jan 2024 06:19:09 +0800 Message-ID: <87cytjye5u.fsf@linj.tech> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=5.255.109.209; envelope-from=me@linj.tech; helo=mail.linj.tech X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch After commit e5348f125ff03ac70713e5b227f9e51f759a587b on 2020-12-14, there is no ExecStop in etc/emacs.service. So there is no need to use sed to substitute emacsclient for the ExecStop key. I propose a patch to remove this unneeded sed command. In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw3d scroll bars) Windowing system distributor 'The X.Org Foundation', version 11.0.12101010 System Description: NixOS 24.05 (Uakari) Configured using: 'configure --prefix=/nix/store/mzdvpxzkhlryxmbxwbih7bgvkzkw1ly7-emacs-29.1 --disable-build-details --with-modules --with-x-toolkit=lucid --with-xft --with-cairo --with-compress-install --with-toolkit-scroll-bars --with-native-compilation --without-imagemagick --without-small-ja-dic --with-tree-sitter --with-xinput2 --without-xwidgets' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Remove-an-unneeded-sed-command-for-emacs.service.patch >From 665c80556750d15ad6ce988078a38c0964bacbf6 Mon Sep 17 00:00:00 2001 From: Lin Jian Date: Tue, 30 Jan 2024 06:12:43 +0800 Subject: [PATCH] Remove an unneeded sed command for emacs.service After commit e5348f125ff03ac70713e5b227f9e51f759a587b on 2020-12-14, there is no ExecStop in etc/emacs.service. * Makefile.in (install-etc): Remove an unneeded sed command for etc/emacs.service. Copyright-paperwork-exempt: yes --- Makefile.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile.in b/Makefile.in index 996f7b8d8c7..57df948a397 100644 --- a/Makefile.in +++ b/Makefile.in @@ -873,11 +873,9 @@ install-etc: rm -f $${tmp} umask 022; $(MKDIR_P) "$(DESTDIR)$(systemdunitdir)" tmp=etc/emacs.tmpservice; rm -f $${tmp}; \ - client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \ sed -e '/^##/d' \ -e "/^Documentation/ s/emacs(1)/${EMACS_NAME}(1)/" \ -e "/^ExecStart/ s|emacs|${bindir}/${EMACS}|" \ - -e "/^ExecStop/ s|emacsclient|${bindir}/$${client_name}|" \ ${srcdir}/etc/emacs.service > $${tmp}; \ $(INSTALL_DATA) $${tmp} "$(DESTDIR)$(systemdunitdir)/${EMACS_NAME}.service"; \ rm -f $${tmp} -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 29 19:42:20 2024 Received: (at control) by debbugs.gnu.org; 30 Jan 2024 00:42:20 +0000 Received: from localhost ([127.0.0.1]:33957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUcCi-0005rR-2J for submit@debbugs.gnu.org; Mon, 29 Jan 2024 19:42:20 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:50328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUcCf-0005qz-Kg for control@debbugs.gnu.org; Mon, 29 Jan 2024 19:42:18 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-55ee686b5d5so2474407a12.0 for ; Mon, 29 Jan 2024 16:42:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706575323; x=1707180123; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=uvrTPj3TgMdp+e9gspW/aEqjKwTA+7KluRz8V2dmifg=; b=CDgNf7nZnuD7JyDVDa653EodTTRmf6OnFZaCa4DId1lLtCQfWkiigkhbz5uP5vG8ja iOcWwFvAPhlIqI+32/Atg9AElXQEv2R4s3pp4jiq2IVPQnChUElvG8ADsEHVy1CDLoiO 6GRwAVV7QcP+sIqkpGRaWRax+ybxw9Ujhtg1SCNXSbRrB/hvC+DZMo+MGTtLU7XnTn22 exbRTP1vqV0SvOy7kVyDueHlv4kcHf1uuJpVE+bT54Kfxt7d3OKutz3PFzrRZWzrY6A6 n0SYZl7UQK03uywTN6+1PH3CRSIfoUCi2r2knv7CyHd467ZgS6+xOx+10iEZ711JdwSf MiCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706575323; x=1707180123; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uvrTPj3TgMdp+e9gspW/aEqjKwTA+7KluRz8V2dmifg=; b=Q1qJbhgthNppJbhJdVl2G4sqMk3gt/0DmjkLkIyBVnFWKCpfyER5V9/OvrXa1WnFFz 1wfqepdzTSkMptqM8vzPA8vV4t0PQhsElCgSf3Mha9nolhJJUBUzONm/fJQg2V3//J2s 94+6Nfgstl81XHjawgBC5OUQJmFddy824OlMOpB46qxLuEzy8Gh9alnCg9RnvRORqeO+ KXte0XVXT9KNUa8WdUBWyNIb28BgUyxxaSjix5wqXpu2IzSKwYPRxy67kNYMwHmktkRd dyP+hDssBMSHOjwdfaiFuRIgqpQfRjeSsMI0J1U2Iaf12B0sAHU8AdEj1JxSI7DRAFF8 Q1yQ== X-Gm-Message-State: AOJu0YzlNJR6ubShc2ltG4drUp3iJSsJYljYKVrmQ5n91mY463Xb4PYi /eA7bzmObTTkVU8wXHk0R/VeTCw197AXAjWd1MNDxdcPm+GnwRSK2hrzyPGYPZmaJTcPP/Sik4d rP+74Au7zwJPQOzYh/X31IbvZ0ZK6n+6Sgf0= X-Google-Smtp-Source: AGHT+IHzhl4sipfRiEq+vMDCf2FgzkB4rTCVY1N4UaIrM0Y/xmOmnn+Ul31djM16v2YW2I13GvySWy2E8aPFmBOIvPA= X-Received: by 2002:aa7:cc97:0:b0:55d:2b55:f1e2 with SMTP id p23-20020aa7cc97000000b0055d2b55f1e2mr4912403edt.37.1706575323328; Mon, 29 Jan 2024 16:42:03 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 29 Jan 2024 19:42:03 -0500 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 29 Jan 2024 19:42:03 -0500 Message-ID: Subject: control message for bug #68804 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 68804 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 11 22:45:55 2025 Received: (at 68804-done) by debbugs.gnu.org; 12 Feb 2025 03:45:55 +0000 Received: from localhost ([127.0.0.1]:60014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ti3hC-0007jt-Vp for submit@debbugs.gnu.org; Tue, 11 Feb 2025 22:45:55 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:51231) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ti3h9-0007PS-Sz for 68804-done@debbugs.gnu.org; Tue, 11 Feb 2025 22:45:52 -0500 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5de849a0b6cso5235790a12.2 for <68804-done@debbugs.gnu.org>; Tue, 11 Feb 2025 19:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739331946; x=1739936746; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=wMnx9cO9G2N8r0w7SJcSyV2KiEmAwkhAgaqadrXVK3k=; b=fZordOWNH401SBWHSpeE8r22l223EGAcWaUHKhLvxdT2LAP+6TSq2/vqs6OiMJJC89 y5OIfb+2XZEnO8R4+rvkHiESA5Sfy1O6ejo1yjmLf+JxRrBA99sRe1Pnc0AX6DkFpJid rAg+u+dZE9HibOSxAit4x7t3He0XXewR/W3+3+Jg0ayoGnXCLGu3asJUt1COTB6XOhk1 A2jmfAbPwnAV6BNM2p9Tv1bAMJrTUg7HjcS79AoCY8f1738dmmz6RMkSDKGTBcZSL47u +zM3Tgi5el81ukCN0Ya4LCJ7czOHau2eCGwrD5/s+xV6ZuJeGbKz1OuFA/eLkSklRl1K lNJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739331946; x=1739936746; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wMnx9cO9G2N8r0w7SJcSyV2KiEmAwkhAgaqadrXVK3k=; b=iJ6/zmNFEHs+SdSmNQpTrVLFTyilLjL11L9i6/iFxaIKUD5aJl8VwauTUZ31Lsrt3f 9HjetdiZi4kmRb0Bn2JtkWvslAfHxxL2ZmHLrCjfLLQ8eH0nhP+K3PGeo7LySfPPJagh GxQW6QtamlP/my8wO75U6W4PPrvzG4bOdwulNKXkWe8EKp/ehutg8Aqm560ei74LcQbR 6iyEvfrIUYfWXxIGTLqVEDvhENPzVnUKWrq9LxNQIqFALFQ8DDrTyBcQbX/d+DzKCfEF e8x2nBCNRrNphOQrWv3/ZHdXFP2rb4+8TnN3GAw/e7KGnoKCozHwREz0RuGswer4+LEp 9Mrg== X-Gm-Message-State: AOJu0YwOFqTVzGVCgzkAWTBXsyyBM/Wbl025c/3yv6Lu42TpwYoJnVvx Q++xkdc+wFD7lIS6sV0IjakXGBEOD5QHpUvGrtKEnl7zN7F1hGpu0M3cXFnXo6qs0wEuWrswGl3 fxsXgMs+9HCxl7oVGe68Bbw6bN/evfrnevKd09g== X-Gm-Gg: ASbGncsKR1/evB5Bw9P39um3XgZsyUQJDB+//9fqqdsupZBzzgMuUFm+fMeRK1IkyYq T72a5BOHdjvvP/q7hLFUdKDoRfu/r7PaKJUbXRDhvSWt9ylZywaLptF+tfpAIlmLrTrvCim1p X-Google-Smtp-Source: AGHT+IFgiSrGWe/+jZowyZ8nWqac4YmHNAzAkqmuj+jQTTW9/KCMEjQMIfRW709he2I7o6W4LHNYtNas9rUTE1QM3Jc= X-Received: by 2002:a05:6402:358a:b0:5de:aa54:dc30 with SMTP id 4fb4d7f45d1cf-5deadd7213amr1405806a12.5.1739331945507; Tue, 11 Feb 2025 19:45:45 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 19:45:44 -0800 From: Stefan Kangas In-Reply-To: <87cytjye5u.fsf@linj.tech> References: <87cytjye5u.fsf@linj.tech> MIME-Version: 1.0 Date: Tue, 11 Feb 2025 19:45:44 -0800 X-Gm-Features: AWEUYZlssxdTOfGr0LDQugosyicFrpO8AZ2DWFBUpTKV1_cLduQRwkbu3U_BV_M Message-ID: Subject: Re: bug#68804: [PATCH] Remove an unneeded sed command for emacs.service To: Lin Jian Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 68804-done Cc: 68804-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Lin Jian writes: > After commit e5348f125ff03ac70713e5b227f9e51f759a587b on > 2020-12-14, there is no ExecStop in etc/emacs.service. > > So there is no need to use sed to substitute emacsclient for the > ExecStop key. > > I propose a patch to remove this unneeded sed command. Thanks for the patch, and sorry for the delay in reviewing it. Installed on master as commit 9e3359475f1. I'm consequently closing this bug report. From unknown Sat Aug 16 20:58:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 12 Mar 2025 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator