GNU bug report logs - #68801
30.0.50; minibuffer-visible-completions=t makes RET in completion-in-region a no-op with nothing selected

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 68801 <at> debbugs.gnu.org, sbaugh <at> catern.com
Subject: bug#68801: 30.0.50; minibuffer-visible-completions=t makes RET in completion-in-region a no-op with nothing selected
Date: Thu, 29 Feb 2024 19:56:31 +0200

> Spencer Baugh <sbaugh <at> janestreet.com> writes:
>> I'm thinking the right thing to do is just to go with my original patch
>> which only binds RET when there's a selected completion.  That's simple
>> and straightforward.
>>
>> But I'm not sure how to adapt my completion-show-help change for that: I
>> want to hint to the user that they should hit RET, but RET is only bound
>> when a completion is selected, which isn't the case when *Completions*
>> is first displayed.  Any ideas?  Could we just hardcode "RET" in the
>> help text?
>
> The solution is obvious in retrospect, just add a defvar to force the
> bindings on.
>
> Complete patch attached, I think this closes the bug.

Good idea, thanks.  I will test your patch for a while.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.