Subject: bug#68799: 30.0.50; emacs --fg-daemon fails silently if server-start fails

From: Eli Zaretskii <[email-masked]>
Date: Mon, 29 Jan 2024 19:44:43 +0200

> From: Spencer Baugh <[email-masked]>
> Cc: [email-masked]
> Date: Mon, 29 Jan 2024 12:32:00 -0500
> 
> Eli Zaretskii <[email-masked]> writes:
> 
> >> So the problem seems to be that somehow server-start succeeds to leave
> >> a non-nil server-process variable behind, although testing that is the
> >> documented way of telling whether server is running.
> >
> > Or maybe server-start signals an error, and then the code which shows
> > an error message and shuts down Emacs doesn't get run?
> 
> Yes, that's exactly what happens.
> 
> So should we wrap a condition-case around server-start, I suppose?

Probably.  But perhaps we should also modify server-start so that,
when it is called from a daemon, it signals in this case a distinct
error, which startup.el could then detect and display a friendly error
message.