GNU bug report logs - #68789
[PATCH 0/2] gnu: Add python-pyjanitor.

Previous Next

Full log

View this message in rfc822 format

From: Troy Figiel <troy <at> troyfigiel.com>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 68789 <at> debbugs.gnu.org
Subject: [bug#68789] [PATCH 0/2] gnu: Add python-pyjanitor.
Date: Mon, 29 Jan 2024 18:18:57 +0100

[Message part 1 (text/plain, inline)]

Hi Oleg,

Thanks for the check!

On 2024-01-29 15:26, Sharlatan Hellseher wrote:
> One note - you introduced a module cycle which was not before
> astronomy->python-science->astronomy. If the requirement of
> python-astropy is soft let's silent it for now.

Removing the python-astropy dependency should be fine for python-unyt. I
agree that avoiding module cycles would be better. If I recall
correctly, Astropy was only used in tests, because it has a similar
submodule dealing with physical units.

The build was successful and the cycle did not show up in the linter.
How did you find it? Did you happen to notice it when you saw the imports?

Best wishes,

Troy

[OpenPGP_0xC67C9181B3893FB0.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.