GNU bug report logs - #68765
30.0.50; Adding window-tool-bar package.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68765: closed (30.0.50; Adding window-tool-bar package.)
Date: Sun, 09 Jun 2024 13:11:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 09 Jun 2024 15:23:18 +0300
with message-id <86wmmy9ufd.fsf <at> gnu.org>
and subject line Re: bug#68765: 30.0.50; Adding window-tool-bar package.
has caused the debbugs.gnu.org bug report #68765,
regarding 30.0.50; Adding window-tool-bar package.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68765: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68765
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jared Finder <jared <at> finder.org>
To: Bug-gnu Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 30.0.50; Adding window-tool-bar package.
Date: Sat, 27 Jan 2024 15:36:56 -0800

[Message part 3 (text/plain, inline)]

This is a follow-up from bug#68334 where there was interest in adding 
support into Emacs core for tool bars in windows. 
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68334#52)  I have 
attached three changes I authored to accomplish this, two small changes 
to tool-bar and tab-line, and then a code drop of my window-tool-bar.el 
package.  I have not yet put in documentation in NEWS or the manual 
about window-tool-bar and was hoping to get a code review done first.

I think it would be good to have window-tool-bar.el also be a package so 
that I can keep supporting Emacs 29 as well.  I am happy to have this 
put on GNU ELPA and would appreciate help in getting that completed.

I am open to renaming the package and public functions if that's 
desired.  I like the name "window-tool-bar-mode" as it clearly relates 
to tool-bar-mode.

After these patches are accepted, I'd also like to clean up the existing 
tool bar maps for built in minor modes.  This would allow me to address 
Eli's request to have a usable tool bar for M-x gdb 
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68334#23).

For tracking purposes, I signed copyright paperwork back in 2020, so 
that shouldn't be an issue.  Thanks.

  -- MJF

[0001-Enable-multiple-modes-to-appear-in-tab-line.patch (text/x-diff, attachment)]

[0002-Add-user-option-to-only-display-default-tool-bar.patch (text/x-diff, attachment)]

[0003-Adding-window-tool-bar-package.patch (text/x-diff, attachment)]

[Message part 7 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jared Finder <jared <at> finder.org>
Cc: philipk <at> posteo.net, 68765-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca,
 juri <at> linkov.net
Subject: Re: bug#68765: 30.0.50; Adding window-tool-bar package.
Date: Sun, 09 Jun 2024 15:23:18 +0300

> Date: Sat, 08 Jun 2024 17:29:15 -0700
> From: Jared Finder <jared <at> finder.org>
> Cc: juri <at> linkov.net, 68765 <at> debbugs.gnu.org, philipk <at> posteo.net,
>  monnier <at> iro.umontreal.ca
> 
> > This LGTM, with one comment: you mention in the section about window
> > tool bars that it cannot be shown if a tab line is shown in the
> > window, but you don't have a similar caveat in the section about tab
> > lines.  I think we should add a similar caveat there as well.
> 
> Patch attached for updated manual, NEWS, and changes to 
> window-tool-bar.el.  This also extends support back to Emacs 27 in the 
> package as requested earlier in this thread.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.