Subject: Re: bug#68761: [PATCH] Record dependencies in packages installed via package-vc

From: Philip Kaludercic <[email-masked]>
Date: Tue, 06 Feb 2024 20:05:25 +0000

Steven Allen <[email-masked]> writes:

> The dependency list wasn't getting recorded in the package's `-pkg.el` file.

Did you notice this because of some bug or what is the motivation for
this change?  I'll certainly look into it, I just wanted some context.

>>>From edc9f75958d5feb2a82c53879e9dde4c51921bb6 Mon Sep 17 00:00:00 2001
> From: Steven Allen <[email-masked]>
> Date: Sat, 27 Jan 2024 08:17:08 -0800
> Subject: [PATCH] Record dependencies in packages installed via package-vc
>
> * lisp/emacs-lisp/package-vc.el (package-vc--unpack-1): Record a
> package's declared dependencies in the package's metadata ("-pkg.el").
> ---
>  lisp/emacs-lisp/package-vc.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
> index db0cc515e46..fc402716dab 100644
> --- a/lisp/emacs-lisp/package-vc.el
> +++ b/lisp/emacs-lisp/package-vc.el
> @@ -532,6 +532,7 @@ package-vc--unpack-1
>                  (setq deps))))))
>        (dolist (dep deps)
>          (cl-callf version-to-list (cadr dep)))
> +      (setf (package-desc-reqs pkg-desc) deps)
>        (setf missing (package-vc-install-dependencies (delete-dups deps)))
>        (setf missing (delq (assq (package-desc-name pkg-desc)
>                                  missing)