Subject: bug#68761: closed (Re: bug#68761: [PATCH] Record dependencies in packages installed via package-vc)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 10 Feb 2024 16:05:01 +0000

Your bug report

#68761: [PATCH] Record dependencies in packages installed via package-vc

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
68761: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68761
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#68761: [PATCH] Record dependencies in packages installed via package-vc
From: Philip Kaludercic <[email-masked]>
To: Steven Allen <[email-masked]>
Cc: Eli Zaretskii <[email-masked]>, [email-masked]
Date: Sat, 10 Feb 2024 15:54:36 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Steven Allen <[email-masked]> writes:

>>> I wouldn't clarify it as an emergency, at most a regrettable
>>> inconvenience.
>>
>> Then I tend to think this should be installed on master.
>
> I agree. Users will only run into it if they:
>
> 1. Use `package-vc` (very new and has quite a few sharp edges).
> 2. Use the "package-autoremove" feature.
>
> Given that nobody else has reported this, it's probably not causing too
> many issues.

OK, I have applied the branch to master.

Thanks!

-- 
Philip Kaludercic

Subject: [PATCH] Record dependencies in packages installed via package-vc
From: Steven Allen <[email-masked]>
To: [email-masked]
Date: Sat, 27 Jan 2024 08:22:23 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

The dependency list wasn't getting recorded in the package's `-pkg.el` file.

>From edc9f75958d5feb2a82c53879e9dde4c51921bb6 Mon Sep 17 00:00:00 2001
From: Steven Allen <[email-masked]>
Date: Sat, 27 Jan 2024 08:17:08 -0800
Subject: [PATCH] Record dependencies in packages installed via package-vc

* lisp/emacs-lisp/package-vc.el (package-vc--unpack-1): Record a
package's declared dependencies in the package's metadata ("-pkg.el").
---
 lisp/emacs-lisp/package-vc.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index db0cc515e46..fc402716dab 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -532,6 +532,7 @@ package-vc--unpack-1
                 (setq deps))))))
       (dolist (dep deps)
         (cl-callf version-to-list (cadr dep)))
+      (setf (package-desc-reqs pkg-desc) deps)
       (setf missing (package-vc-install-dependencies (delete-dups deps)))
       (setf missing (delq (assq (package-desc-name pkg-desc)
                                 missing)
-- 
2.43.0