From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 26 16:39:00 2024 Received: (at submit) by debbugs.gnu.org; 26 Jan 2024 21:39:00 +0000 Received: from localhost ([127.0.0.1]:52947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTTud-0003I1-O1 for submit@debbugs.gnu.org; Fri, 26 Jan 2024 16:39:00 -0500 Received: from lists.gnu.org ([2001:470:142::17]:50174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTTub-0003Hm-MX for submit@debbugs.gnu.org; Fri, 26 Jan 2024 16:38:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTTuP-000803-Du for bug-gnu-emacs@gnu.org; Fri, 26 Jan 2024 16:38:45 -0500 Received: from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTTuN-0004Fr-D2 for bug-gnu-emacs@gnu.org; Fri, 26 Jan 2024 16:38:45 -0500 Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-59a0d71b0fdso331040eaf.3 for ; Fri, 26 Jan 2024 13:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706305120; x=1706909920; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=AiWHOF0JSYn+CntXxxhXTEKmM5fuhh4lAxIRy1GskoQ=; b=UgBuNMaNRGH7yzcNHPptxSLmNnL44YZ41X5mmT/Lyc6bNupzM3Pi2v+kGWjtEWV9/I NnXe3jowNUT8mR/SMbPWbIZNepMhRg7eVhApt91rqYcKqccy3PmVfYSkbkdcRnMW8+7Y junvi/eXRcrqDHd7U/DDWwk1A8ObLVmha2D6CFUQNvsB+k39vT467NU596CmW3NqCxLS y6axENyz140uUIbf8fkOgrj4Jjj2yb78/AiT9mkOwOp+eDqZSxAcXQgYPoz7sXlA1WVm 4b3csjN3JEVbpeWFaelrHe/lQKfFZ2CHXoR9sdSu7rkWDa7CujmZ5sHV0dIaVGUqplq4 55pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706305120; x=1706909920; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AiWHOF0JSYn+CntXxxhXTEKmM5fuhh4lAxIRy1GskoQ=; b=GL0Cqh7mYvk/GOCeIA0DRVvcsBBJD91oqS3itFKFh4YZRwG0UFDEuqudqvVqyzWIKL uAVPYCXEjIHGp1uzTZ+/lksxL+ym+J+HrHATSq5DaXV4pjVIUaqIoQoGzHZd+JOQcH7l 4f6/eJJjCWvtZa411WAMGbkHE03uvh5F+ITELJAyW00FWvWE/ZaJZGzyTcR7n3q/HxgJ niVbgMLs1DTlWQFhLF9ZeHTY/e7AgZO6/mPNA1fOOzklOFn9e33be9D870YY6l92CWBz Kz5blvUyIy6RnifYxBdRygPbKM0tu20FX5EqRy3xjhqyHT829SecnMK+twfzhidNQCLE Y7cg== X-Gm-Message-State: AOJu0YwoqnLcPTdBthq/QmKMJ4pbHevdfY+Rzs1ui1cxOPhg+z2GHxTQ rczuRAu4oc2J6oJkcM70p/1zO6OdVJ2tPsHfRpLcHPqsYKq8v+Wo4N9Ow5xKsBaVblo+/TvACqY LN0yVzHDqa9ue7usRvDrVkt2cJMgXcoolnJs= X-Google-Smtp-Source: AGHT+IGbqLkf2H7Q9BGJQQt2jjeWf7dsKJ9F/D0K42flkPGIn98M9GrE/pv+O7lZg+JdyBvXgVlrZWq6rCxFG8TYDuk= X-Received: by 2002:a4a:e3cc:0:b0:599:d873:cbbe with SMTP id m12-20020a4ae3cc000000b00599d873cbbemr321370oov.11.1706305120369; Fri, 26 Jan 2024 13:38:40 -0800 (PST) MIME-Version: 1.0 From: Paul Nelson Date: Fri, 26 Jan 2024 22:38:28 +0100 Message-ID: Subject: [PATCH] 30.0.50; calc vector parsing: spaces should not be separators except with [...] To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000009471be060fe01e5a" Received-SPF: pass client-ip=2607:f8b0:4864:20::c31; envelope-from=ultrono@gmail.com; helo=mail-oo1-xc31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --0000000000009471be060fe01e5a Content-Type: text/plain; charset="UTF-8" There are two ways to input vectors (or matrices) in calc. (A) Using brackets (e.g., [x,y,z]), in any language mode. (B) Using language-specific constructions (e.g., \begin{pmatrix} x & y & z \end{pmatrix} in latex mode). I would like to report a bug with (B) and to propose a fix. Steps to reproduce (all with emacs -Q): use "C-x * * d L" to start calc and set the language mode to latex, then evaluate the lisp forms below, e.g., in the *scratch* buffer. Example 1: parsing gives the wrong answer. (math-read-expr "\\begin{pmatrix} x y & z \\end{pmatrix}") Result: (vec (var x var-x) (var y var-y) (var z var-z)) Expected result: (vec (* (var x var-x) (var y var-y)) (var z var-z)) Example 2: parsing gives an error on valid latex. (math-read-expr "\\begin{pmatrix} x \\\\ y + 1 \\end{pmatrix}") Result: (error 24 "Expected a number") Expected result: (vec (vec (var x var-x)) (vec (+ (var y var-y) 1))) These examples are not contrived. They make it infeasible to use calc as a latex parser for matrices. Fortunately, they are easy to fix. Both issues arise because calc allows spaces as separators with both methods (A) and (B). I believe that spaces should be allowed as separators with method (A) (e.g., [x y z] as an alternative to [x,y,z]), but never with method (B). With the attached patch, calc allows spaces as separators in a vector only when the vector was specified using "[". In GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin22.5.0, NS appkit-2299.60 Version 13.4.1 (Build 22F82)) of 2023-08-17 built on d51735 Repository revision: 5856ea5e4e897f4cb5cd1c3c28d14b335fe5cf54 Repository branch: master Windowing system distributor 'Apple', version 10.3.2487 System Description: macOS 14.2.1 Configured using: 'configure --with-ns --with-native-compilation --with-tree-sitter --with-gif --with-png --with-jpeg --with-rsvg --with-tiff --with-imagemagick --with-x-toolkit=gtk3 --with-xwidgets' Configured features: ACL DBUS GLIB GNUTLS IMAGEMAGICK JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM XWIDGETS ZLIB Important settings: value of $LC_CTYPE: UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils calc-vec calc-aent calc-math calc-lang compile text-property-search comint ansi-osc ansi-color ring comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile calc-ext calc-misc cl-loaddefs cl-lib calc-menu calc calc-loaddefs rect calc-macs rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads xwidget-internal dbusbind kqueue cocoa ns lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 129014 14615) (symbols 48 11069 0) (strings 32 29343 1471) (string-bytes 1 823136) (vectors 16 20069) (vector-slots 8 395724 11724) (floats 8 43 191) (intervals 56 259 0) (buffers 992 13)) --0000000000009471be060fe01e5a Content-Type: application/octet-stream; name="0001-fix-space-separator-bug-in-calc-parsing.patch" Content-Disposition: attachment; filename="0001-fix-space-separator-bug-in-calc-parsing.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lrv5t3ne0 RnJvbSBjNjZhMDEyZGFjZmJhNDcwMGExZDM5YWNkZjdmMmZkODMwNDA2N2QwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIE5lbHNvbiA8dWx0cm9ub0BnbWFpbC5jb20+CkRhdGU6 IEZyaSwgMjYgSmFuIDIwMjQgMjI6MTI6MDAgKzAxMDAKU3ViamVjdDogW1BBVENIXSBmaXggc3Bh Y2Ugc2VwYXJhdG9yIGJ1ZyBpbiBjYWxjIHBhcnNpbmcKCi0tLQogbGlzcC9jYWxjL2NhbGMtYWVu dC5lbCB8IDkgKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9jYWxjL2NhbGMtYWVudC5lbCBiL2xpc3AvY2Fs Yy9jYWxjLWFlbnQuZWwKaW5kZXggMDhlOGQ5ZmNkNmYuLmRlNTllYjk3NGFkIDEwMDY0NAotLS0g YS9saXNwL2NhbGMvY2FsYy1hZW50LmVsCisrKyBiL2xpc3AvY2FsYy9jYWxjLWFlbnQuZWwKQEAg LTEyNzAsNyArMTI3MCwxNCBAQCBtYXRoLXJlYWQtZmFjdG9yCiAJICAgKG1hdGgtcmVhZC1zdHJp bmcpKQogCSAgKChlcXVhbCBtYXRoLWV4cHItZGF0YSAiWyIpCiAJICAgKHJlcXVpcmUgJ2NhbGMt ZXh0KQotCSAgIChtYXRoLXJlYWQtYnJhY2tldHMgdCAiXSIpKQorCSAgIChsZXQgKChzcGFjZS1z ZXAKKyAgICAgICAgICAgICAgICAgIDs7IEFsbG93IHNwYWNlcyBhcyBzZXBhcmF0b3JzIHdoZW4g dGhlIHZlY3RvciBpcworICAgICAgICAgICAgICAgICAgOzsgc3BlY2lmaWVkIHVzaW5nICJbIiwg YnV0IG5vdCB3aGVuIGl0IGlzIHNwZWNpZmllZAorICAgICAgICAgICAgICAgICAgOzsgdXNpbmcg bGFuZ3VhZ2Utc3BlY2lmaWMgY29uc3RydWN0aW9ucyBzdWNoIGFzCisgICAgICAgICAgICAgICAg ICA7OyAiXFxiZWdpbntwbWF0cml4fSIuCisgICAgICAgICAgICAgICAgICAoZXF1YWwgIlsiIChz dWJzdHJpbmcgbWF0aC1leHAtc3RyIG1hdGgtZXhwLW9sZC1wb3MKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBtYXRoLWV4cC1wb3MpKSkpCisgICAgICAgICAgICAgKG1h dGgtcmVhZC1icmFja2V0cyBzcGFjZS1zZXAgIl0iKSkpCiAJICAoKGVxdWFsIG1hdGgtZXhwci1k YXRhICJ7IikKIAkgICAocmVxdWlyZSAnY2FsYy1leHQpCiAJICAgKG1hdGgtcmVhZC1icmFja2V0 cyBuaWwgIn0iKSkKLS0gCjIuMzkuMyAoQXBwbGUgR2l0LTE0NSkKCg== --0000000000009471be060fe01e5a--