GNU bug report logs - #68742
[PATCH] gnu: river: add river.desktop on wayland-sessions

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68742: closed ([PATCH] gnu: river: add river.desktop on
 wayland-sessions)
Date: Wed, 14 Feb 2024 13:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 14 Feb 2024 13:33:11 +0000
with message-id <87jzn7891c.fsf <at> cbaines.net>
and subject line Re: [bug#68742] QA review for 68742
has caused the debbugs.gnu.org bug report #68742,
regarding [PATCH] gnu: river: add river.desktop on wayland-sessions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68742: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68742
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Erik Eduardo <eduarskate8 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Erik Eduardo <erikeah <at> protonmail.com>
Subject: [PATCH] gnu: river: add river.desktop on wayland-sessions
Date: Fri, 26 Jan 2024 17:09:09 +0000

From: Erik Eduardo <erikeah <at> protonmail.com>

This patch will allow to login from login managers or display managers
to River.

Changes:

  - Creates a directory at share named wayland-sessions
  - Install a desktop file from repo inside share/wayland-sessions

This is my first patch, please be patient and give me feedback, I will
do my best.

Change-Id: Iea8999cf97bedc8fb7ede4dd22b8f0f9529d2fa1
---
 gnu/packages/zig-xyz.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/zig-xyz.scm b/gnu/packages/zig-xyz.scm
index 200b5c9940..ca73c6bad8 100644
--- a/gnu/packages/zig-xyz.scm
+++ b/gnu/packages/zig-xyz.scm
@@ -52,7 +52,16 @@ (define-public river
     (build-system zig-build-system)
     (arguments
      (list
-      #:zig-build-flags #~(list "-Dxwayland")   ;experimental xwayland support
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'install 'install-extra-files
+                     (lambda* (#:key outputs #:allow-other-keys)
+                       (let* ((out (assoc-ref outputs "out"))
+                              (wayland-sessions (string-append out
+                                                 "/share/wayland-sessions")))
+                         (mkdir-p wayland-sessions)
+                         (install-file "contrib/river.desktop"
+                                       wayland-sessions)))))
+      #:zig-build-flags #~(list "-Dxwayland") ;experimental xwayland support
       #:zig-release-type "safe"))
     (native-inputs (list libevdev
                          libxkbcommon

base-commit: 2266754382bce43789976aec65181cb5085c8bc4
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>, Erik Eduardo <eduarskate8 <at> gmail.com>
Cc: 68742-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#68742] QA review for 68742
Date: Wed, 14 Feb 2024 13:33:11 +0000

[Message part 4 (text/plain, inline)]

Ekaitz Zarraga <ekaitz <at> elenq.tech> writes:

> user guix
> usertag 68742 + reviewed-looks-good
> thanks
>
> Guix QA review form submission:
> It's a simple addition. I think it's ok.
> I linted, and I also built, and things the author expected work.
>
> Items marked as checked: Lint warnings, Package builds, Commit messages

Thanks both, I've tweaked the indentation a little and pushed this to
master as 8d4c3032416c69f883d074f4f6d7bcc9741be75c.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.