GNU bug report logs - #68735
[PATCH] gnu: Add python-gguf.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68735 in the body.
You can then email your comments to 68735 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Pflug <david <at> pflug.io>
To: guix-patches <at> gnu.org
Cc: David Pflug <david <at> pflug.io>
Subject: [PATCH] gnu: Add python-gguf.
Date: Fri, 26 Jan 2024 07:12:32 -0500

* gnu/packages/machine-learning.scm (python-gguf): New variable.

Needed for llama-cpp update (In #68455).

Change-Id: Icf6138486cccc5b4c3141424baccf17c4edb3449
---
 gnu/packages/machine-learning.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 3a12eb8c2f..0e88f7265b 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2023 Navid Afkhami <navid.afkhami <at> mdc-berlin.de>
 ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2023 Troy Figiel <troy <at> troyfigiel.com>
+;;; Copyright © 2024 David Pflug <david <at> pflug.io>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5277,3 +5278,25 @@ (define-public oneapi-dnnl
      "OneAPI Deep Neural Network Library (oneDNN) is a cross-platform
 performance library of basic building blocks for deep learning applications.")
     (license license:asl2.0)))
+
+(define-public python-gguf
+  (package
+    (name "python-gguf")
+    (version "0.6.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "gguf" version))
+       (sha256
+        (base32 "0rbyc2h3kpqnrvbyjvv8a69l577jv55a31l12jnw21m1lamjxqmj"))))
+    (build-system pyproject-build-system)
+    (arguments
+      `(#:phases
+        (modify-phases %standard-phases
+                       (delete 'check))))
+    (inputs (list poetry python-pytest))
+    (propagated-inputs (list python-numpy))
+    (home-page "https://ggml.ai")
+    (synopsis "Read and write ML models in GGUF for GGML")
+    (description "Read and write ML models in GGUF for GGML")
+    (license license:expat)))

base-commit: cdf1d7dded027019f0ebbd5d6f0147b13dfdd28d
-- 
2.41.0

Message #8 received at 68735 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 68735 <at> debbugs.gnu.org
Cc: david <at> pflug.io
Subject: [PATCH] gnu: Add python-gguf.
Date: Fri, 26 Jan 2024 15:28:44 +0100

Hi David,

thanks for the patch.

Why do you delete the check phase?  When tests are to be disabled please
use “#:tests? #false”.  If no tests are included in the Pypi tarball,
please fetch the code from the upstream repository instead.

Please use a plain list for the arguments field.

Please also use complete sentences in the description field.

-- 
Ricardo

Message #11 received at 68735 <at> debbugs.gnu.org (full text, mbox):

From: "David Pflug" <david <at> pflug.io>
To: "Ricardo Wurmus" <rekado <at> elephly.net>, <68735 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: Add python-gguf.
Date: Fri, 26 Jan 2024 11:12:43 -0500

[Message part 1 (text/plain, inline)]

Hi Ricardo,

Thanks for the feedback. I'd been trying to skip tests because upstream only provides a stub: https://github.com/ggerganov/llama.cpp/blob/master/gguf-py/tests/test_gguf.py

I'll prep a v2 with the requested changes.

Warm Regards,

David

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 68735 <at> debbugs.gnu.org (full text, mbox):

From: David Pflug <david <at> pflug.io>
To: 68735 <at> debbugs.gnu.org
Cc: David Pflug <david <at> pflug.io>
Subject: [PATCH v2] gnu: Add python-gguf.
Date: Fri, 26 Jan 2024 11:27:22 -0500

* gnu/packages/machine-learning.scm (python-gguf): New variable.

Change-Id: Icf6138486cccc5b4c3141424baccf17c4edb3449
---
 gnu/packages/machine-learning.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 3a12eb8c2f..0e88f7265b 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2023 Navid Afkhami <navid.afkhami <at> mdc-berlin.de>
 ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2023 Troy Figiel <troy <at> troyfigiel.com>
+;;; Copyright © 2024 David Pflug <david <at> pflug.io>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5277,3 +5278,25 @@ (define-public oneapi-dnnl
      "OneAPI Deep Neural Network Library (oneDNN) is a cross-platform
 performance library of basic building blocks for deep learning applications.")
     (license license:asl2.0)))
+
+(define-public python-gguf
+  (package
+    (name "python-gguf")
+    (version "0.6.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "gguf" version))
+       (sha256
+        (base32 "0rbyc2h3kpqnrvbyjvv8a69l577jv55a31l12jnw21m1lamjxqmj"))))
+    (build-system pyproject-build-system)
+    (arguments
+      `(#:phases
+        (modify-phases %standard-phases
+                       (delete 'check))))
+    (inputs (list poetry python-pytest))
+    (propagated-inputs (list python-numpy))
+    (home-page "https://ggml.ai")
+    (synopsis "Read and write ML models in GGUF for GGML")
+    (description "Read and write ML models in GGUF for GGML")
+    (license license:expat)))

base-commit: cdf1d7dded027019f0ebbd5d6f0147b13dfdd28d
-- 
2.41.0

Message #17 received at 68735 <at> debbugs.gnu.org (full text, mbox):

From: David Pflug <david <at> pflug.io>
To: 68735 <at> debbugs.gnu.org
Cc: David Pflug <david <at> pflug.io>
Subject: [PATCH v3] gnu: Add python-gguf.
Date: Fri, 26 Jan 2024 22:50:30 -0500

* gnu/packages/machine-learning.scm (python-gguf): New variable.

Change-Id: Icf6138486cccc5b4c3141424baccf17c4edb3449
---
 gnu/packages/machine-learning.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 3a12eb8c2f..8beedb24fa 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2023 Navid Afkhami <navid.afkhami <at> mdc-berlin.de>
 ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2023 Troy Figiel <troy <at> troyfigiel.com>
+;;; Copyright © 2024 David Pflug <david <at> pflug.io>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5277,3 +5278,23 @@ (define-public oneapi-dnnl
      "OneAPI Deep Neural Network Library (oneDNN) is a cross-platform
 performance library of basic building blocks for deep learning applications.")
     (license license:asl2.0)))
+
+(define-public python-gguf
+  (package
+    (name "python-gguf")
+    (version "0.6.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "gguf" version))
+       (sha256
+        (base32 "0rbyc2h3kpqnrvbyjvv8a69l577jv55a31l12jnw21m1lamjxqmj"))))
+    (build-system pyproject-build-system)
+    (arguments
+      (list #:tests? #false))
+    (inputs (list poetry python-pytest))
+    (propagated-inputs (list python-numpy))
+    (home-page "https://ggml.ai")
+    (synopsis "Read and write ML models in GGUF for GGML")
+    (description "A Python library for reading and writing GGUF & GGML format ML models.")
+    (license license:expat)))

base-commit: cdf1d7dded027019f0ebbd5d6f0147b13dfdd28d
-- 
2.41.0

Message #22 received at 68735-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 68735-done <at> debbugs.gnu.org
Subject: Close
Date: Sun, 11 Feb 2024 09:27:32 +0100

Pushed as commit b6439fc5f800b5d22d48192bc347be794f050329 after adding the
first line of the commit message and a comment to explain why tests are
disabled, and turning the synopsis into a complete sentence.

QA suggests to put python-pytest into native instead of regular inputs;
but "guix gc --references" shows that the package retains references
to python-pytest and to poetry, so I kept them where they are.

Ricardo, please feel free to correct me.

Thanks for the patch, David!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.