From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 19:55:15 2024 Received: (at submit) by debbugs.gnu.org; 26 Jan 2024 00:55:15 +0000 Received: from localhost ([127.0.0.1]:49674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTAV0-00022g-Jv for submit@debbugs.gnu.org; Thu, 25 Jan 2024 19:55:15 -0500 Received: from lists.gnu.org ([2001:470:142::17]:40856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTAUy-00022N-Bv for submit@debbugs.gnu.org; Thu, 25 Jan 2024 19:55:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTAUm-0003X7-Od for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 19:55:00 -0500 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTAUk-0004G1-SK for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 19:55:00 -0500 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a28fb463a28so726961266b.3 for ; Thu, 25 Jan 2024 16:54:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706230496; x=1706835296; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=MC03jxoAMNZQrauIPTWhxcmey8WIYw/pnVwLY2koUEM=; b=A3HMWiqKv6RR4sUCoAbIonT51P1uqbvGWwnOgeFPs/7h2qgcBg9zFapLm1oJsN9xFH uCzvFGnwSkmgtIlKYPiqf362N3mvfCD2mQVptDZ4QnVhEGyIYxS/Wr8Ov0Ow2Rf/8W8m Vr1piURezI4vXmv7TP1vejlYa5wxjUsgAdMlPxqB2bhhQZU0PFHRBpTrM6Lw+dH6nzgu pm9g9R4DLRzAmwLe/L5hTEMWrXkF206Ea9gzTFVm7oe83FrELuf4hIfrUuT4cJVYtdKD XVCAWn5EmE7xH+OUYvKkqXD2hLukYQevNpLgH65LFE1ORFc4PmLX0K+X5oyLsQeub1eg hSmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706230496; x=1706835296; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MC03jxoAMNZQrauIPTWhxcmey8WIYw/pnVwLY2koUEM=; b=pyMtIzPpY0dVOFMDGomioFPQh8I1Gd/BO57OjZ21O7peHEFXsmjoeTx7AtClpvFt2y vqUAwVbjFfhEa9rfa0gnCc6uhWukVndon2nWuwSeVwjqL8/NQ1tWePlpdN7SJZOsQfl6 RqxecdI4bCG2Jt/LWPoyv+JO9/z22rPh97GtTgVfiQor3eTulRvReRfA7TOKM1QqJ9An NQdVG8E7dunT1OlPF+uk6M3FWX9A3cSklMSu+hRO3cN22PO9bExnUDkX4Q9+ePbVJ1Da qoXNJyab9QWuOxkDhgScycDedu7MRFVCsHSdV00CV5Iux2/4w4MmYHlTnk7kXI9Qf4Hv 0veQ== X-Gm-Message-State: AOJu0YxsCeBj2owZKa47N2WuzA53cUFoDzYjfgCsEPJW7RTjFfnEMwcc 9XFjT/TgHNQY8vTvJVOGhW1ruRZV1e8aIK07dpms/oN+CZVJAS1DZi1uuJbAzhAVSbrDXGDM7iy rIdyi8pzSBKWDnayy/b5lGU0qJZuw6wxp+Qw= X-Google-Smtp-Source: AGHT+IErMLkrIXZRO6rUmxjXXc0f7naWS8hSlW5jdlA14g12T8BhyuLE819v7k4lxRHQ08x2LJ/nEzkpBBEJYPyPlcQ= X-Received: by 2002:a17:906:35c9:b0:a31:35c2:9301 with SMTP id p9-20020a17090635c900b00a3135c29301mr177910ejb.133.1706230496376; Thu, 25 Jan 2024 16:54:56 -0800 (PST) MIME-Version: 1.0 From: Patrick Poitras Date: Thu, 25 Jan 2024 16:54:45 -0800 Message-ID: Subject: eshell/make doesn't properly handle color term characters To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000a43c91060fcebecc" Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=patrick.f.poitras@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000a43c91060fcebecc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable In eshell, if I am in a directory and call `make`, the call that is executed is (eshell/make) from em-unix.el. The *compilation* window then pops up, which reads: ------- make g++ main.cpp -o main -lsfml-graphics -lsfml-window -lsfml-system [01m [Kmain.cpp: [m [K In function =E2=80=98 [01m [Kint [01;32m [K main [m = [K() [m [K=E2=80=99: [01m [Kmain.cpp:41:21: [m [K [01;31m [Kerror: [m [Ktoo few arguments to function =E2=80=98 [01m [Kvoid [01;32m [K handleCamera [m [K(sf::View&, con= st sf::Time&) [m [K=E2=80=99 41 | [01;31m [KhandleCamera(view) [m [K; | [01;31m [K~~~~~~~~~~~~^~~~~~ [m [K [01m [Kmain.cpp:7:6: [m [K [01;36m [Knote: [m [Kdeclared here 7 | void [01;36m [KhandleCamera [m [K(sf::View &view, const sf::Time &time) { | [01;36m [K^~~~~~~~~~~~ [m [K make: *** [Makefile:2: game] Error 1 Compilation exited abnormally with code 2 at Thu Jan 25 16:47:18, duration 0.28 s ------ Note that the garbled text above is not a problem with me copy-pasting it . The screen I see really writes out these `[01;31m` characters all over, making the message comprehensible. I thought this might be a locale issue, so I called make like this: ------ ~/Projects/SFML $ LC_LANG=3Den_US.utf8 make ------- Which doesn't pop-up the *compilations* buffer, but does print the correct output: -------- g++ main.cpp -o main -lsfml-graphics -lsfml-window -lsfml-system main.cpp: In function =E2=80=98int main()=E2=80=99: main.cpp:41:21: error: too few arguments to function =E2=80=98void handleCamera(sf::View&, const sf::Time&)=E2=80=99 41 | handleCamera(view); | ~~~~~~~~~~~~^~~~~~ main.cpp:7:6: note: declared here 7 | void handleCamera(sf::View &view, const sf::Time &time) { | ^~~~~~~~~~~~ make: *** [Makefile:2: game] Error 1 ------ Which is properly colored and everything. I also figured out that the LC_LANG isn't special it's just bypassing the call to the native function, in fact, you get the same result if you call ------- ASDASDFASD=3DASDFASDF make ------- Is this a known behavior with a workaround, or how do I troubleshoot this further. Thanks, Patrick --000000000000a43c91060fcebecc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
In eshell, if I am in a directory and call `make`, th= e call that is executed is (eshell/make) from em-unix.el.

The= *compilation* window then pops up, which reads:
-------
ma= ke
g++ main.cpp -o main -lsfml-graphics -lsfml-window -lsfml-system
= [01m [Kmain.cpp: [m [K In function =E2=80=98 [01m [Kint [01;32m [K main [m = [K() [m [K=E2=80=99:
[01m [Kmain.cpp:41:21: [m [K [01;31m [Kerror: [m= [Ktoo few arguments to function =E2=80=98 [01m [Kvoid [01;32m [K handleCam= era [m [K(sf::View&, const sf::Time&) [m [K=E2=80=99
=C2=A0 =C2= =A041 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 [01;31m [KhandleCamera(view) [m [K;=C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 [01;31m [K~~~~~~~~~~~~= ^~~~~~ [m [K
[01m [Kmain.cpp:7:6: [m [K [01;36m [Knote: [m [Kdeclared= here
=C2=A0 =C2=A0 7 | void [01;36m [KhandleCamera [m [K(sf::View &= ;view, const sf::Time &time) {
=C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 = =C2=A0 [01;36m [K^~~~~~~~~~~~ [m [K
make: *** [Makefile:2: game] Error 1=

Compilation exited abnormally with code 2 at Thu Jan 25 16:47:18, d= uration 0.28 s
------

Note that the garbled tex= t above is not a problem with me copy-pasting it . The screen I see really = writes out these `[01;31m` characters all over, making the message comprehe= nsible.

I thought this might be a locale issue, so I call= ed make like this:
------
~/Projects/SFML $ LC_LANG=3Den_US.utf8 make=
-------
Which doesn't pop-up the *compilations* bu= ffer, but does print the correct output:
--------
g++ main= .cpp -o main -lsfml-graphics -lsfml-window -lsfml-system
main.cpp: In fu= nction =E2=80=98int main()=E2=80=99:
main.cpp:41:21: error: too few argu= ments to function =E2=80=98void handleCamera(sf::View&, const sf::Time&= amp;)=E2=80=99
=C2=A0 =C2=A041 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 handleCamer= a(view);
=C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 ~~~~~~~~~~~~= ^~~~~~
main.cpp:7:6: note: declared here
=C2=A0 =C2=A0 7 | void handl= eCamera(sf::View &view, const sf::Time &time) {
=C2=A0 =C2=A0 = =C2=A0 | =C2=A0 =C2=A0 =C2=A0^~~~~~~~~~~~
make: *** [Makefile:2: game] E= rror 1
------
Which is properly colored and everything.

I also figured out that the LC_LANG isn't speci= al it's just bypassing the call to the native function, in fact, you ge= t the same result if you call
-------
ASDASDFASD=3DASDFASDF ma= ke
-------

Is this a known behavior with= a workaround, or how do I troubleshoot this further.

Thanks,
Patrick
--000000000000a43c91060fcebecc-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 20:18:40 2024 Received: (at 68724-done) by debbugs.gnu.org; 26 Jan 2024 01:18:41 +0000 Received: from localhost ([127.0.0.1]:49712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTArg-0002g9-Lf for submit@debbugs.gnu.org; Thu, 25 Jan 2024 20:18:40 -0500 Received: from mail-oi1-x22f.google.com ([2607:f8b0:4864:20::22f]:52270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTArd-0002fq-VQ for 68724-done@debbugs.gnu.org; Thu, 25 Jan 2024 20:18:38 -0500 Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-3bd884146e9so133218b6e.0 for <68724-done@debbugs.gnu.org>; Thu, 25 Jan 2024 17:18:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706231906; x=1706836706; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=jDTwSmDtdN2dmDb3Pvj3adW0dzLhyFWAEhxBkNUb0kM=; b=jyc+6HYxqOzmUK1KUO3NzSRgaIPHo8UBuZetDcgZFD1YodxiAtlMJmINEo0+kaGxBA PJKlqpqkazW3y1rAE9I8DRUxWh5eIkp4V7EvaX/jPT0cdsVLqAEztOzAbRYnPD7E8RXm qURvpIZ0rUaHAMTSzuz8BwUK+cl6Z8tNsOjT98NkyhBGm6zVsRnSFLKooFBW0Fb2RXtk DnzQNKQb3EAme4MiyS/M2/7JrNy4NJS9GRgAd8BhjyZo9OB2KnLkUC7TvtfmKmVb4HfF 7d+nXg2bTfLxyoP+7PqJGdgWaXKw7lVXvLTvDc23hfDvXgkFf8gvT/yBMDwf5jJqvxk6 s34Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706231906; x=1706836706; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jDTwSmDtdN2dmDb3Pvj3adW0dzLhyFWAEhxBkNUb0kM=; b=WXgSOi/bgQUjguuxvJf/IY6+lEP+FtfQLlRpp1NAvp2zpUlLAc7TRBUCe4RiSurvSS zbqA0GD3XtwdKsFHhGRTESrwEEVMA7yO2D5jM6w+awjFoArjEhmzdgM6LmMzEU+RWyuZ vtP4GgUv2b1714mGgvfy/y8ZdU+3hUApan6W1o+d9YPU3003fDEt5SnOdYA3QS+/CL/p sp0LO0J4IwR15MWHipxk3C2x1vRT8/LnnxgVrpS+u4jabtq+neGJcDC8DjBb0e4yUKcc 2P4RvTzv5+aM0pXzzIg63Yub/ui3P3kKsz6Gd7XTHNnpt/5/+fWXwpGsYn4r4Nii2EHD aWOg== X-Gm-Message-State: AOJu0YyQ1yEzlDYUJF7vXu8M40pT7/OGGw9h6dlKH/FPOBXFDCTMTlON 87FphNnbxiwsZhOPbyauqCGBTcGGJ6xdrZd8Pk4jd3tWhTxK8P9F X-Google-Smtp-Source: AGHT+IF6lD4/WFhXANf2bQ7raY6XDdiLN3IsVMlxxMdDbXZF5VN7lkQxXPcVM4tHOIaKFGAUIBY6TQ== X-Received: by 2002:a05:6808:e87:b0:3bd:9b86:8a34 with SMTP id k7-20020a0568080e8700b003bd9b868a34mr617351oil.57.1706231904891; Thu, 25 Jan 2024 17:18:24 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b6-20020a62cf06000000b006dbdb5946d7sm163389pfg.6.2024.01.25.17.18.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 17:18:24 -0800 (PST) Message-ID: Date: Thu, 25 Jan 2024 17:18:23 -0800 MIME-Version: 1.0 Subject: Re: bug#68724: eshell/make doesn't properly handle color term characters Content-Language: en-US To: Patrick Poitras , 68724-done@debbugs.gnu.org References: From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68724-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/25/2024 4:54 PM, Patrick Poitras wrote: > In eshell, if I am in a directory and call `make`, the call that is > executed is (eshell/make) from em-unix.el. > > The *compilation* window then pops up, which reads: ... Thanks for the bug report. I'm guessing you're using Emacs 30.0.50. This is a bug, in that eshell/make should print its output to the Eshell buffer by default (not a new compilation buffer). That's now fixed in 4834be0949e on master, so closing this issue. However, for fixing the colors in the compilation buffer, you can also add 'ansi-color-compilation-filter' to 'compilation-filter-hook'. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 20:31:33 2024 Received: (at 68724-done) by debbugs.gnu.org; 26 Jan 2024 01:31:33 +0000 Received: from localhost ([127.0.0.1]:49746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTB49-00032j-C6 for submit@debbugs.gnu.org; Thu, 25 Jan 2024 20:31:33 -0500 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:44097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTB47-00032V-9I for 68724-done@debbugs.gnu.org; Thu, 25 Jan 2024 20:31:31 -0500 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a26fa294e56so16509166b.0 for <68724-done@debbugs.gnu.org>; Thu, 25 Jan 2024 17:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706232679; x=1706837479; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KxHuYXAXkzlqnDkIQHqOiS7/omsJHmDOnmGe7oWDrK8=; b=HnCX/1unHLa/ExRba9IJSlpA9d0QsvHdyHyOYMj+mJ2iN+U2v05N6VNKwm5t9mXzy0 GfkSQG955GB7Qm+XlNcKUVt6UMMjwbyPt/VZ1DHI40i9kN5tBFbfM9Ph9cclrhD37CV2 XL0P2sRbKy6+gn2dsNddgWhlHESmf1K0Qa8/pdjSFRCZhe3/WDqqxpCNGwByf5m90tDY bS3jVEQR+RVhIdbIjlBWmxtEcq1QhGNbiStKy7olo/FgiDkyDJTrdW7bu9hoJDQEwt8d KR9iZ1nK4rcoX4u8riyMXNPZF6P/8HifZkq0HEMoj7qlQrn4SjDxsED6HZiEMNMYAzeo lA0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706232679; x=1706837479; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KxHuYXAXkzlqnDkIQHqOiS7/omsJHmDOnmGe7oWDrK8=; b=MTZxdNZuGjo8cqXlnROrDoNu2nJw3RB1eZYMmJiimjuGsXxmKRCsIdOT+pl8Waj1Ui R4+SVnTvZRvdWbNCMfn9pkdcRGO4LVFWz4EJX1VRqTpyNUtDVo4iDUQVAzeJvFYAbRHH rqTiHgbfRZwZQ80+9U8X+dBd3BzYkDcGXRoutZyt9UIZjjo9V5FBzqihu0UXeskcU7Qk icZBKVZvkXUfRp1TF9rm0umpJ3BPXaCauiDKYDCop3nhl76NmABPg8BZuKkZwybfVvz5 rjTdXBmwqQpuMO3ihttH3w5M0jDKVdzmF1DBZJKZcj2wGmtyDDaMWl4kCa6QcWj4tgrD 15RQ== X-Gm-Message-State: AOJu0YxdyR0DSYKQBBhQni9Sjk82OSPq0kxtj95jdJiqy+1VH2gHnLyk TW8CYKxPilNSClkaRzgS1nGS4nvthnneiDEgV3pb+oDahEsqj9vkB7898puxu01AI4DrXrQG9pU chqylekIpWhNJ1DZiOV47NeKcbFg= X-Google-Smtp-Source: AGHT+IHLmYuI09ruGWlCGRhosLd8OxqlqDIgMy+db1PkIrsZ2riFShd+B8vj6a3ryFTz6uUtWz9CN00do4Xia+jEOdo= X-Received: by 2002:a17:906:ac5:b0:a31:7a26:5a7c with SMTP id z5-20020a1709060ac500b00a317a265a7cmr218178ejf.66.1706232679032; Thu, 25 Jan 2024 17:31:19 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Patrick Poitras Date: Thu, 25 Jan 2024 17:31:07 -0800 Message-ID: Subject: Re: bug#68724: eshell/make doesn't properly handle color term characters To: Jim Porter Content-Type: multipart/alternative; boundary="000000000000bcec22060fcf4049" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68724-done Cc: 68724-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000bcec22060fcf4049 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This is what happens when I file bug reports while sick. Forgot a bunch of details. My apologies. Yeah, bug reported from emacs 30.0.50 @ 4e260bfc47e on master. Can confirm that it's now fix on latest master. Thanks! On Thu, Jan 25, 2024 at 5:18=E2=80=AFPM Jim Porter = wrote: > On 1/25/2024 4:54 PM, Patrick Poitras wrote: > > In eshell, if I am in a directory and call `make`, the call that is > > executed is (eshell/make) from em-unix.el. > > > > The *compilation* window then pops up, which reads: ... > > Thanks for the bug report. I'm guessing you're using Emacs 30.0.50. This > is a bug, in that eshell/make should print its output to the Eshell > buffer by default (not a new compilation buffer). That's now fixed in > 4834be0949e on master, so closing this issue. > > However, for fixing the colors in the compilation buffer, you can also > add 'ansi-color-compilation-filter' to 'compilation-filter-hook'. > --000000000000bcec22060fcf4049 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This is what happens when I file bug reports while si= ck. Forgot a bunch of details. My apologies.

Y= eah, bug reported from emacs 30.0.50 @ 4e260bfc47e on master. Can confirm t= hat it's now fix on latest master.=C2=A0

Thank= s!

On Thu, Jan 25, 2024 at 5:18=E2=80=AFPM Jim Porter <jporterbugs@gmail.com> wrote:
<= /div>
On 1/25/2024 4:54 PM= , Patrick Poitras wrote:
> In eshell, if I am in a directory and call `make`, the call that is > executed is (eshell/make) from em-unix.el.
>
> The *compilation* window then pops up, which reads: ...

Thanks for the bug report. I'm guessing you're using Emacs 30.0.50.= This
is a bug, in that eshell/make should print its output to the Eshell
buffer by default (not a new compilation buffer). That's now fixed in <= br> 4834be0949e on master, so closing this issue.

However, for fixing the colors in the compilation buffer, you can also
add 'ansi-color-compilation-filter' to 'compilation-filter-hook= '.
--000000000000bcec22060fcf4049-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 20:59:42 2024 Received: (at 68724) by debbugs.gnu.org; 26 Jan 2024 01:59:42 +0000 Received: from localhost ([127.0.0.1]:49755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTBVN-0003rY-L5 for submit@debbugs.gnu.org; Thu, 25 Jan 2024 20:59:41 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:48408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTBVM-0003rL-5l for 68724@debbugs.gnu.org; Thu, 25 Jan 2024 20:59:40 -0500 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1d711d7a940so65441265ad.1 for <68724@debbugs.gnu.org>; Thu, 25 Jan 2024 17:59:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706234368; x=1706839168; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=VDdSsNL/RENCeBk2wYsT+EdbE3QTlaskzdHOz0FgTXk=; b=VkKaIeCG9Hf3noKVLH82nDxkJdjK9lZEYsqwONMU/az3mmjnbge5WQQYOl+H+nQ4jh X1mfG5yMLCvZykIhXSW5qRIJuOozL+VtzKxzk/3mLEQUuxgKmM+198HVopalWzO5ndZ9 HhkkDstQhFvZR7uhT3B/xO2flwge+8Ja938cGm+i/hKIVh8ahZGug0K/exk+vaG6Pz8y bVmIGGGAWhFD94FmmmLc2AHmviCG+kkvdaW82PvAVFWCJdi3j7h30+7pDaarPWjjghhM uLPB9Wlnluo448fR3p7xQCJe2lmHPmY3CJl7nYlhNqHyViu+ZwD4b11zaBSxHZokekZ6 DR3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706234368; x=1706839168; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VDdSsNL/RENCeBk2wYsT+EdbE3QTlaskzdHOz0FgTXk=; b=L5W4xphuA14yqNh7WiyREkXwT5CadhQ1Z4NfQCw2v0VBCjtC6BioOfuWmJFoqmAppF 0/EgKestrw7DGpOK4I0Q+RGL5C9fEB9yLGcpElIINSBPWagdMtOoVfQumQ7sAt5p0ohB nn/ixIEN9ZDzntDEsqlEy8G5np2gnoeCmF81qxhgTXuTmcwBO/J4by7I5XC+m58cL8fk Pyj4+n3kvQ+GZXvdLwI6RUOZc7GEs7DjLu7UCKAjDsU5NqKlgdJI5oiVF2cFs+BziUbN W+Qs5JAN8XqW4Y9SJ3fOjxGr769PFIQG6JmMn2auPU4+BNHU+iH4cdG8xOwnMkI4m7TB MNAw== X-Gm-Message-State: AOJu0Yy8Tdmlv31erL8QyDgIlNcS1tDeYcrk0RhdT+a4icHndUoqfzfs wImyeshfb1LwqQwzx5tQe7zxdzNBjD4c+fEQV6aS6pV9n8ZrbFki X-Google-Smtp-Source: AGHT+IGI+0ANki2pHYsiFZ2aY0ZyCwUun2RjvZqU9QKn5Q93D3hnWJTLefAZe8XH41EshCx0HxasFQ== X-Received: by 2002:a17:902:ef8a:b0:1d5:a1c3:3702 with SMTP id iz10-20020a170902ef8a00b001d5a1c33702mr522077plb.49.1706234367963; Thu, 25 Jan 2024 17:59:27 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id y4-20020a170902ed4400b001d705836d0dsm140393plb.200.2024.01.25.17.59.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 17:59:27 -0800 (PST) Message-ID: <30e823df-4eea-2b72-4320-68aaf03e9714@gmail.com> Date: Thu, 25 Jan 2024 17:59:27 -0800 MIME-Version: 1.0 Subject: Re: bug#68724: eshell/make doesn't properly handle color term characters Content-Language: en-US To: Patrick Poitras References: From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68724 Cc: 68724@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/25/2024 5:31 PM, Patrick Poitras wrote: > This is what happens when I file bug reports while sick. Forgot a bunch > of details. My apologies. No worries! The second part of your message (about "VAR=value make" being a workaround) also made me look again at how Eshell handles local variable settings like that, which let me fix a longstanding bug in the code: "VAR=value cd dir/" didn't actually change the directory. That's now fixed as well on master. > Yeah, bug reported from emacs 30.0.50 @ 4e260bfc47e on master. Can > confirm that it's now fix on latest master. Thanks for confirming the fix. From unknown Thu Jun 19 14:29:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 23 Feb 2024 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator