GNU bug report logs - #68720
[PATCH] gnu: openmolar-1: Update to release 1.1.6-g81838c8 and partial runtime fix.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68720 in the body.
You can then email your comments to 68720 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: rimarko <at> libero.it
To: guix-patches <at> gnu.org
Cc: Marco Rimoldi <rimarko <at> libero.it>
Subject: [PATCH] gnu: openmolar-1: Update to release 1.1.6-g81838c8 and
 partial runtime fix.
Date: Thu, 25 Jan 2024 22:31:08 +0100

From: Marco Rimoldi <rimarko <at> libero.it>

WebKit was removed from Qt5 in favor of WebEngine; upstream addressed this in their last stable release, in 2018.  The package still fails at runtime: this commit lays the ground for further fixes.

* gnu/packages/medical.scm (openmolar-1): Update to release 1.1.6-g81838c8.
[arguments]: Extend 'patch-/usr phase to source file localsettings.py.
[inputs]: Add python-pyqtwebengine.
[propagated-inputs]: Add qtwebengine-5.

Change-Id: Ia4e4c052397201c26834dec2358ca5c20beb581d
---
 gnu/packages/medical.scm | 54 +++++++++++++++++++++-------------------
 1 file changed, 28 insertions(+), 26 deletions(-)

diff --git a/gnu/packages/medical.scm b/gnu/packages/medical.scm
index 33877083e2..15bd870f83 100644
--- a/gnu/packages/medical.scm
+++ b/gnu/packages/medical.scm
@@ -83,32 +83,34 @@ (define-public mygnuhealth
 
 (define-public openmolar-1
   (package
-   (name "openmolar")
-   (version "1.0.15-gd81f9e5")
-   (source (origin
-             (method url-fetch)
-             (uri (string-append
-                   "https://static.openmolar.com/om1/releases/openmolar-"
-                   version ".tar.gz"))
-             (sha256
-              (base32
-               "1cfdzfbi6wslw7k0dc6ad6xrgs75iwsl91cg73w4myswaqqkfk3z"))))
-   (build-system python-build-system)
-   (arguments
-    `(#:use-setuptools? #f
-      #:phases
-      (modify-phases %standard-phases
-        (add-after 'unpack 'patch-/usr
-          (lambda* (#:key outputs #:allow-other-keys)
-            (substitute* "setup.py"
-              (("/usr") (assoc-ref outputs "out")))
-            #t)))))
-   (inputs
-    (list python-pyqt+qscintilla python-mysqlclient qscintilla))
-   (home-page "https://openmolar.com/om1")
-   (synopsis "Dental practice management software")
-   (description "Openmolar is a dental practice management suite.  Its
+    (name "openmolar")
+    (version "1.1.6-g81838c85")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://static.openmolar.com/om1/releases/openmolar-" version
+             ".tar.gz"))
+       (sha256
+        (base32 "09vrfqn511vswnj2q9m7srlwdgz066qvqpmja6sg1yl1ibh3cbpr"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:use-setuptools? #f
+       #:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'patch-/usr
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (substitute* '("setup.py"
+                                     "src/openmolar/settings/localsettings.py")
+                        (("/usr")
+                         (assoc-ref outputs "out"))) #t)))))
+    (inputs (list python-pyqtwebengine python-pyqt+qscintilla
+                  python-mysqlclient qscintilla))
+    (propagated-inputs (list qtwebengine-5))
+    (home-page "https://openmolar.com/om1")
+    (synopsis "Dental practice management software")
+    (description
+     "Openmolar is a dental practice management suite.  Its
 functionality includes appointments, patient records, treatment planning,
 billing etc.  It is a full featured, reliable and thoroughly tested
 application and has been translated into many languages.")
-   (license gpl3+)))
+    (license gpl3+)))

base-commit: d6c394d6a177fdaf6b28f82a9dd2163633e5eeee
-- 
2.41.0

Message #8 received at 68720 <at> debbugs.gnu.org (full text, mbox):

From: Marco Rimoldi <rimarko <at> libero.it>
To: 68720 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: openmolar-1: Update to release 1.1.6-g81838c8 and
 partial runtime fix.
Date: Thu, 25 Jan 2024 22:43:40 +0100

This commit fixes https://issues.guix.gnu.org/29365.

The package now fails to start with this error message:

File "/gnu/store/zzys4bqllx3a3gramwj2pyyigfb4z75b-openmolar-1.1.6-g81838c85/lib/python3.10/site-packages/openmolar/qt4gui/customwidgets/toothProps.py", line 827, in shapes
    self.mesial.setPoints(
TypeError: 'float' object cannot be interpreted as an integer

I will submit a new issue if the patch is accepted.

Marco

Message #13 received at 68720-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Marco Rimoldi <rimarko <at> libero.it>
Cc: 68720-done <at> debbugs.gnu.org, 29365-done <at> debbugs.gnu.org
Subject: Re: [bug#68720] [PATCH] gnu: openmolar-1: Update to release
 1.1.6-g81838c8 and partial runtime fix.
Date: Sat, 10 Feb 2024 22:56:03 +0100

Hi,

Marco Rimoldi <rimarko <at> libero.it> skribis:

> This commit fixes https://issues.guix.gnu.org/29365.

Alright, applied!

> The package now fails to start with this error message:
>
> File "/gnu/store/zzys4bqllx3a3gramwj2pyyigfb4z75b-openmolar-1.1.6-g81838c85/lib/python3.10/site-packages/openmolar/qt4gui/customwidgets/toothProps.py", line 827, in shapes
>     self.mesial.setPoints(
> TypeError: 'float' object cannot be interpreted as an integer
>
> I will submit a new issue if the patch is accepted.

That’d be great.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.