GNU bug report logs - #68718
[PATCH] gnu: elfutils: Move inputs to propagated-inputs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68718 in the body.
You can then email your comments to 68718 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Olivier Dion <olivier.dion <at> polymtl.ca>
To: guix-patches <at> gnu.org
Cc: Olivier Dion <olivier.dion <at> polymtl.ca>
Subject: [PATCH] gnu: elfutils: Move inputs to propagated-inputs.
Date: Thu, 25 Jan 2024 15:00:50 -0500

zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the xz
and zlib packages must be propagated for pkg-config to work on libdw and
libelf.

* gnu/packages/elf.scm (elfutils): Move packages ...
[inputs]: ... from here ...
[propagated-inputs]: ... to here.

Change-Id: Ic89d226b2392fe821b207302d3b386f9633b981a
---
 gnu/packages/elf.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm
index a100038f14..b760f1b339 100644
--- a/gnu/packages/elf.scm
+++ b/gnu/packages/elf.scm
@@ -138,7 +138,7 @@ (define-public elfutils
              '()))))
 
     (native-inputs (list m4))
-    (inputs (list xz zlib))
+    (propagated-inputs (list xz zlib))
     (home-page "https://sourceware.org/elfutils/")
     (synopsis "Collection of utilities and libraries to handle ELF files and
 DWARF data")

base-commit: ed7eb108e5ba38135db99aa3b162f88797c372f9
-- 
2.41.0

Message #8 received at 68718 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Olivier Dion <olivier.dion <at> polymtl.ca>
Cc: 68718 <at> debbugs.gnu.org
Subject: Re: [bug#68718] [PATCH] gnu: elfutils: Move inputs to
 propagated-inputs.
Date: Thu, 30 May 2024 09:47:12 -0400

Hi,

Olivier Dion <olivier.dion <at> polymtl.ca> writes:

> zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
> Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the xz
> and zlib packages must be propagated for pkg-config to work on libdw and
> libelf.

Could you please mention the above in a comment above the
propagated-inputs field (in code)?

-- 
Thanks,
Maxim

Message #13 received at 68718 <at> debbugs.gnu.org (full text, mbox):

From: odion <at> efficios.com
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Olivier Dion <olivier.dion <at> polymtl.ca>
Cc: 68718 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: elfutils: Move inputs to propagated-inputs.
Date: Thu, 30 May 2024 12:09:13 -0400

From: Olivier Dion <olivier.dion <at> polymtl.ca>

zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the xz
and zlib packages must be propagated for pkg-config to work on libdw and
libelf.

* gnu/packages/elf.scm (elfutils): Move packages ...
[inputs]: ... from here ...
[propagated-inputs]: ... to here.

Change-Id: Ic89d226b2392fe821b207302d3b386f9633b981a
---
 gnu/packages/elf.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm
index a100038f14..484f8dfc2c 100644
--- a/gnu/packages/elf.scm
+++ b/gnu/packages/elf.scm
@@ -138,7 +138,11 @@ (define-public elfutils
              '()))))
 
     (native-inputs (list m4))
-    (inputs (list xz zlib))
+    ;; zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
+    ;; Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the
+    ;; xz and zlib packages must be propagated for pkg-config to work on libdw
+    ;; and libelf.
+    (propagated-inputs (list xz zlib))
     (home-page "https://sourceware.org/elfutils/")
     (synopsis "Collection of utilities and libraries to handle ELF files and
 DWARF data")

base-commit: c2cb630061d937e26bcbd5ae7962f692f640a4ee
-- 
2.41.0

Message #18 received at 68718-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: odion <at> efficios.com
Cc: Olivier Dion <olivier.dion <at> polymtl.ca>, 68718-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: elfutils: Move inputs to propagated-inputs.
Date: Thu, 30 May 2024 23:13:53 -0400

Hi,

odion <at> efficios.com writes:

> From: Olivier Dion <olivier.dion <at> polymtl.ca>
>
> zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
> Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the xz
> and zlib packages must be propagated for pkg-config to work on libdw and
> libelf.
>
> * gnu/packages/elf.scm (elfutils): Move packages ...
> [inputs]: ... from here ...
> [propagated-inputs]: ... to here.

I've reworded the GNU ChangeLog part like:

* gnu/packages/elf.scm (elfutils)
[inputs]: Turn into...
[propagated-inputs]: ... this field.

> Change-Id: Ic89d226b2392fe821b207302d3b386f9633b981a
> ---
>  gnu/packages/elf.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/elf.scm b/gnu/packages/elf.scm
> index a100038f14..484f8dfc2c 100644
> --- a/gnu/packages/elf.scm
> +++ b/gnu/packages/elf.scm
> @@ -138,7 +138,11 @@ (define-public elfutils
>               '()))))
>  
>      (native-inputs (list m4))
> -    (inputs (list xz zlib))
> +    ;; zlib and liblzma are required in `lib/pkgconfig/{libdw,libelf}.pc'.
> +    ;; Thus, `lib/pkgconfig/liblzma.pc' and `lib/pkgconfig/zlib.pc' from the
> +    ;; xz and zlib packages must be propagated for pkg-config to work on libdw
> +    ;; and libelf.
> +    (propagated-inputs (list xz zlib))

And simplified this to:

    (propagated-inputs (list xz zlib))  ;in Requires of libdw.pc, libelf.pc

and...

Actually, these are in 'Requires.private', which ought to be only useful
for static compilation (though these would be consulted for Cflags since
there's no Cflags.private in pkg-config).

pkgconf handles this better than pkg-config, letting you do without
propagation here, as long as the libs are found in a standard include
path and you are building a shared library.

I think with the planned switch to pkgconf, we probably should avoid
propagation here unless really necessary; do you have a failing example
at hand?

-- 
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.