From unknown Wed Jun 18 23:09:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#68709 <68709@debbugs.gnu.org> To: bug#68709 <68709@debbugs.gnu.org> Subject: Status: [PATCH] gnu: emacs-citar: Fix autoloads and restore tests Reply-To: bug#68709 <68709@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:09:44 +0000 retitle 68709 [PATCH] gnu: emacs-citar: Fix autoloads and restore tests reassign 68709 guix-patches submitter 68709 Edward Wilson severity 68709 normal tag 68709 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 24 23:34:32 2024 Received: (at submit) by debbugs.gnu.org; 25 Jan 2024 04:34:33 +0000 Received: from localhost ([127.0.0.1]:47024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSrRg-0002BC-Gp for submit@debbugs.gnu.org; Wed, 24 Jan 2024 23:34:32 -0500 Received: from lists.gnu.org ([2001:470:142::17]:50424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSlqe-0003Ub-Jr for submit@debbugs.gnu.org; Wed, 24 Jan 2024 17:35:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSlqT-0001QG-4D for guix-patches@gnu.org; Wed, 24 Jan 2024 17:35:45 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSlqQ-0000aS-TY for guix-patches@gnu.org; Wed, 24 Jan 2024 17:35:44 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3394bec856fso71389f8f.0 for ; Wed, 24 Jan 2024 14:35:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706135739; x=1706740539; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tbfvbRLe2YaUADviJ1rT24lYSrGZDlCxk14nm3qPjNk=; b=LlVMiBuPsvNatj3vDg+lqb5l4UBSCZzjLXQgDioop3etANvT0g+SwomgUrd2POdInz zbJmlC8vk56SrrV2nJ+yGQpOnaDRjJXR2yyQerRvye7Oi/Er5O+UvUjM4y/iUQIhHPPt sn+ehR2eji1hlxfuJ6FEifcMn8O06stEn3x1/LCYFADncUAjzyQRwonIKCQk1t9SETch CsWvHu4dfE6BRSr0jFiOqVMr5O42WX0vkubHMfTxvhppXwXBMqiw7NIQjoxDXdUH+3rF iLGj+tM6zL65j9t4aHEeCVDlfqurFFTxMueHP5hlbE0w+utLFee2AH9RucG4txI1OEF0 9qtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706135739; x=1706740539; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tbfvbRLe2YaUADviJ1rT24lYSrGZDlCxk14nm3qPjNk=; b=oaOgxV7GWqxfNPhvWnTJado3cC+wp7AusftF4+N884CEW4uTYN7Iwnu9wuTwW7jXvU 14sYptw24sbcfwi4hXGbVY3p/Z0m0wmZCAGdrFjrH9XxfFMxrVOYmHHjFOsyMSo2oJqz /ykmlH+JDSvm4KjAQTnV7ezbUrfOvu3ybbYeyGm655h2SO2DyqBYGAyuFlyVRIFgiOF7 MM/sK+QqbBLX4TFoo+o14V+hVt8Xo4tgjRXKyeq3OpKF8a/M5pn1yf+Z0y6NQN08EAVJ 1eFfMm18Wr7KV+zzafom5+aeE0zAKgKPeJzFybs7BEVjqJPWm07kSxE4qu1PX5jhw9vB pCXQ== X-Gm-Message-State: AOJu0Yx0Uy7fGexeIrVo8VOnyMHCxd0HS4EGyEAQpv/Aql1NQAEd86El 6Jb+VkIfz6kLo34tiA/lhu92e5riYLxAZLbWKOe9fpguNjuNrTj9a6JCnFUof5Tnyw== X-Google-Smtp-Source: AGHT+IFE60McRJqcS9ly7pbDDdKDU1TfMmlCCRqm2fIrL2s3HWQxMNyrNDlzMMBirdLUMeL5nIfTJg== X-Received: by 2002:a5d:63c7:0:b0:336:7a5c:ffc3 with SMTP id c7-20020a5d63c7000000b003367a5cffc3mr109783wrw.14.1706135739192; Wed, 24 Jan 2024 14:35:39 -0800 (PST) Received: from localhost ([2a02:c7c:3692:7f00:524f:3302:d96e:ba4e]) by smtp.gmail.com with ESMTPSA id s16-20020a5d5110000000b0033763a9ea2dsm10489193wrt.63.2024.01.24.14.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 14:35:38 -0800 (PST) From: Edward Wilson To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-citar: Fix autoloads and restore tests Date: Wed, 24 Jan 2024 22:34:40 +0000 Message-ID: <10f970b791c6281a24e643714c0415fcab656246.1706135680.git.bienjensu@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Andrew Tropin , Katherine Cox-Buday , Liliana Marie Prikler Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=bienjensu@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 24 Jan 2024 23:34:29 -0500 Cc: Edward Wilson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) The default build-system emacs doesn't properly expand cl-lib macros when compiling autoloads. This patch changes the `#:emacs` build argument, fixing a present bug (reproducible by requiring citar-autoloads in a minimal environment). This change also allows the validation of compiled autoloads to succeed, hence the test phase is restored. * gnu/packages/emacs-xyz.scm (emacs-citar): Change build-system emacs and restore tests Change-Id: Id56de922e5220383f8c5015a01e39b4aa2ea8cfb --- gnu/packages/emacs-xyz.scm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index ad8c72e97d..b8c97d1767 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -23633,6 +23633,7 @@ (define-public emacs-citar (build-system emacs-build-system) (arguments (list + #:emacs emacs-no-x #:tests? #true #:test-command #~(list "emacs" "--batch" "-L" "." "-l" "test/citar-test.el" @@ -23642,10 +23643,7 @@ (define-public emacs-citar #:phases #~(modify-phases %standard-phases (add-before 'build 'set-home (lambda _ - (setenv "HOME" "/tmp"))) - ;; XXX: The following phase reports bogus errors. Suppress - ;; it for now. - (delete 'validate-compiled-autoloads)))) + (setenv "HOME" "/tmp")))))) (propagated-inputs (list emacs-auctex emacs-citeproc-el emacs-embark base-commit: ffc5fefce370f5fc01091869e13fdf525be1e0c0 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 26 11:49:35 2024 Received: (at 68709-done) by debbugs.gnu.org; 26 Jan 2024 16:49:35 +0000 Received: from localhost ([127.0.0.1]:52572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTPOZ-0003Rf-9K for submit@debbugs.gnu.org; Fri, 26 Jan 2024 11:49:35 -0500 Received: from out-170.mta0.migadu.com ([2001:41d0:1004:224b::aa]:14946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTPOW-0003RQ-H9 for 68709-done@debbugs.gnu.org; Fri, 26 Jan 2024 11:49:34 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=key1; t=1706287759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3yuctsytgZyHnGwt7qptW41UZJPV36vJQ1kxeyJByvE=; b=n/P5WPOxoJuFePkIvW6/2U3yDFpzHl4kuhSnW3ZaABOk+vs4Qn5cNpdqXHrlouR+fBoUK2 iu9ibp0Km/EaYhfw6e4NVlYqqLATSMKNRj+8qkflgnZJzd4PFkJicKUuY7mP71N9DWi8OJ m8x8ilbcmRI5afOUWKwD6zbHs3pPUFnyZC86aXFwUZ8Nk1BOxEvv0n+OiEL9Bo1Tbs8Apa p8IfXmi/U/S6GtcrnJc8ws7oNhWe9vonLMRFPXNBJD/8l6lbCsCs1Lg4IJ8B3yerm7ojSK NMMU6kF9eU6RuawlNuExxQcvJ/N2MM6xYeCqx1uLLBZgqB51rKz5ZleGiEX9zA== From: Andrew Tropin To: Edward Wilson , 68709-done@debbugs.gnu.org Subject: Re: [bug#68709] [PATCH] gnu: emacs-citar: Fix autoloads and restore tests In-Reply-To: <10f970b791c6281a24e643714c0415fcab656246.1706135680.git.bienjensu@gmail.com> References: <10f970b791c6281a24e643714c0415fcab656246.1706135680.git.bienjensu@gmail.com> Date: Fri, 26 Jan 2024 19:49:12 +0300 Message-ID: <87plxoca5z.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68709-done Cc: Katherine Cox-Buday , Edward Wilson , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2024-01-24 22:34, Edward Wilson wrote: > The default build-system emacs doesn't properly expand cl-lib macros when > compiling autoloads. This patch changes the `#:emacs` build argument, fix= ing a > present bug (reproducible by requiring citar-autoloads in a minimal > environment). This change also allows the validation of compiled autoload= s to > succeed, hence the test phase is restored. > > * gnu/packages/emacs-xyz.scm (emacs-citar): Change build-system emacs and > restore tests > > Change-Id: Id56de922e5220383f8c5015a01e39b4aa2ea8cfb > --- > gnu/packages/emacs-xyz.scm | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index ad8c72e97d..b8c97d1767 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -23633,6 +23633,7 @@ (define-public emacs-citar > (build-system emacs-build-system) > (arguments > (list > + #:emacs emacs-no-x > #:tests? #true > #:test-command #~(list "emacs" "--batch" "-L" "." > "-l" "test/citar-test.el" > @@ -23642,10 +23643,7 @@ (define-public emacs-citar > #:phases #~(modify-phases %standard-phases > (add-before 'build 'set-home > (lambda _ > - (setenv "HOME" "/tmp"))) > - ;; XXX: The following phase reports bogus errors. Sup= press > - ;; it for now. > - (delete 'validate-compiled-autoloads)))) > + (setenv "HOME" "/tmp")))))) > (propagated-inputs (list emacs-auctex > emacs-citeproc-el > emacs-embark > > base-commit: ffc5fefce370f5fc01091869e13fdf525be1e0c0 Hi Edward! Thank you very much for the fix, added a trailing dot to commit message and pushed as https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D8ae8b9804f =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmWz4ogACgkQIgjSCVjB 3rCPrg/+MTt1x2bFRyX22pINIICKXQfJdF2W+u7ObiOuZVGkelCZulafNVFd3OCP v3l872DvJgA9YXi81Y+kq6sh4WTJyzWHpMT7F0dx9uvEO5ynnt8FGz47XSZ9K2bS VJYW34Vtuw32u8XGcgMEcxhVI7AiIeo7c0yXz/QNFs/fNtGpaAJ1q7VEoFJDahr0 3LWbGpa8J1rMqvhOl/C7Lb2Ujx24CbgmZdtv5WUeW/A5LX9QIjCuinsqeAlY2+Dn MBa2Q3x2b4r2udotW+GR4Vzag4ItSs5gSKVJdB7DmeFq4nx2CJOyA/hfqXna2Q8O HvgIOUO6tfDn68e2BVU97YdK2OuEkvf61qzlutVC/fVX5GEzK5VcY24+ZDiVTOB1 clcUxkj/k+uJdpFzCpTvoaKSIb6DV4E5sGe1wh6WCzHi/vqx2GknXkALYMtaim5W d6g+fS8LgLm9DeKOV+SWkut+aO3Nv8tsUvV2ivzAcPY2ROJbNnZ/m/ninWP4w0Yh Br1IXyJyDzGJ+O6Wi9+FZg57IeuO5zYwg+iK0JkKAA7Dwzpe/E0Z40EQ7XTkv02p m/vrxClHHZOtD9LR/wQMcgQBErQvZ4a7vHhuQf4uguL+OQBtA651LkEAwpcxqOVD 0TLoLUm6PlqR9l/bMBMvaYPlCtNI+w973xyxhdrkCX8v2dIfD3k= =aK9N -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 27 07:20:35 2024 Received: (at 68709-done) by debbugs.gnu.org; 27 Jan 2024 12:20:35 +0000 Received: from localhost ([127.0.0.1]:53600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rThfm-00038g-Eo for submit@debbugs.gnu.org; Sat, 27 Jan 2024 07:20:34 -0500 Received: from 9.mo582.mail-out.ovh.net ([87.98.171.146]:58005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rThfi-00038U-Rr for 68709-done@debbugs.gnu.org; Sat, 27 Jan 2024 07:20:33 -0500 Received: from director2.ghost.mail-out.ovh.net (unknown [10.108.2.78]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id 2D77E27588 for <68709-done@debbugs.gnu.org>; Sat, 27 Jan 2024 12:20:22 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-2p4rw (unknown [10.110.113.182]) by director2.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 85A301FD4D; Sat, 27 Jan 2024 12:20:21 +0000 (UTC) Received: from ngraves.fr ([37.59.142.101]) by ghost-submission-6684bf9d7b-2p4rw with ESMTPSA id HnisFgX1tGWUjwAAPUO7qA (envelope-from ); Sat, 27 Jan 2024 12:20:21 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-101G004951ac8aa-1d0b-40d4-9607-cc5e55b9332c, BBC544E0C29A249A2CB0D8435C97D56FC2023E84) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 90.110.172.34 From: Nicolas Graves To: Andrew Tropin , Edward Wilson , 68709-done@debbugs.gnu.org Subject: Re: bug#68709: [PATCH] gnu: emacs-citar: Fix autoloads and restore tests In-Reply-To: <87plxoca5z.fsf@trop.in> References: <10f970b791c6281a24e643714c0415fcab656246.1706135680.git.bienjensu@gmail.com> <87plxoca5z.fsf@trop.in> Date: Sat, 27 Jan 2024 13:20:20 +0100 Message-ID: <874jez9ddn.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Ovh-Tracer-Id: 17655799389640188641 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedrvdelledgfeelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehmtderredttddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepffdtvedtgedvgfdugeefueeuudeuhfegtdelgfdviedvteeuffejteeiheeutdfgnecukfhppeduvdejrddtrddtrddupdeltddruddutddrudejvddrfeegpdefjedrheelrddugedvrddutddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeeikeejtdelqdguohhnvgesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekvddpmhhouggvpehsmhhtphhouhht X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68709-done Cc: Katherine Cox-Buday , Edward Wilson , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Just to let you know, on my side I had written this patch to provide a more general solution, I don't know if setting a particular emacs package is a good solution in the long run. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-emacs-build-system-cl-defstruct-autoloads.patch Content-Transfer-Encoding: quoted-printable >From d8cbd304da0e4a9a073a213002c9876fe3011fe3 Mon Sep 17 00:00:00 2001 From: Nicolas Graves Date: Wed, 15 Nov 2023 08:48:44 +0100 Subject: [PATCH] emacs-build-system: cl-defstruct autoloads. Change-Id: If46b1d44fcc7f93da58de2573e1515a702c4dd52 --- guix/build/emacs-utils.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/guix/build/emacs-utils.scm b/guix/build/emacs-utils.scm index 8e12b5b6d4..b7820d6390 100644 --- a/guix/build/emacs-utils.scm +++ b/guix/build/emacs-utils.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2018, 2020, 2022 Maxim Cournoyer ;;; Copyright =C2=A9 2019 Liliana Marie Prikler ;;; Copyright =C2=A9 2022 Fredrik Salomonsson +;;; Copyright =C2=A9 2023 Nicolas Graves ;;; ;;; This file is part of GNU Guix. ;;; @@ -119,7 +120,14 @@ (define (emacs-generate-autoloads name directory) ((fboundp 'make-directory-autoloads) ;; Emacs 28 (make-directory-autoloads ,directory ,file)) - (t (update-directory-autoloads ,directory)))))) + (t (update-directory-autoloads ,directory))) + (when (file-exists-p ,file) + (with-temp-buffer + (insert-file-contents ,file) + (when (search-forward "(cl-defstruct" nil t) + (beginning-of-line) + (insert "(require 'cl-lib)\n") + (write-region (point-min) (point-max) ,file))))))) (emacs-batch-eval expr #:dynamic? #t))) =20 (define* (emacs-byte-compile-directory dir) --=20 2.41.0 --=-=-= Content-Type: text/plain I'm deleting it from my local guix, feel free to rework on it if useful. Nicolas On 2024-01-26 19:49, Andrew Tropin via Guix-patches via wrote: > On 2024-01-24 22:34, Edward Wilson wrote: > >> The default build-system emacs doesn't properly expand cl-lib macros when >> compiling autoloads. This patch changes the `#:emacs` build argument, fixing a >> present bug (reproducible by requiring citar-autoloads in a minimal >> environment). This change also allows the validation of compiled autoloads to >> succeed, hence the test phase is restored. >> >> * gnu/packages/emacs-xyz.scm (emacs-citar): Change build-system emacs and >> restore tests >> >> Change-Id: Id56de922e5220383f8c5015a01e39b4aa2ea8cfb >> --- >> gnu/packages/emacs-xyz.scm | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >> index ad8c72e97d..b8c97d1767 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -23633,6 +23633,7 @@ (define-public emacs-citar >> (build-system emacs-build-system) >> (arguments >> (list >> + #:emacs emacs-no-x >> #:tests? #true >> #:test-command #~(list "emacs" "--batch" "-L" "." >> "-l" "test/citar-test.el" >> @@ -23642,10 +23643,7 @@ (define-public emacs-citar >> #:phases #~(modify-phases %standard-phases >> (add-before 'build 'set-home >> (lambda _ >> - (setenv "HOME" "/tmp"))) >> - ;; XXX: The following phase reports bogus errors. Suppress >> - ;; it for now. >> - (delete 'validate-compiled-autoloads)))) >> + (setenv "HOME" "/tmp")))))) >> (propagated-inputs (list emacs-auctex >> emacs-citeproc-el >> emacs-embark >> >> base-commit: ffc5fefce370f5fc01091869e13fdf525be1e0c0 > > Hi Edward! > > Thank you very much for the fix, added a trailing dot to commit message > and pushed as > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=8ae8b9804f -- Best regards, Nicolas Graves --=-=-=-- From unknown Wed Jun 18 23:09:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 24 Feb 2024 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator