From unknown Tue Jun 17 20:20:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6870 <6870@debbugs.gnu.org> To: bug#6870 <6870@debbugs.gnu.org> Subject: Status: Make vc-root-diff work in more modes Reply-To: bug#6870 <6870@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:20:23 +0000 retitle 6870 Make vc-root-diff work in more modes reassign 6870 emacs submitter 6870 rogers-emacs@rgrjr.dyndns.org severity 6870 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 21:54:48 2010 Received: (at submit) by debbugs.gnu.org; 17 Aug 2010 01:54:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OlBO3-000890-Ug for submit@debbugs.gnu.org; Mon, 16 Aug 2010 21:54:48 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OlBO2-00088v-4Y for submit@debbugs.gnu.org; Mon, 16 Aug 2010 21:54:46 -0400 Received: from lists.gnu.org ([199.232.76.165]:42119) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OlBP1-00075V-3d for submit@debbugs.gnu.org; Mon, 16 Aug 2010 21:55:47 -0400 Received: from [140.186.70.92] (port=55140 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OlBOy-0004lP-MN for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2010 21:55:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OlBOx-0002nt-5C for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2010 21:55:44 -0400 Received: from rgrjr.com ([216.146.47.5]:44741) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OlBOx-0002nT-2x for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2010 21:55:43 -0400 Received: from rgrjr.dyndns.org (c-66-30-196-77.hsd1.ma.comcast.net [66.30.196.77]) by rgrjr.com (Postfix on CentOS) with ESMTP id 1DDB61601B9 for ; Tue, 17 Aug 2010 01:55:41 +0000 (UTC) Received: (qmail 28243 invoked by uid 89); 17 Aug 2010 01:55:40 -0000 Received: from unknown (HELO rgr.rgrjr.com) (192.168.57.1) by home with SMTP; 17 Aug 2010 01:55:40 -0000 Received: by rgr.rgrjr.com (Postfix, from userid 500) id D199B484F0; Mon, 16 Aug 2010 21:55:39 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19561.60443.364109.899857@rgr.rgrjr.com> Date: Mon, 16 Aug 2010 21:55:39 -0400 From: rogers-emacs@rgrjr.dyndns.org To: bug-gnu-emacs@gnu.org Subject: Make vc-root-diff work in more modes X-Mailer: VM viewmail-600 under 24.0.50.1 (i686-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.8 (-----) It makes sense to me that vc-root-diff uses "(vc-responsible-backend default-directory)" when in a dired-mode buffer. But since vc-root-diff is not at all about the current buffer, why not also make that the default for shell-mode, diff-mode, or any of the other modes for non-version-controlled buffers that may be generated in a working copy? -- Bob Rogers http://www.rgrjr.com/ ------------------------------------------------------------------------ diff --git a/lisp/vc.el b/lisp/vc.el index 1e52a3c..abba202 100644 --- a/lisp/vc.el +++ b/lisp/vc.el @@ -1655,8 +1655,8 @@ saving the buffer." (when buffer-file-name (vc-buffer-sync not-urgent)) (let ((backend (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend) - ((derived-mode-p 'dired-mode) (vc-responsible-backend default-directory)) - (vc-mode (vc-backend buffer-file-name)))) + (vc-mode (vc-backend buffer-file-name)) + (t (vc-responsible-backend default-directory)))) rootdir working-revision) (unless backend (error "Buffer is not version controlled")) From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 11:21:28 2011 Received: (at 6870) by debbugs.gnu.org; 4 Jul 2011 15:21:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qdkxk-0003Ke-6G for submit@debbugs.gnu.org; Mon, 04 Jul 2011 11:21:28 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qdkxh-0003KS-U2 for 6870@debbugs.gnu.org; Mon, 04 Jul 2011 11:21:26 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QdkxW-0005AI-1N; Mon, 04 Jul 2011 17:21:14 +0200 From: Lars Magne Ingebrigtsen To: rogers-emacs@rgrjr.dyndns.org Subject: Re: Make vc-root-diff work in more modes In-Reply-To: <19561.60443.364109.899857@rgr.rgrjr.com> (rogers-emacs@rgrjr.dyndns.org's message of "Mon, 16 Aug 2010 21:55:39 -0400") Date: Mon, 04 Jul 2011 17:18:36 +0200 Message-ID: References: <19561.60443.364109.899857@rgr.rgrjr.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Joanna Newsom's _Have One On Me (2)_: "Go Long" X-Hashcash: 1:23:110704:6870@debbugs.gnu.org::0L+/q8rvjhez7RLy:00000000000000000000000000000000000000000CaOo X-Hashcash: 1:23:110704:rogers-emacs@rgrjr.dyndns.org::1xVWjhwLAXgdKjr6:00000000000000000000000000000000H7zL MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QdkxW-0005AI-1N X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310397674.11033@HPCLCNkrBih87MyaSDbNxQ X-Spam-Status: No X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 6870 Cc: 6870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) rogers-emacs@rgrjr.dyndns.org writes: > It makes sense to me that vc-root-diff uses "(vc-responsible-backend > default-directory)" when in a dired-mode buffer. But since vc-root-diff > is not at all about the current buffer, why not also make that the > default for shell-mode, diff-mode, or any of the other modes for > non-version-controlled buffers that may be generated in a working copy? > > -- Bob Rogers > http://www.rgrjr.com/ > > ------------------------------------------------------------------------ > diff --git a/lisp/vc.el b/lisp/vc.el > index 1e52a3c..abba202 100644 > --- a/lisp/vc.el > +++ b/lisp/vc.el > @@ -1655,8 +1655,8 @@ saving the buffer." > (when buffer-file-name (vc-buffer-sync not-urgent)) > (let ((backend > (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend) > - ((derived-mode-p 'dired-mode) (vc-responsible-backend default-directory)) > - (vc-mode (vc-backend buffer-file-name)))) > + (vc-mode (vc-backend buffer-file-name)) > + (t (vc-responsible-backend default-directory)))) > rootdir working-revision) > (unless backend > (error "Buffer is not version controlled")) This looks very reasonable to me, but I'm not all that familiar with vc.el internals. Does anybody else have any opinions on this? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 14:13:50 2011 Received: (at 6870) by debbugs.gnu.org; 4 Jul 2011 18:13:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdneY-00027r-7T for submit@debbugs.gnu.org; Mon, 04 Jul 2011 14:13:50 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdneW-00027f-Aj for 6870@debbugs.gnu.org; Mon, 04 Jul 2011 14:13:49 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EABMCEk5FxIxr/2dsb2JhbABTp3t4iHrBE4Y2BJ5chCw X-IronPort-AV: E=Sophos;i="4.65,474,1304308800"; d="scan'208";a="120402010" Received: from 69-196-140-107.dsl.teksavvy.com (HELO pastel.home) ([69.196.140.107]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 04 Jul 2011 14:13:42 -0400 Received: by pastel.home (Postfix, from userid 20848) id 556B658DBA; Mon, 4 Jul 2011 14:13:42 -0400 (EDT) From: Stefan Monnier To: Lars Magne Ingebrigtsen Subject: Re: bug#6870: Make vc-root-diff work in more modes Message-ID: References: <19561.60443.364109.899857@rgr.rgrjr.com> Date: Mon, 04 Jul 2011 14:13:42 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Mon, 04 Jul 2011 17:18:36 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 6870 Cc: rogers-emacs@rgrjr.dyndns.org, 6870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) >> (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend) >> - ((derived-mode-p 'dired-mode) (vc-responsible-backend default-directory)) >> - (vc-mode (vc-backend buffer-file-name)))) >> + (vc-mode (vc-backend buffer-file-name)) >> + (t (vc-responsible-backend default-directory)))) >> rootdir working-revision) >> (unless backend >> (error "Buffer is not version controlled")) > This looks very reasonable to me, but I'm not all that familiar with > vc.el internals. Does anybody else have any opinions on this? It's only reasonable in buffers where default-directory is really meaningful. E.g. in *Help* or *info* it's likely not going to do you much good. So feel free to add more major modes (rather than just `dired'), but I don't think using (vc-responsible-backend default-directory) everywhere is a good idea. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 05 09:37:03 2011 Received: (at 6870) by debbugs.gnu.org; 5 Jul 2011 13:37:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qe5oE-0007By-Ar for submit@debbugs.gnu.org; Tue, 05 Jul 2011 09:37:03 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qe5oA-0007BM-W6 for 6870@debbugs.gnu.org; Tue, 05 Jul 2011 09:37:01 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qe5ny-0000Nh-TG; Tue, 05 Jul 2011 15:36:46 +0200 From: Lars Magne Ingebrigtsen To: Stefan Monnier Subject: Re: bug#6870: Make vc-root-diff work in more modes In-Reply-To: (Stefan Monnier's message of "Mon, 04 Jul 2011 14:13:42 -0400") Date: Tue, 05 Jul 2011 15:32:05 +0200 Message-ID: References: <19561.60443.364109.899857@rgr.rgrjr.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Joanna Newsom's _Have One On Me (2)_: "Go Long" X-Hashcash: 1:23:110705:6870@debbugs.gnu.org::I6akTfKe0oLW2H61:00000000000000000000000000000000000000000442I X-Hashcash: 1:23:110705:rogers-emacs@rgrjr.dyndns.org::UUFOgLdfz0wTR1t+:00000000000000000000000000000000JIQt X-Hashcash: 1:23:110705:monnier@iro.umontreal.ca::xzXzh7VTf9xfEjnn:0000000000000000000000000000000000000Qgfn MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qe5ny-0000Nh-TG X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310477807.33432@sOFxPKpMSGHvIbqVTqWC/A X-Spam-Status: No X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 6870 Cc: rogers-emacs@rgrjr.dyndns.org, 6870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Stefan Monnier writes: > It's only reasonable in buffers where default-directory is really > meaningful. E.g. in *Help* or *info* it's likely not going to do you > much good. > So feel free to add more major modes (rather than just `dired'), but > I don't think using (vc-responsible-backend default-directory) > everywhere is a good idea. What about all buffers that have file names? A la (and (buffer-file-name) (vc-responsible-backend default-directory)) or something along those lines... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 05 15:04:18 2011 Received: (at 6870) by debbugs.gnu.org; 5 Jul 2011 19:04:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeAuv-0001Fn-7o for submit@debbugs.gnu.org; Tue, 05 Jul 2011 15:04:17 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeAut-0001Fa-Bd for 6870@debbugs.gnu.org; Tue, 05 Jul 2011 15:04:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAMBfE05FxIxr/2dsb2JhbABTqAl4iHrCUoY2BJ5chCw X-IronPort-AV: E=Sophos;i="4.65,481,1304308800"; d="scan'208";a="120562692" Received: from 69-196-140-107.dsl.teksavvy.com (HELO pastel.home) ([69.196.140.107]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 05 Jul 2011 15:04:09 -0400 Received: by pastel.home (Postfix, from userid 20848) id 72154592B2; Tue, 5 Jul 2011 15:04:09 -0400 (EDT) From: Stefan Monnier To: Lars Magne Ingebrigtsen Subject: Re: bug#6870: Make vc-root-diff work in more modes Message-ID: References: <19561.60443.364109.899857@rgr.rgrjr.com> Date: Tue, 05 Jul 2011 15:04:09 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Tue, 05 Jul 2011 15:32:05 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 6870 Cc: rogers-emacs@rgrjr.dyndns.org, 6870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) >> It's only reasonable in buffers where default-directory is really >> meaningful. E.g. in *Help* or *info* it's likely not going to do you >> much good. >> So feel free to add more major modes (rather than just `dired'), but >> I don't think using (vc-responsible-backend default-directory) >> everywhere is a good idea. > What about all buffers that have file names? A la > (and (buffer-file-name) > (vc-responsible-backend default-directory)) That'd be fine, yes. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 05 16:58:24 2011 Received: (at 6870) by debbugs.gnu.org; 5 Jul 2011 20:58:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeChL-0005dC-BV for submit@debbugs.gnu.org; Tue, 05 Jul 2011 16:58:23 -0400 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeChJ-0005cz-CF for 6870@debbugs.gnu.org; Tue, 05 Jul 2011 16:58:21 -0400 Received: from furball (dhcp128036014245.central.yale.edu [128.36.14.245]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p65KwFoV017838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 5 Jul 2011 16:58:15 -0400 From: Chong Yidong To: Stefan Monnier Subject: Re: bug#6870: Make vc-root-diff work in more modes References: <19561.60443.364109.899857@rgr.rgrjr.com> Date: Tue, 05 Jul 2011 16:58:14 -0400 In-Reply-To: (Stefan Monnier's message of "Tue, 05 Jul 2011 15:04:09 -0400") Message-ID: <878vscla1l.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6870 Cc: Lars Magne Ingebrigtsen , rogers-emacs@rgrjr.dyndns.org, 6870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Stefan Monnier writes: >> What about all buffers that have file names? A la > >> (and (buffer-file-name) >> (vc-responsible-backend default-directory)) > > That'd be fine, yes. But this might be confusing, since this check would not trigger for non-file buffers generated from those file buffers. i.e., if you have a buffer with a file name that is not handled by VC, vc-root-diff would work for that buffer but not for a diff file generated from that buffer. Whereas if a buffer with a file name *is* handled by VC, vc-root-diff would work for both that buffer and a diff file generated for that buffer. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 09:39:00 2020 Received: (at 6870) by debbugs.gnu.org; 25 Aug 2020 13:39:00 +0000 Received: from localhost ([127.0.0.1]:60777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZAC-0007oW-3G for submit@debbugs.gnu.org; Tue, 25 Aug 2020 09:39:00 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZA4-0007nh-J9 for 6870@debbugs.gnu.org; Tue, 25 Aug 2020 09:38:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kf0OHUUXug3cA2HQaD41m34CBKigfYhIWXc4ffAr92g=; b=LLjoBh0BTWA7xRRMknVl1Ymz0m Ll9GEgQ+XzUaGMZ8PoAn/2SMQ2srQ0hikf4tCkzRqeR/UxLjwY87HX51dYM1UxACArswwIzVAFnAJ 27yY2YWOqalAxdPEcsOYXx0zzzcasfJUG0Rt2LK0jlkKeAydTtr+FSCAeYSAk9nsHhVA=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAZ9v-00068V-M6; Tue, 25 Aug 2020 15:38:46 +0200 From: Lars Ingebrigtsen To: rogers-emacs@rgrjr.dyndns.org Subject: Re: bug#6870: Make vc-root-diff work in more modes References: <19561.60443.364109.899857@rgr.rgrjr.com> X-Now-Playing: DACM's =?utf-8?B?X1N0w4PCqXLDg8Kpb3R5cGllXzo=?= "LN End" Date: Tue, 25 Aug 2020 15:38:42 +0200 In-Reply-To: <19561.60443.364109.899857@rgr.rgrjr.com> (rogers-emacs@rgrjr.dyndns.org's message of "Mon, 16 Aug 2010 21:55:39 -0400") Message-ID: <87a6yi976l.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: rogers-emacs@rgrjr.dyndns.org writes: > It makes sense to me that vc-root-diff uses "(vc-responsible-backend > default-directory)" when in a dired-mode buffer. But since vc-root-diff > is not at all about the current buffer, why not also [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 6870 Cc: 6870@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) rogers-emacs@rgrjr.dyndns.org writes: > It makes sense to me that vc-root-diff uses "(vc-responsible-backend > default-directory)" when in a dired-mode buffer. But since vc-root-diff > is not at all about the current buffer, why not also make that the > default for shell-mode, diff-mode, or any of the other modes for > non-version-controlled buffers that may be generated in a working copy? [...] > - ((derived-mode-p 'dired-mode) (vc-responsible-backend default-directory)) > - (vc-mode (vc-backend buffer-file-name)))) > + (vc-mode (vc-backend buffer-file-name)) > + (t (vc-responsible-backend default-directory)))) This has been extended somewhat over the years: (defun vc-deduce-backend () (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend) ((derived-mode-p 'log-view-mode) log-view-vc-backend) ((derived-mode-p 'log-edit-mode) log-edit-vc-backend) ((derived-mode-p 'diff-mode) diff-vc-backend) ;; Maybe we could even use comint-mode rather than shell-mode? ((derived-mode-p 'dired-mode 'shell-mode 'compilation-mode) (ignore-errors (vc-responsible-backend default-directory))) (vc-mode (vc-backend buffer-file-name)))) So we still don't do this in all buffers, but since there's some issues with that, I think this works well now. So I'm closing this bug report. If there's more to be done here, respond to the debbugs address and we'll reopen the report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 25 09:39:26 2020 Received: (at control) by debbugs.gnu.org; 25 Aug 2020 13:39:26 +0000 Received: from localhost ([127.0.0.1]:60797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZAb-0007qx-Uu for submit@debbugs.gnu.org; Tue, 25 Aug 2020 09:39:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAZAE-0007oJ-2h for control@debbugs.gnu.org; Tue, 25 Aug 2020 09:39:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SYkVo98c3lPPBGu67O8ItpICiRn1gNVAYsQynTCZVfY=; b=PD52APe83gMtxZMsadokuiXvfj 56NjKdlvg1jLtXjWvC0lkE9PtGPLj0r/HObl2vcfUsgrbZ3lYMBlBaRzi3JYWbN5B0XH7Y5vyOzzr h1MkyynDlUSl3g4yJpWl3Tg4ibpXKK+h88Ci5zT5quZ9pAd70DpXMOWvtY38v7pdoWRc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAZA6-00068c-Ap for control@debbugs.gnu.org; Tue, 25 Aug 2020 15:38:56 +0200 Date: Tue, 25 Aug 2020 15:38:53 +0200 Message-Id: <878se2976a.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #6870 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 6870 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 6870 28.1 quit From unknown Tue Jun 17 20:20:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 23 Sep 2020 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator