From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 20:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 68698@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170612839611583 (code B ref -1); Wed, 24 Jan 2024 20:34:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Jan 2024 20:33:16 +0000 Received: from localhost ([127.0.0.1]:46695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSjvw-00030l-39 for submit@debbugs.gnu.org; Wed, 24 Jan 2024 15:33:16 -0500 Received: from lists.gnu.org ([2001:470:142::17]:41756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSjvu-00030M-0L for submit@debbugs.gnu.org; Wed, 24 Jan 2024 15:33:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSjvi-0002sb-C7 for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 15:33:02 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSjvg-0006MF-5C for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 15:33:01 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B655F10007D for ; Wed, 24 Jan 2024 15:32:58 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706128377; bh=EP+r4wFH0r8wzH646aKpYZxlJF6bf319kXKLV9S3F4g=; h=From:To:Subject:Date:From; b=BNoJ4xEren8An9hq/znHzZwdlb3B+S6Dfdf9+VTY/zvjA8VbWHpobueLKpzAR0oiH CZ1M8w4BQvTaAoVuhsoLoK7352tiuHsObrtp48pttMEY7DNmWWbtISoSAOOv+CRYiI TjBnEXcxxzNufcaD5IEc9BSFVfr19lUeSjKWA78DtxjfzfmCCHcrPZXpmy7LEPuWsl 2Lkbhl8VeecNFcQKsQX9zR1VbyUDv1qN69R4to5jd2HuJNe6VeMRAsjsZmEJ/Ss3Cm ArMI7qsVxyFURezKEDo3WTrvxJFSakDm1cvASpdaPVn4NGRZt88C3QJy6mU4wQyva3 xZzXWCdBG7gig== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AA1B810001D for ; Wed, 24 Jan 2024 15:32:57 -0500 (EST) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9D962120BF6 for ; Wed, 24 Jan 2024 15:32:57 -0500 (EST) From: Stefan Monnier Date: Wed, 24 Jan 2024 15:31:32 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.252 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Package: Emacs Version: 30.0.50 Currently, wheel-up/down events are generated in most setups instead of the old mouse-4/5. There are still two exceptions: - X11 builds not using XInput2. - text terminals. The attached patch intends to fix the second bullet. Text terminals themselves only give us info equivalent to `mouse-4/5` and don't actually tell us that it's a wheel movement, but we can still turn those things into `wheel-up/down`. This is related to bug#49803. The second step would be to do something similar for the non-XInput2 X11 build: make it generate `wheel-up/down` events according to `mouse-wheel-down/up-event` settings. Then packages like `completion-preview` and `mwheel` won't need to pay attention to the (confusingly named) `mouse-wheel-down/up-event` vars any more. Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=xtmouse.patch diff --git a/lisp/mwheel.el b/lisp/mwheel.el index 53042085bf6..66a1fa1a706 100644 --- a/lisp/mwheel.el +++ b/lisp/mwheel.el @@ -59,7 +59,7 @@ mouse-wheel-change-button (defvar mouse-wheel-obey-old-style-wheel-buttons t "If non-nil, treat mouse-4/5/6/7 events as mouse wheel events. These are the event names used historically in X11 before XInput2. -They are sometimes generated by things like `xterm-mouse-mode' as well.") +They are sometimes generated by things like text-terminals as well.") (defcustom mouse-wheel-down-event (if mouse-wheel-obey-old-style-wheel-buttons 'mouse-4) diff --git a/lisp/xt-mouse.el b/lisp/xt-mouse.el index cd00467f14f..fcc0db1d9eb 100644 --- a/lisp/xt-mouse.el +++ b/lisp/xt-mouse.el @@ -40,6 +40,8 @@ ;;; Code: +(require 'mwheel) + (defvar xterm-mouse-debug-buffer nil) (defun xterm-mouse-translate (_event) @@ -193,6 +195,12 @@ xterm-mouse--read-number-from-terminal (cons n c)) (cons (- (setq c (xterm-mouse--read-coordinate)) 32) c)))) +(defun xterm-mouse--same-button-p (event btn) + (and (symbolp event) + (string-prefix-p "mouse-" (symbol-name event)) + (eq btn (car (read-from-string (symbol-name event) + (length "mouse-")))))) + ;; XTerm reports mouse events as ;; in default mode, and ;; ";" ";" <"M" or "m"> in extended mode. @@ -231,12 +239,24 @@ xterm-mouse--read-event-sequence ;; event: assume, that the last button was button 1. (t 1))) (sym (if move 'mouse-movement - (intern (concat (if ctrl "C-" "") - (if meta "M-" "") - (if shift "S-" "") - (if down "down-" "") - "mouse-" - (number-to-string btn)))))) + (intern + (concat + (if ctrl "C-" "") + (if meta "M-" "") + (if shift "S-" "") + (if down "down-" "") + (cond + ;; BEWARE: `mouse-wheel-UP-event' corresponds to + ;; `wheel-DOWN' events and vice versa!! + ((xterm-mouse--same-button-p mouse-wheel-down-event btn) + "wheel-up") + ((xterm-mouse--same-button-p mouse-wheel-up-event btn) + "wheel-down") + ((xterm-mouse--same-button-p mouse-wheel-left-event btn) + "wheel-left") + ((xterm-mouse--same-button-p mouse-wheel-right-event btn) + "wheel-right") + (t (format "mouse-%d" btn)))))))) (list sym (1- x) (1- y)))) (defun xterm-mouse--set-click-count (event click-count) --=-=-=-- From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 02:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 68698@debbugs.gnu.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.170614957926171 (code B ref 68698); Thu, 25 Jan 2024 02:27:02 +0000 Received: (at 68698) by debbugs.gnu.org; 25 Jan 2024 02:26:19 +0000 Received: from localhost ([127.0.0.1]:46942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSpRb-0006o2-2z for submit@debbugs.gnu.org; Wed, 24 Jan 2024 21:26:19 -0500 Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:39736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSpRZ-0006no-0f for 68698@debbugs.gnu.org; Wed, 24 Jan 2024 21:26:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706149564; bh=ylGZjhG/nskusZ9AMp+faHGfxgQiMkRweGdaxIuW3ok=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=joGKou85xCz3lJXtpVRpYhpzl88tXsJ8oSExK8hbaXKnuLGYUtW4gLG2sDSUHm6dHIPkde3VgSSuoc/uT+Fhwj7DiJ3Qk+ok9pAPS8t/bwjwtmMBfvqHXS3MG1PJgMjWLgUCciVNllNOIChTaA64jCdiHz3z1r4gUc1DPlcC9Uei9E3VnuwxGfa+2RO9Wmg01fgeQwQZi/bCvcIvDMcdqfV5346SE08Q6EISwfcnMDqisf9eNKHdff6yjDTr7CR9odc42qGyWBGtmNOKkgZiN8FhTQ6vNDRW63GDKRCy6R10z5enzO87B4tGqKBMm4T7ehZRwNQqQ3ammhm6OIJ99w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706149564; bh=sTFSR74nVrmxXe4Vcz+9wbQI9IZQCewxuhHJXsD+YJe=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=RVEeGMHqWEl1bQOjCWA/6TXi1tkJYwjkm5u8xPuWTkAIExKmh7WQToCsDYgb+P7LFC/RxZl3zXK8BxYl6LcusNw+raN5Y8M64ilT6DtafhIDqtEWQ5Ni/MYoR7/G1798wLmmvF3oLDQFg83yf2QXSI1kDiVUwPUFV1HTjQ6b7X0YsZ2FUfKNEaFt0Rs3c7rzPcl8kHw+JUCuYTuJTnkmoXXW0ZYNe3P23PGuh4GxEDAJCVueTh21+WjD5Ct4zXUQJ0hZ58qeMm+uZpdTUetsUI0GHVLQLUzY/AFk/Qj085/6ZQoL6GnB5Ei6tiN/MkIiiRbtN4HVVEdO3YmbParCTw== X-YMail-OSG: YuVkQQMVM1lpMUe85TcZWqc5yareEjIVZ_.hgFLFqJ96sdh1Gbs0fLrnGs3VnWY s0yceoELaIKqpRtfp9..FUlBv12L1Fosys.IOA3OfROVPYC3ZdFBu6AVawAKqamNBS7DLvYuNbsF IX1CAwj6rehNl8NX4aJTawG0sxWFlLwKFRe0Eqye_93cqEri7hf_eaIvTpDwun0xqWraSoyuWiHN UuLHTlcAOb_AzAm399CJGb5x3OGA0yaxszgxmuTOA4y4oXNBYA.jBD_hO0Ah8JlY.uYjtqgTUpU9 3PNU8BayGKE0uGl_me5S5mdpwSrmaN6mYPLVrER.HZQVd7C4r.TU8qmGu.xPQXnYH2GVoFc0N90O 9AIOIuudHvgQ2u2yTPwATza8bKVaLZbaNkBD66QiqnKFBb90jf5g4C9AtT_2BclQXZ4k7562i.VC sa10hh46jzYC3MHdNn91ZqqkG_0uQBp_JIeaE_g8SZtCzemFNXfFqu8IgPQO3hp5LE3mqy7CJp.h F7EPq8f7XRmUdR6HkhlnqJxOzk4hq84UXMwmkDgEX4RLA5rMWJyCMMCLs6adngKFYv24HIGEuxXY owvEV.xyqSlQgnaKFFzfxUTiI9liGJWoJjxs5iCI8jZj8SrJmvbqGwrA56YKtH9RktlULKuGQE0x RxACOP87WcJo_LLut7QiArgICnFFm69CZaQI5vGLSIXSMxjx3Mf.HlUFZvsrJR0h8V7UOMNXzjuT rDjIl0Gv.OFtTqXeWY.iuaai33.jrfta.XF2vhzAfxKYUUlD8Gzej.mVdLh9pHVUpkUeShBSUOnM aKrOG0I331eIXpPKuSAMXEBdVJq95lhK0lnejKoL575V0kxc678cOYMYzZeJqERDzLEIwF1ndTH3 ve..v_rl9DoRZzVHCNeAO2T1fXVKnNi3Nf3ClMlQtnU_wu9g3ogLu1wR8YyvpZU2ZLoWjBJi93y4 MmZEMovVFpSpAl1Mqm_JN4B4I0YvgEtpBjJOs0c1wNfQxVLJxLyYUf.do.EkMMJVlynEHVVYRGZG qy2qh6nXVi3HV.VWkzVfTZvbva0NXo0JmAEmWMf9Xck4j4T.Jv_m9ruCpeDTfSUlYBQVR_2ntyh. 5VOCwvhZ5daPobu07wnL5UoNQQ2ypki5pyGvOjDDfRUTKP0urw6Tzml.H0T2Q.RrRQqjdnq34kPe V64VEz8oq.VrCWaM9R9j2x9QTRxl_v63y0ATlG9L3Xtgw0_BqXSXXx0WJjLqijm9prpHHDRFMR2Y fHCic1mPsKYciQK45LU1_vRLXjoVjPJWFBrF.aMS57fsTuU34Co62E.ptZh8Tq799DNkzWEHUNcV ZJKyMtM5KtjJizgPvylAy6_HQdnsmfiQHe35czmZO0WHJNP2W9S3F1kBxV.3hrfNo48IyCGNW._i rBKHTXxdX9pl1LHtWHXTQLt24N2oK.pDAaX7xv2jI1xoMYnac7gvP6jTwqUp9u9iBLVIdjQ8C3qW b9E_Nxqlm0ZW94uc3fzVE7iehT4rDHuexWfWu_bffBSCXpohs2XPAwApC0d4mImRMNnwmiL3SplN ewh14FSKlWj59Dho_uKOIRFKdJaLlerHRom68ytbspu6BNyFeeY8LSNm.7QBnV9SMx7Ku3VDAj.2 61hIcCyB53QyK9.pG5qGPIjE1L1Mf.TCQIDisIkKMNMRWOZsSClFgVrh4akScT7z7hkI1_Zjiejj 1hSCWrE.1_z_IX0tB_hgK0ck9a4whKr6hr96CML0x66uB3TxofY06azFf8hY9FEOPrl9I.Qo0Y.1 EpwhoJTaLnxR4iVmYU3ZMlJ.m7oPiSC2KrfG1ZqCk2Y6jdwRRpM5oTRcW4_mxfuU0TkGSK.xUxQC HZmtfgFoovEVM9.47BLzTNMDp5MQoL5Cv0_Hn9fCqtuKinHS3wdoUYr2MBHXAx93ZxP5y9.j04UK wbNPZm5hhTDlJB8TyXnIEo.Bg0yBwCIYw9fzLnoDmKL.6xBMjgk1yTaHWAAmOP1G0rF5KPFbBZjM nDs2RBGzDPKqL2ApeyXgQ.BD9DxjxizKqI6nStJ1wBjh9Tzya6C2h2IO3EL9aJjfu.EjSRMxmpeX ENv603pX00ceLThXa2Sg516YL76jw3DylinjCL6r0pPwKfAUC6nKV68pZ8VXq8ElpG0iMGlsWdX8 a9Z46IV8WofPqZ.T.qxSG_qutrCcQ4hjNU4ITT4JhVATZWfN7KEjrCw5eF80Y000004ozMXGnPMW Pwznj0Iglo48FyfTBCiaOVh6gmiiL456bPHg0ySdeDA8bIGz8lvchJmjkUMZcvDj8_6d7OoY- X-Sonic-MF: X-Sonic-ID: 38bd7b11-ab3a-417c-95b2-6a9272b5a1cd Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Thu, 25 Jan 2024 02:26:04 +0000 Received: by hermes--production-sg3-677476f564-2fwms (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7f0a4cbec8b0ee22b3b4b5860dc81ae3; Thu, 25 Jan 2024 02:25:58 +0000 (UTC) From: Po Lu In-Reply-To: (Stefan Monnier's message of "Wed, 24 Jan 2024 15:31:32 -0500") References: Date: Thu, 25 Jan 2024 10:25:53 +0800 Message-ID: <87sf2mp2ry.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 775 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > The second step would be to do something similar for the non-XInput2 X11 > build: make it generate `wheel-up/down` events according to > `mouse-wheel-down/up-event` settings. Then packages like > `completion-preview` and `mwheel` won't need to pay attention to the > (confusingly named) `mouse-wheel-down/up-event` vars any more. No! Button4, 5, 6 and 7 are only mouse wheels in one particular group of X servers. It is impossible to detect whether they are mouse wheels without the input extension (and this is why XI display connections produce wheel events), so such an escape hatch as mouse-wheel-*-event _must_ be provided for X servers where the general assumption that they are mouse wheels does not hold true. From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 07:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier , Jared Finder Cc: 68698@debbugs.gnu.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.17061678246173 (code B ref 68698); Thu, 25 Jan 2024 07:31:01 +0000 Received: (at 68698) by debbugs.gnu.org; 25 Jan 2024 07:30:24 +0000 Received: from localhost ([127.0.0.1]:47190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSuBr-0001bV-J2 for submit@debbugs.gnu.org; Thu, 25 Jan 2024 02:30:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSuBp-0001bH-6z for 68698@debbugs.gnu.org; Thu, 25 Jan 2024 02:30:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSuBc-0008Ey-PC; Thu, 25 Jan 2024 02:30:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KamgTEK4Ca/NhbK4Hjm4DV9hZ4YihZL9uUcuCdUOTFo=; b=Wc5ElR9JTZOX gzSq+Ffod/Di/Ukkyo2ZJrOZLw1C2ewyxpOkCHjPyXbvsYBXGfdEO19l2yz4gK4wkk0YS4IWekOYT TE1+/99ScfQ9aKcSEVXL3LXw5Omgf6ZqvHJM4nP1AXmEFPGUna3PKoq+6d5tQaPN+NHaxcbP+HyhE 9Rf5wS2nIsUTiW6b4B0mH35AW+xXLL3x/mTksuvIdf65EhqiX6n6f/2xtYDbyEKEDuexMMGNGUQk3 EZ9/NPfhV4GkAy+d9wzsLU55yVHxv3pTelnhCtc9kkTpZ0PHTGKTvdrkniIwAJPt1rvsiK+/O7mDT d/sE7sAQBYbbtXFjuCOlwQ==; Date: Thu, 25 Jan 2024 09:30:05 +0200 Message-Id: <86o7d9dg5e.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (bug-gnu-emacs@gnu.org) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 24 Jan 2024 15:31:32 -0500 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Package: Emacs > Version: 30.0.50 > > > Currently, wheel-up/down events are generated in most setups instead > of the old mouse-4/5. There are still two exceptions: > - X11 builds not using XInput2. > - text terminals. > The attached patch intends to fix the second bullet. > Text terminals themselves only give us info equivalent to `mouse-4/5` > and don't actually tell us that it's a wheel movement, but we can still > turn those things into `wheel-up/down`. > > This is related to bug#49803. Jared, any comments on the patch, or related issues? Thanks. > The second step would be to do something similar for the non-XInput2 X11 > build: make it generate `wheel-up/down` events according to > `mouse-wheel-down/up-event` settings. Then packages like > `completion-preview` and `mwheel` won't need to pay attention to the > (confusingly named) `mouse-wheel-down/up-event` vars any more. > > > Stefan > > diff --git a/lisp/mwheel.el b/lisp/mwheel.el > index 53042085bf6..66a1fa1a706 100644 > --- a/lisp/mwheel.el > +++ b/lisp/mwheel.el > @@ -59,7 +59,7 @@ mouse-wheel-change-button > (defvar mouse-wheel-obey-old-style-wheel-buttons t > "If non-nil, treat mouse-4/5/6/7 events as mouse wheel events. > These are the event names used historically in X11 before XInput2. > -They are sometimes generated by things like `xterm-mouse-mode' as well.") > +They are sometimes generated by things like text-terminals as well.") > > (defcustom mouse-wheel-down-event > (if mouse-wheel-obey-old-style-wheel-buttons 'mouse-4) > diff --git a/lisp/xt-mouse.el b/lisp/xt-mouse.el > index cd00467f14f..fcc0db1d9eb 100644 > --- a/lisp/xt-mouse.el > +++ b/lisp/xt-mouse.el > @@ -40,6 +40,8 @@ > > ;;; Code: > > +(require 'mwheel) > + > (defvar xterm-mouse-debug-buffer nil) > > (defun xterm-mouse-translate (_event) > @@ -193,6 +195,12 @@ xterm-mouse--read-number-from-terminal > (cons n c)) > (cons (- (setq c (xterm-mouse--read-coordinate)) 32) c)))) > > +(defun xterm-mouse--same-button-p (event btn) > + (and (symbolp event) > + (string-prefix-p "mouse-" (symbol-name event)) > + (eq btn (car (read-from-string (symbol-name event) > + (length "mouse-")))))) > + > ;; XTerm reports mouse events as > ;; in default mode, and > ;; ";" ";" <"M" or "m"> in extended mode. > @@ -231,12 +239,24 @@ xterm-mouse--read-event-sequence > ;; event: assume, that the last button was button 1. > (t 1))) > (sym (if move 'mouse-movement > - (intern (concat (if ctrl "C-" "") > - (if meta "M-" "") > - (if shift "S-" "") > - (if down "down-" "") > - "mouse-" > - (number-to-string btn)))))) > + (intern > + (concat > + (if ctrl "C-" "") > + (if meta "M-" "") > + (if shift "S-" "") > + (if down "down-" "") > + (cond > + ;; BEWARE: `mouse-wheel-UP-event' corresponds to > + ;; `wheel-DOWN' events and vice versa!! > + ((xterm-mouse--same-button-p mouse-wheel-down-event btn) > + "wheel-up") > + ((xterm-mouse--same-button-p mouse-wheel-up-event btn) > + "wheel-down") > + ((xterm-mouse--same-button-p mouse-wheel-left-event btn) > + "wheel-left") > + ((xterm-mouse--same-button-p mouse-wheel-right-event btn) > + "wheel-right") > + (t (format "mouse-%d" btn)))))))) > (list sym (1- x) (1- y)))) > > (defun xterm-mouse--set-click-count (event click-count) From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 13:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Po Lu Cc: 68698@debbugs.gnu.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.17061904541468 (code B ref 68698); Thu, 25 Jan 2024 13:48:01 +0000 Received: (at 68698) by debbugs.gnu.org; 25 Jan 2024 13:47:34 +0000 Received: from localhost ([127.0.0.1]:47612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT04r-0000Nc-Qs for submit@debbugs.gnu.org; Thu, 25 Jan 2024 08:47:34 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT04p-0000NL-RI for 68698@debbugs.gnu.org; Thu, 25 Jan 2024 08:47:32 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E8E2F4425C2; Thu, 25 Jan 2024 08:47:19 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706190438; bh=1P8Un2HGI4xfQSNr20C8nM337MQmt0JfCKS0pFIxD3Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gjkVQQJz92VvEQcaonM9FgU5Jh5tmwJblxQnKdDrMgg2OYFfr6/wbzdwB7m9fd5pd 5iPC6tPKDDuIvDCBLtEVypaqW5o+a/fETO6DrfyP/Dft2kz7AtOqpiTynkNnNHje4r 7XJHinNoOh6dDYhpA/qSoVUhEUpEQ53DaYGE5PJ5uDjVDohRiRpHuEJq4ytkFWlpfa snx2XuEXEGj1Z4ommAvQ5IFwbFQ/K9UApDq2s4Jy5UFKKGKqX2FhASXCTDZltkOgWr jlh3+/sorXH63YRg164dDJc6P/uamecLvk/YIHuiAFaYbrzMldjEPd/8qfy7kKlOUJ mI9FN987XGJEw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A41CB4422F8; Thu, 25 Jan 2024 08:47:18 -0500 (EST) Received: from pastel (unknown [45.72.206.68]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4B7391202C3; Thu, 25 Jan 2024 08:47:18 -0500 (EST) From: Stefan Monnier In-Reply-To: <87sf2mp2ry.fsf@yahoo.com> (Po Lu's message of "Thu, 25 Jan 2024 10:25:53 +0800") Message-ID: References: <87sf2mp2ry.fsf@yahoo.com> Date: Thu, 25 Jan 2024 08:47:17 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Po Lu [2024-01-25 10:25:53] wrote: > Stefan Monnier writes: >> The second step would be to do something similar for the non-XInput2 X11 >> build: make it generate `wheel-up/down` events according to >> `mouse-wheel-down/up-event` settings. Then packages like >> `completion-preview` and `mwheel` won't need to pay attention to the >> (confusingly named) `mouse-wheel-down/up-event` vars any more. > > No! > > Button4, 5, 6 and 7 are only mouse wheels in one particular group of X > servers. It is impossible to detect whether they are mouse wheels > without the input extension (and this is why XI display connections > produce wheel events), so such an escape hatch as mouse-wheel-*-event > _must_ be provided for X servers where the general assumption that they > are mouse wheels does not hold true. I'm not suggesting to get rid of those vars. I'm suggesting to use those vars in the C code when generating the event. Stefan From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 14:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 68698@debbugs.gnu.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.17061922464829 (code B ref 68698); Thu, 25 Jan 2024 14:18:01 +0000 Received: (at 68698) by debbugs.gnu.org; 25 Jan 2024 14:17:26 +0000 Received: from localhost ([127.0.0.1]:47679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT0Xl-0001Fp-Vd for submit@debbugs.gnu.org; Thu, 25 Jan 2024 09:17:26 -0500 Received: from sonic310-24.consmr.mail.ne1.yahoo.com ([66.163.186.205]:37457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT0Xi-0001Fa-T6 for 68698@debbugs.gnu.org; Thu, 25 Jan 2024 09:17:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706192230; bh=vDLvHH9qkpM0KvyBXCe+uNvrSKxrFjqXTchUvkdjPUg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=KdB7mBXwBIe5COqoPfSmBZxE85aUF9Qt2XJwfzAKUESyoDd0I0mRweGXW3AXH2Fo3ibnNnPIpdewXNLWvRdpsRsCmkuYd46j9yfqlBcLKzKmxI3HEvu/PLrX0Kijg5dwqk9LT9hms+TZf8uLNHaVx0/pLKgd4dic1J26YQchC8t1i3q67aG/uR0sSx4FLFo8uKHCHJua1rLlGeYq7rcNb30BSQhFcb0Hl20JFvPqE1LDOhHb1SRAw0pZerLBm/7FQX5vDZndHm06J3A97pO4OlpsBgM5bnoAmJAcs9XDpAYeNx2vGge1cSHL5G7rVqHlFuomK0VJh3l4R62oWD4Z/A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706192230; bh=lSlwmlgGWA+WxuPK5Lwlg0VF6Ye6F+S6PK6K/YmYqFO=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=YvOTOApTFKydd0XUDKPzLNlmWTq6wniS4DyKHE/I9wg/x3AH+nMiDgAhyu9bHEulfBHLmbFLDp8UdbGVuEJxXiBdlzYEfMvOD1liOvRruH206x/cBo5U0FKoJ3AlGeLsN0Cju1q/k1pNo9iMf7ziEp8JRzdfJ0TPMuqQ77OkhN5Wpxf//o5JZn0pF+orlCm8NDAw/VHsVV4lzdajqJmZ+ek5hh4DdTuT32ey9cabJ3G7v81s2RP1Y0eyetlx1j6EBvQK5EsizpkLgxCXZNgrcnvt+H2aO8SnYmfAtdGJmjV5Xn4mKt7g97aQj1sEWC73DL6FCEO7+cLo5p/mreYIiQ== X-YMail-OSG: deYkRKAVM1kg5LVn9Cm.nzydrx3kn.tr6zzWJxSZ16o5tkUcbZXWXuAyVWmAr4C dXBQKY01yspN3_v9HH6ObqI7jdP.3ah.JmDNz3sBaSczyoIK3GeNnhqpV8_qJNdYTO_gjzYkIVxE 3yppBZcQ5hF8AXkbgoDJU6LujgmC4IERZsiEWyjX0MvW30mHyapjrLaZw.A9rYe1F2weLldejI7Z Co4XelBcM0ji78Rs.eNKveY6WSf0qAlIXFLJDHU8MsSXxEOhIlW.H33bMBFV4QBYfGBGUkpY.EDv lpmxNgcD3y1HAx.R68gTIK0H.dlWzxjiNEs0vg40OjoGW1O0YTMJ5dx31CoK2x0ManUuAqN6SeEB fOKPRL6jdKikvgcxCaZAskdeiM0e.0toOozE42xyUlkJkblkjZoL7DGhDDxmIIiU8k9Tcfx_2Goi 2c00sqNdAJynTC9h6fzZzduzY6zdJsO_slrIqgqZM548nsshynxqDB7V.DinwdtPWNOgs7ceZ0US 2R96cPXlpWuIZf3ckhsCUsHmkajePlc2.Y4.V3_qlhVl_FF0ukldVR2Eaqdf0M2ODQfc6HY73XyM 7_kERZXnjejUOz3SQnocaQL2j9tJWHE98h.lenAkY_ynRZ0UEeNGy9fx19ARlwrejUde_5NIeF5L Uiozr_JpBGMQh_slbVTgOWjczbCdnvKxh9kZZNTW_eltBIr.Aye1LbY2JD__wfrPkUtPtS6DmzXG 1ZGQ2XZCu8Zv7yeVUQfS1kNOXQpY0Ft3iYM7psm.jmgmnu2f6flaBrF14VqpdmLLT7zwZNczLLch 2ZXQNFU.dKDXgjsuVBEujnEMeIlwjRvQjUEcEGYtlWvuv180FuDKgqLAr7WwYF4v0QNH1LrpuQEP 8qIbcA7SJKbisRbT5JpnrZ5FkO85oKuQL6YbgR0BjHaixrrdr5LC1xxS98.NiFjiIDyJOX7Wf6sn sXff36QC0BVm5gH441UP7Wh3HWGVfNai_UGMJPBxQIZB7sbk.7e5GlTgrfqr6J7o6D4ZpxysCk7S WZqxLnqqGUPyqblm_GLdobuvZ1jp5CTc8mlpT4DQTfdbsBy9t8eSi8jWHaXP5Rjv3hTIsxd.oRLU AgU0J7xR4OX4VPoAZmRYdXOCYqfQ7zSyL.v7a8TN41hMbkI2zDfKRgKiAWNYXhnXMPW.UfEGZbRO P6.Nqrc7MyJu2UjVREX9vYWkE69s2cpBMXXLrLf35WQS4Er1Wl6d0lTI8pljKM5J2CAnMHdixVdZ wUrMGjv4UFjAAcNAtffWO4Stg4Ja4xEF_OkHgT3SjJ26aWD4qyLa6IyhgF4xeoXFJifrzt100lRP YdeT3qp.C_6B2KHmIRMEnlk8.XCAhTtGI7iNT3nmXFTW3mi60H4q8sMSw.x5HFHIjyMhuNA33NfV 0pggNgQdpvUuLHPRBWpXRA_jvt2S5szpob.6.77QNZMG0pzZAbaiL.geA0rBpG8WGgsfRe9plKj2 WQqH8a0fM25SR.PeQQDqUD2ve37q8SkQMoH4mG9UD_5CASfgk58QazWG_ykKFg3F65LxJ0gE99Wd MinZjQOjbeCbMCtOGkpxsttnx.apox9sHw2rBNw6rpXWc4jOaIJScAuJDuVADs5.DVx4QtBLIFgC H8li34rX8NfWPRxuT8BXamJFqIfgWwr5lVZHTa94808MOWNsr_nGQRnvdiwSLWQe1m2pnhvGn53d 9VZX2YdwaXkJG0hJqXm42ECbOb4Dka24dIMZSqW.SXZ6.02JCHcSjg_lZvicPc7ivb8oh4RaKYz4 HyN4YJOnO38xcVCRZNEDs6glLNznWJKwT.WvFSQBOfm3y3QTPznPmqyyUZnL2O9ZFQoJiBlruApf wRkuRZlMFP393uW4Sdqfl0RANgvD.kL796hqbn9L3ro7lcPzpB.6ZNm6EnERRA5ZUbICk2mGmS88 hvaz3c7qO1OuUOvgfLoH8eWOG9v0WZxFsuotSS6o_8eNmLRgrQRBCXEmBqR.FsaMfkIZA7dJZ0Ta no70ji6QBI9_kef8UKWfvzdt2C2rzulQvLT.6pt4LpOwi9_EYC3K.f9DHCivY0aTY8JWaE9faXPf 5OkKMr8Yc2pKJ_GubQvDjM3nGWU5hFsM45njDMf1ThqoshGvnU1LZFMM2IZB5Db0XcJHDTad9pcH qlZaQfCPoxVHhKVf7RbW2pV6Yr2dmXL6O88IH9nb88iktUhpCGRPiPEGq0C6xFUkRAcePtAu.oqM fL9JdU9ROLjtrEx6ni6XQIFpe1ayLo05EyZnm0Pl04LOQ4smX8xAzs.L3pAIlDzQvk2Um X-Sonic-MF: X-Sonic-ID: 470eae6c-ba68-45cc-8248-cf0f1796032b Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Thu, 25 Jan 2024 14:17:10 +0000 Received: by hermes--production-sg3-677476f564-ppbwv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 948866a0404fcbcbe681a3ef35266eee; Thu, 25 Jan 2024 14:17:02 +0000 (UTC) From: Po Lu In-Reply-To: (Stefan Monnier's message of "Thu, 25 Jan 2024 08:47:17 -0500") References: <87sf2mp2ry.fsf@yahoo.com> Date: Thu, 25 Jan 2024 22:16:54 +0800 Message-ID: <87r0i5o5ux.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 254 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > I'm not suggesting to get rid of those vars. I'm suggesting to use > those vars in the C code when generating the event. Why, though? Why not bind them within input-decode-map, if really necessary? From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Po Lu Cc: 68698@debbugs.gnu.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.170619727924748 (code B ref 68698); Thu, 25 Jan 2024 15:42:02 +0000 Received: (at 68698) by debbugs.gnu.org; 25 Jan 2024 15:41:19 +0000 Received: from localhost ([127.0.0.1]:48923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT1qx-0006R6-0K for submit@debbugs.gnu.org; Thu, 25 Jan 2024 10:41:19 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT1qv-0006Qs-9V for 68698@debbugs.gnu.org; Thu, 25 Jan 2024 10:41:18 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 72EBB4427E6; Thu, 25 Jan 2024 10:41:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706197264; bh=fuenU9w42JotOcDKa6OqS3aKchECF4zSTuRt6JSOr80=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=H9uELp4FUkPiboRK5G5NuXfA5G3Gtp6OgfUiCPyZER7n3NQtjm7dOwBtmZxCzVmkr VAnoPQvDd+vUn3UOPNZQmr9RqaEPHxCtLj2m1HN/Xm4ctPmNhGJVgiouOfwZApnw0C /lD4kZ3kHD/0pPnCQJEIcaEuB8c1quWSSNYyHA5tCvSiEXheLBksyspaZNlP8mSVR9 jtSwG4UxKLzFIhC35V5Sj4eJWSR/0DsO5jPVhwXsNKePJSMv3Z/s0V8Ie8ueNgDYMP RtTwO1sl3QAMiY4X3m246n0bH9PcVJencHK96sc22MPKtYOzsQXg2BDNd96ETX9bto NuEM6A7lusDOw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EB7244422F8; Thu, 25 Jan 2024 10:41:03 -0500 (EST) Received: from pastel (unknown [45.72.206.68]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C2261120BE4; Thu, 25 Jan 2024 10:41:03 -0500 (EST) From: Stefan Monnier In-Reply-To: <87r0i5o5ux.fsf@yahoo.com> (Po Lu's message of "Thu, 25 Jan 2024 22:16:54 +0800") Message-ID: References: <87sf2mp2ry.fsf@yahoo.com> <87r0i5o5ux.fsf@yahoo.com> Date: Thu, 25 Jan 2024 10:41:03 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Po Lu [2024-01-25 22:16:54] wrote: > Stefan Monnier writes: >> I'm not suggesting to get rid of those vars. I'm suggesting to use >> those vars in the C code when generating the event. > Why, though? Why not bind them within input-decode-map, if really > necessary? The main reason is that it's painful to do it in `input-decode-map` because it has to be done not just for `mouse-4/5/6/7` but for all combinations of possible modifiers (shift, control, alt, meta, super, hyper, double, triple, down), so that's like a couple thousand entries we'd need to put in that map. Stefan "wishing we had more flexible keymaps (e.g. "procedural" keymaps which can compute the binding for a given key)" From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Jared Finder Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jan 2024 01:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 68698@debbugs.gnu.org, Stefan Monnier Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.170623329012809 (code B ref 68698); Fri, 26 Jan 2024 01:42:02 +0000 Received: (at 68698) by debbugs.gnu.org; 26 Jan 2024 01:41:30 +0000 Received: from localhost ([127.0.0.1]:49751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTBDl-0003KX-JD for submit@debbugs.gnu.org; Thu, 25 Jan 2024 20:41:30 -0500 Received: from greenhill.hpalace.com ([192.155.80.58]:44636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTBDj-0003KO-ME for 68698@debbugs.gnu.org; Thu, 25 Jan 2024 20:41:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1706233280; bh=QjIb5VA5WzG65UooJlVjdhQ+/j8bGqzd324g/qatx8M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gqXc9p8huEH12euQAPUFhaYHfi/WumCFpDNNO02OsTwTrUlzwgZ9Ayeko37XsYVF0 T9BnNWc1wAiRMtzsgtv64b7ANxyvQ0sMRtAcal+TkoEMTn1M6aoDSZ6XzjY2hPiu+R A9Uzdkw8TAVvBkhrFWGK1o2ci8it91S46a3qzeEfLsOJidZWUzTAiGI19VhiS983JE dT5P8cyu0B7k/d02da9tWWGRmxyHF7wgcctSdltxfRIBZov2aoAs5LeVxaTG/utidv 6iZqWbMyvfbHuXd0GlWaiKAwoKImc2uGyCUfX8HUJca5uscoNJLFaaZrnjBKPLttzL LJZe8Ux2nHHLQ== Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 91791A68; Fri, 26 Jan 2024 01:41:20 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 25 Jan 2024 17:41:20 -0800 From: Jared Finder In-Reply-To: <86o7d9dg5e.fsf@gnu.org> References: <86o7d9dg5e.fsf@gnu.org> Message-ID: <6f61db136adaa613660edbae970840b9@finder.org> X-Sender: jared@finder.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2024-01-24 23:30, Eli Zaretskii wrote: >> Date: Wed, 24 Jan 2024 15:31:32 -0500 >> From: Stefan Monnier via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Package: Emacs >> Version: 30.0.50 >> >> >> Currently, wheel-up/down events are generated in most setups instead >> of the old mouse-4/5. There are still two exceptions: >> - X11 builds not using XInput2. >> - text terminals. >> The attached patch intends to fix the second bullet. >> Text terminals themselves only give us info equivalent to `mouse-4/5` >> and don't actually tell us that it's a wheel movement, but we can >> still >> turn those things into `wheel-up/down`. >> >> This is related to bug#49803. > > Jared, any comments on the patch, or related issues? > > Thanks. > >> The second step would be to do something similar for the non-XInput2 >> X11 >> build: make it generate `wheel-up/down` events according to >> `mouse-wheel-down/up-event` settings. Then packages like >> `completion-preview` and `mwheel` won't need to pay attention to the >> (confusingly named) `mouse-wheel-down/up-event` vars any more. I'll be so happy if everything switches over to mouse-up / mouse-down events. This would be great. I'd love to ignore mouse-wheel-down-event and mouse-wheel-down-alternate-event. >> diff --git a/lisp/mwheel.el b/lisp/mwheel.el >> @@ -231,12 +239,24 @@ xterm-mouse--read-event-sequence >> ;; event: assume, that the last button was button 1. >> (t 1))) >> (sym (if move 'mouse-movement >> - (intern (concat (if ctrl "C-" "") >> - (if meta "M-" "") >> - (if shift "S-" "") >> - (if down "down-" "") >> - "mouse-" >> - (number-to-string btn)))))) >> + (intern >> + (concat >> + (if ctrl "C-" "") >> + (if meta "M-" "") >> + (if shift "S-" "") >> + (if down "down-" "") >> + (cond >> + ;; BEWARE: `mouse-wheel-UP-event' corresponds to >> + ;; `wheel-DOWN' events and vice versa!! >> + ((xterm-mouse--same-button-p mouse-wheel-down-event >> btn) >> + "wheel-up") >> + ((xterm-mouse--same-button-p mouse-wheel-up-event >> btn) >> + "wheel-down") >> + ((xterm-mouse--same-button-p mouse-wheel-left-event >> btn) >> + "wheel-left") >> + ((xterm-mouse--same-button-p mouse-wheel-right-event >> btn) >> + "wheel-right") I think there is a bug with mouse-wheel-up/down/left/right-event and alternate event where it doesn't take window-system into account. Without fixing that bug, this won't work because it is valid for mouse-wheel-up-event to be wheel-down in a terminal. A local run of HEAD (as of Jan 17, I'm at daec3e) with "./configure --with-pgtk" has mouse-wheel-up-event set to wheel-down because (featurep 'pgtk-win) is t, even with -nw on the command line. Testing on Windows at Emacs 29.1 shows the same behavior. Also, I do not think xt-mouse knows how to generate mouse-6 or mouse-7 events. I think to generate events beyond mouse-5, you need to test against the 128 bit as well. I don't have mouse hardware to confirm this behavior. -- MJF From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jan 2024 02:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 68698@debbugs.gnu.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.170623441415035 (code B ref 68698); Fri, 26 Jan 2024 02:01:02 +0000 Received: (at 68698) by debbugs.gnu.org; 26 Jan 2024 02:00:14 +0000 Received: from localhost ([127.0.0.1]:49761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTBVu-0003uP-2b for submit@debbugs.gnu.org; Thu, 25 Jan 2024 21:00:14 -0500 Received: from sonic303-22.consmr.mail.ne1.yahoo.com ([66.163.188.148]:35541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTBVr-0003t4-RH for 68698@debbugs.gnu.org; Thu, 25 Jan 2024 21:00:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706234399; bh=NTvGuyr/iHs2C0Eumf23jNA2hoJFrMJlmbTV02gdUEc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=dtY7y7DNqmwi/FsZDG2syTlYjWNvzDirnyPJm8HiTlf0MTlnkFTD7KlQ4Mql412kTtTVgZkZq4cIVeceSg/CLHx7DvPnP8jX2KXpwNARSvYVpqNn7Noj5RLLhOMCZ9qOedoHk/apotfhDLxjZxscLke4x66FsW2BYEB/zwc1wdu88cvXRGk2pxSdpLnhXDtNbjcWLlEjW2zIHj+U1BvlIc8/S502B7Qqz5bJr2TGL3iCGoqj6cdsafuBWp7rdV7XCM/mq6ijNDnlq2V4Ts0qz3sLieFeNxQDLj0TSyT1GJn/o1NUlBacytX3p8QqGB4whlPM7q8/HIU5gjEFx1AFFg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706234399; bh=lBrfUUGhrWwAo9GJ7dlhG04eVVoDaXBsMh1wH3vJbJO=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=SjOskRablP93+Zv+CiNC1jq5525d4yjx91RCfgtUYsnCdh4yJpg4OXxKmwtJ8O6mwaVX8M1PUKWSe8dlXFSF29aYftc0DgrPDERRKlzdRBLej0ETqwpSQZiqnFVv38I5/uI7ss0eydPG12HNu/sUCALa24R9DbCPWUk6cEOqlgcD+oyQmLv7s872cFMHxlocEEd+ouiZFecxKytxawBlLLS5fBSn9mJr8HABKQdfwdWiwAQmGKUWWsEwBHRmda9fWzDlx/zMqidreW7USOwt1qk9JE2flcosjKqoa2pLpPgR79stbsu5BKKJWOowyIQOGDcXmeGnP7FC1/Ic9B9FkA== X-YMail-OSG: LLYlcdUVM1nsOqCBNVJ8_jpS7G7M2qMbezvwuRCqgTkPss6mwyUnlZnnlN75Tmy 4w5ywCiifC9AoR_OGqkp0SLNrpwlYAIPJFPLR5I_5Ii1jh3F4FeSpqj1LqJxw5LcXiVl5zbDnqFP i1lVyP1N90KrH8nPOmAAeoWMnkh2zcDAr8kmw2DSV9z9Yhir_6PHPiJLBOAraUjXjGaVyGAIeSU0 u3NgknGc1gG2CQUzRSz7o9GNFcv_JaE1PasNmHroaDzstPEEEIglGsIelCx9uNtLBu69H41AwzYQ Gmklk9wR2lsk9VYZ7NLW6jTuiANTvVVN7UGdveI9PZnAdJhjZLpslasTuj7lxMEZSjTFqNzi9Syd g.IVMH60QpKyxEG78K6ZLDrtE6DnUSN8IxIyg60sp1YqMV1TTCf8JoF_0h357EbuqzkEuxw7X_2p a0BxyU4NfV4UGGiktrQPJnqUisV6q70LfwqVrne0j9ygR8A6RkADag42Uwbm0E2hMndY19SCvJxj tJeQKdGOjsjt0mvAnzSDM26buJhlRvMSk6wHZ7H0iVUCJNKONlv3R7e0bdfHGiD4OcpGYnjIN53V VN5TsYt6Y79EF0DoM97oInSospY_VYoHI2j5Sm9hSZ4KL0ruUEKfekvUrAqbbe2Elib14yr_9UVF DVLD3P1neTR9k5uFL2INYyNIXMxV72idIRDxwiJcYBA_eeGccj7e26LYv1tmKOQhMVUNK7RMPOHe _qLCJ5BR4Htoi97k4Nn4CZZtQa8X.b_TQ9Vcc31eTFdk4Pt1U5J.uqtoFAO.yIJgntO89F8NTxdo kdeCt3GpGt5q8bFef458mb05UlVDaJMoas7yS.jlSvXuCUGLUCDAC02bO0hOGlHqUW1GTh6bOkx0 jyrbORR2dlAd9cqxfDlGjnAuLV2UyTb2Imj9Nv_Pim3XCtJ7RicF2p0T1OYOWnB_BIEKv9QWGDJg 1DtFjYyMe4QCmg0GTewyykPti4i0pCsel28s.RK7.giVRslaImOaFWOURhxLBtEOR2pcdJQxnqfv SucxVKZZ8vxUykngZ_sXN81CQhnMTrF838M1x8PmpppEGyony9Foling_w9qZcdX1VuYGrqseEVg oqRJAWhRaRLs6O_2ynXcD0.UmFAT1B4dphI90.xlqN1YfZsLChZsmhcQ2LkHMgr8mXmJ3d.alu3. jsR.K8ycEsp2smjTtN4eBOtTeSs_07hlMbboeOmjmcFeugIRPhR96qbxjXE9xZI0wzrhIeXFVsQT jI3j0Uj.JQPv7KJgE4XY6lIdw1Z0L6ECSb3ModGnX81CAuX3GFrTWJ1n11Yx5omO4oo3dWfPVijH sTLDRLmBeCEs3dkxCzcscpiOE7jkmwHkezeGseYy4kRELxzb7WTMr8vGW_D8idAcBUJm2PJSJhO4 ylPRZzwldEcGGLxRPYdR7T6BHP_1LcL2YAhk3_WLd1RWWZwTcwBkPHWgTg7_5kGzIj5PV1gICbpN _K.biRyX3IkIDBp8tmYngRNV0GfvmEIAmd.c9muNIhpSTaJIz.VX1zR52FVYulrTlYB0vMRw0neF AEJkfGszYlqEhI0B34PirMkgwY5iOJydNIdd0BE6bT01hxUFaG8BQaHlgmH.PF0JmXNcFlr3eo7V c9OYL5VjyO6IxsEItTt5a1x.2q.3BGfZSHEr2q6do0AAipl9kkfurDF3kYsV0gZp7GwCSHMxOGZN 1Z.K1fdkJ.AxB.ZCTwOE5Uv3K83nHNE7X_I91drJH0hu3WFI2vEIu6yjg3gVXpCZ9JI_9yYNUwdj srEuLf9ntn_GcTPd6eTAxN3gNHODqNVDE5R0fYHYjt0s160jvMpW0uD.0ol1aO9lqLYojtFIm7kP QvG05yD4tNBZyFlPOcWT.Ne0rEnSqoet8rkN6YLm8cZrf8trLUxlV2wMQHXqS4DYFcqAadTJRdIx yxku8wBZglPJNZtp5eOF2n03gq8W2hOKrS7Tfo52Z2rr.vxXDdSWoX8SGtqBGSV8YgTsDUWFqV1C aEN.d78.dUglZ05lAdU1iycVAi.oIrMfPlNTNn247dFaAmlP5cFpKixhY0UrJfTbsAHRqRpzTA3B u19lbjrUpMfvEEVPrJxtfoTgyPZ5eCpX_nXTz4jTWX4y68s2XcrrImLQJUZ0EOXxv6gjtBnSLTKf cds_zxO.yUES9RR8IV1EBLaowzex4GGw3PTBAny.nkqIDuBV9LfPFtPKyyre9Ux9640WM_ch1BDV v6lFUq1dUnUhdmQ3FOApm_EMLoOzj3dsbR3X5JDZzkymr2NCS9is0VhxsDWmp_it1Terxbq8- X-Sonic-MF: X-Sonic-ID: 9a1ff831-32d5-4e9e-89b8-18a3d3699e84 Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Fri, 26 Jan 2024 01:59:59 +0000 Received: by hermes--production-sg3-677476f564-mglph (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f02fda470b1430bd52af5967039ff410; Fri, 26 Jan 2024 01:59:55 +0000 (UTC) From: Po Lu In-Reply-To: (Stefan Monnier's message of "Thu, 25 Jan 2024 10:41:03 -0500") References: <87sf2mp2ry.fsf@yahoo.com> <87r0i5o5ux.fsf@yahoo.com> Date: Fri, 26 Jan 2024 09:59:50 +0800 Message-ID: <87r0i4n9bd.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 763 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > The main reason is that it's painful to do it in `input-decode-map` > because it has to be done not just for `mouse-4/5/6/7` but for all > combinations of possible modifiers (shift, control, alt, meta, super, > hyper, double, triple, down), so that's like a couple thousand entries > we'd need to put in that map. I am quite loath to change the set of events generated by the X11 button event processing code, in view of the convoluted interaction between it, toolkits, and code further down the line. Any other solution would be preferable, such as perhaps: > Stefan "wishing we had more flexible keymaps (e.g. "procedural" > keymaps which can compute the binding for a given key)" From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jan 2024 02:28:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jared Finder Cc: Eli Zaretskii , 68698@debbugs.gnu.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.170623602617368 (code B ref 68698); Fri, 26 Jan 2024 02:28:03 +0000 Received: (at 68698) by debbugs.gnu.org; 26 Jan 2024 02:27:06 +0000 Received: from localhost ([127.0.0.1]:49773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTBvu-0004W4-1d for submit@debbugs.gnu.org; Thu, 25 Jan 2024 21:27:06 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:55868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTBvs-0004VY-6v for 68698@debbugs.gnu.org; Thu, 25 Jan 2024 21:27:04 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7123A100068; Thu, 25 Jan 2024 21:26:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706236011; bh=GNtjoT/Al7RbHbN4FqJSvjW99q82/aiK2oquym3O9mE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZKIQQWhxk5Skj3wLldgk3tv93ZJ+cZCXHPA0+yn2S9L2uHetNyHcb4IDS2zIHAwZ0 BaGanZkkhlQAqtee3sNP2o9Kdk8bzKPmhCn85yG1cU+TNevEklCy5xChLCZbPKurfi JkhNtmz6cIWJhOI4oIOZbhc467DFhXpU++sxnKiu8GBXp6xCXNh7ywXBf5w5IcM1Mi k1YcA9RBQ78RZIosm7RT8wfiQiiP94Ief9UIYRULY8oDMm1hGt9cJPDHoL8qdc7c4a vZuxzrJ4RY8PCE5tfM2tECC0PPs0x7pxx8zqeQFWlVXs21jjOvaOGrxGkfJ3vV+f9T lgBU92tta9TMQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5207810004C; Thu, 25 Jan 2024 21:26:51 -0500 (EST) Received: from pastel (unknown [45.72.206.68]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2653F1201D8; Thu, 25 Jan 2024 21:26:51 -0500 (EST) From: Stefan Monnier In-Reply-To: <6f61db136adaa613660edbae970840b9@finder.org> (Jared Finder's message of "Thu, 25 Jan 2024 17:41:20 -0800") Message-ID: References: <86o7d9dg5e.fsf@gnu.org> <6f61db136adaa613660edbae970840b9@finder.org> Date: Thu, 25 Jan 2024 21:26:49 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > A local run of HEAD (as of Jan 17, I'm at daec3e) with > "./configure --with-pgtk" has mouse-wheel-up-event set to wheel-down > because (featurep 'pgtk-win) is t, even with -nw on the command line. > Testing on Windows at Emacs 29.1 shows the same behavior. This has been changed on `master` around Jan 19. Now `mwheel.el` uses `wheel-up/down` unconditionally and `mouse-wheel-up/down-event` is only used for *other* events (defaults to `mouse-4/5`). > Also, I do not think xt-mouse knows how to generate mouse-6 or mouse-7 > events. I think to generate events beyond mouse-5, you need to test > against the 128 bit as well. I don't have mouse hardware to confirm > this behavior. I didn't both to check the code to see if that can happen (especially since there are various possible encodings coming from the terminal). The way wrote the code, it'll do the right thing if/when the rest of `xt-mouse` manages to generate those events, but indeed it might be the case that currently this will never happen. Stefan From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jan 2024 02:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Po Lu Cc: 68698@debbugs.gnu.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.170623622317853 (code B ref 68698); Fri, 26 Jan 2024 02:31:01 +0000 Received: (at 68698) by debbugs.gnu.org; 26 Jan 2024 02:30:23 +0000 Received: from localhost ([127.0.0.1]:49801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTBz4-0004dt-VB for submit@debbugs.gnu.org; Thu, 25 Jan 2024 21:30:23 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTBz2-0004de-Ju for 68698@debbugs.gnu.org; Thu, 25 Jan 2024 21:30:21 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0486410009F; Thu, 25 Jan 2024 21:30:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706236203; bh=/dLr47mWxA+JA0Xlz2IfeTjPX5uHmGitJ9xds5eMX6M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MMfDXidKRN/nTQqZgcpfp/Ctl/VRbZYiet06DbNdexCW/aHY89kO1VW7FOyLtKEq1 vX+xq/mb1whVlck0xe3sjcTce/MKJTHuq6P0LzQkMyf49flh/GXmW25RQqCSFqe2xf kHpco0hpYQhD77+TySUD9MOmA5KJRGT+bVL6PjOk361+0VU+2F/Hu2q46cuEURAiqc k5yriVcCKEIwXth7mZs1TJ2n8pNm0fP/CgwzM0s/Fqj2BXzzjNkJmmztcaKcAVdL7Y XGNRIAsjxUfOUh5DQiCQXGHjpEAVf3XDXHp0vobdghisUXIkgBnPgXIIPT/EsTutXK RXn+L4bCzSo4w== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E4F2A100054; Thu, 25 Jan 2024 21:30:03 -0500 (EST) Received: from pastel (unknown [45.72.206.68]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C19181208F7; Thu, 25 Jan 2024 21:30:03 -0500 (EST) From: Stefan Monnier In-Reply-To: <87r0i4n9bd.fsf@yahoo.com> (Po Lu's message of "Fri, 26 Jan 2024 09:59:50 +0800") Message-ID: References: <87sf2mp2ry.fsf@yahoo.com> <87r0i5o5ux.fsf@yahoo.com> <87r0i4n9bd.fsf@yahoo.com> Date: Thu, 25 Jan 2024 21:30:02 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.091 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Po Lu [2024-01-26 09:59:50] wrote: > Stefan Monnier writes: >> The main reason is that it's painful to do it in `input-decode-map` >> because it has to be done not just for `mouse-4/5/6/7` but for all >> combinations of possible modifiers (shift, control, alt, meta, super, >> hyper, double, triple, down), so that's like a couple thousand entries >> we'd need to put in that map. > > I am quite loath to change the set of events generated by the X11 button > event processing code, in view of the convoluted interaction between it, > toolkits, and code further down the line. Any other solution would be > preferable, such as perhaps: OK, will keep this in mind. The current bug#68698 is only suggesting changing `xt-mouse.el`, tho, so we can leave the X11 case for later (or for never, since we may also decide to let it disappear into the past as XInput2 becomes the norm). Stefan From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Jared Finder Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jan 2024 05:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 68698@debbugs.gnu.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.17062453632181 (code B ref 68698); Fri, 26 Jan 2024 05:03:02 +0000 Received: (at 68698) by debbugs.gnu.org; 26 Jan 2024 05:02:43 +0000 Received: from localhost ([127.0.0.1]:49884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTEMV-0000Z6-9L for submit@debbugs.gnu.org; Fri, 26 Jan 2024 00:02:43 -0500 Received: from greenhill.hpalace.com ([192.155.80.58]:33920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTEMT-0000Yy-FD for 68698@debbugs.gnu.org; Fri, 26 Jan 2024 00:02:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1706245354; bh=IDRHX7DbauT+ir+FhdVC1Ky6RaeenLBsQ8IqgSlJwBE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Xy9RrrJ6B/FYQC+OSi6zCDJ1u96aoiYAtvqdd66oTe0K6+nuZ9nX50AUVCxQNyR5p 0f8mKBMLhdpW/eGC1iGCGYv/RGa4NcXXXUzAOgXMQbND87coVpefhtjcty/NOCrwJk GzsD8lsgv/N/dwrXx6OE2Tj2Ukd3GFhsfx87eZQu63ravI0EbnQmPSL3vGTSj7/AtV bXia7coWHuFjUYWbCimxKCiC0MajqgCwSSNvJqxWPvYOuzh03bM37xLbVTbGdHDAsi oXvq5sniLfw2Uqaix/j4fx4w6vOJ08y1BoItinrvMDGDaQAjoqxRqA0qB3IHKW90/d YE4Mz/PWV0ccQ== Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 44AB1A68; Fri, 26 Jan 2024 05:02:34 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 25 Jan 2024 21:02:34 -0800 From: Jared Finder In-Reply-To: References: <86o7d9dg5e.fsf@gnu.org> <6f61db136adaa613660edbae970840b9@finder.org> Message-ID: <57c4e937bfae8fcfa5461f8fd1237f8a@finder.org> X-Sender: jared@finder.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2024-01-25 18:26, Stefan Monnier wrote: >> A local run of HEAD (as of Jan 17, I'm at daec3e) with >> "./configure --with-pgtk" has mouse-wheel-up-event set to wheel-down >> because (featurep 'pgtk-win) is t, even with -nw on the command line. >> Testing on Windows at Emacs 29.1 shows the same behavior. > > This has been changed on `master` around Jan 19. Now `mwheel.el` uses > `wheel-up/down` unconditionally and `mouse-wheel-up/down-event` is only > used for *other* events (defaults to `mouse-4/5`). > >> Also, I do not think xt-mouse knows how to generate mouse-6 or mouse-7 >> events. I think to generate events beyond mouse-5, you need to test >> against the 128 bit as well. I don't have mouse hardware to confirm >> this behavior. > > I didn't both to check the code to see if that can happen (especially > since there are various possible encodings coming from the terminal). > The way wrote the code, it'll do the right thing if/when the rest of > `xt-mouse` manages to generate those events, but indeed it might be the > case that currently this will never happen. Ah great! Then I have no concerns about this patch. -- MJF From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jan 2024 07:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 68698@debbugs.gnu.org, jared@finder.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.170625580722042 (code B ref 68698); Fri, 26 Jan 2024 07:57:01 +0000 Received: (at 68698) by debbugs.gnu.org; 26 Jan 2024 07:56:47 +0000 Received: from localhost ([127.0.0.1]:50181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTH4w-0005jS-K4 for submit@debbugs.gnu.org; Fri, 26 Jan 2024 02:56:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTH4u-0005jG-OO for 68698@debbugs.gnu.org; Fri, 26 Jan 2024 02:56:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTH4h-0001rp-1F; Fri, 26 Jan 2024 02:56:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=rZNLn5AdbZRYPKo05lhqI1uYq49CG0ayhtDHRIbz7lM=; b=TDrsjPsZyiL8Nq//Aq2+ 0ggxTSATL8tsa/a8rM/xluKowcREfy2kTvp0ZD0nvdwmn9UfzOTUWgZhJHkwYa++MKpplCH9PlaSz 4cXh+0y90u8tzJmYDk7W+cyUFoQYOn7CtBmCDpLkCFR2k5J9yLl8Gc0O2skm0jZ7vyPVUoh4fd/8T jXAnrZZivvzOHdAv7HLOpgmVvvrRMdv+vGMvEQ+i+0Cu6OX+STWxOlf23u3QZmX9hIPwflTfFh2fD +Y77dYz5Bp4ttQ34cnEFmxl+XQ+7/QyxcJ/78l5/vFCzRvKanmwhIe9Byt8BP6RCxYZJCnd0bE9HU /F6P1RC3zggXWQ==; Date: Fri, 26 Jan 2024 09:56:23 +0200 Message-Id: <86bk98bk9k.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Monnier on Thu, 25 Jan 2024 21:26:49 -0500) References: <86o7d9dg5e.fsf@gnu.org> <6f61db136adaa613660edbae970840b9@finder.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eli Zaretskii , 68698@debbugs.gnu.org > Date: Thu, 25 Jan 2024 21:26:49 -0500 > > > A local run of HEAD (as of Jan 17, I'm at daec3e) with > > "./configure --with-pgtk" has mouse-wheel-up-event set to wheel-down > > because (featurep 'pgtk-win) is t, even with -nw on the command line. > > Testing on Windows at Emacs 29.1 shows the same behavior. > > This has been changed on `master` around Jan 19. Now `mwheel.el` uses > `wheel-up/down` unconditionally and `mouse-wheel-up/down-event` is only > used for *other* events (defaults to `mouse-4/5`). Was this reflected in the documentation? The ELisp Reference manual still says The ‘wheel-up’ and ‘wheel-down’ events are generated only on some kinds of systems. On other systems, other events like ‘mouse-4’ and ‘mouse-5’ are used instead. Portable code should handle both ‘wheel-up’ and ‘wheel-down’ events as well as the events specified in the variables ‘mouse-wheel-up-event’ and ‘mouse-wheel-down-event’, defined in ‘mwheel.el’. Beware that for historical reasons the ‘mouse-wheel-_up_-event’ is the variable that holds an event that should be handled similarly to ‘wheel-_down_’ and vice versa. Is that still correct and accurate? (And what about a similar issue with wheel-left/right?). From unknown Sun Jun 22 07:48:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jan 2024 13:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 68698@debbugs.gnu.org, jared@finder.org Received: via spool by 68698-submit@debbugs.gnu.org id=B68698.170627428110291 (code B ref 68698); Fri, 26 Jan 2024 13:05:02 +0000 Received: (at 68698) by debbugs.gnu.org; 26 Jan 2024 13:04:41 +0000 Received: from localhost ([127.0.0.1]:50651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTLsv-0002fv-Cn for submit@debbugs.gnu.org; Fri, 26 Jan 2024 08:04:41 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTLss-0002fg-Sy for 68698@debbugs.gnu.org; Fri, 26 Jan 2024 08:04:39 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B0CB2442207; Fri, 26 Jan 2024 08:04:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706274265; bh=qLUOQvMgooS4SF/sQzPGRW5e1IssNmNQsR/Qu2HOlVQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RxfRNGItLx2dsnDADGCKENoylJzdrdXDk7JAkZxIFNnvzzn/dSehP4hsrEqJ6iHiX hvPh7/UiTo26mjDcLxILsvmJI4/PCrx/ESPsJP+GQdcrqAdGzNL33AU6utyqs61k0L ZY+C6KA6MuPdHHh0Wi1ElqTI5z+70bWH+XBLZxN3tVrGTAVZtHyLY86ylNOZw0DKAh HM18YWuVC7ZUGvg78KS2W7upmqp03nQgk6Z+jCNPgBxsPOFg+EDBZE9Z4LilmIpDv6 Lv1HJ6xwF+l5BDEYLrd4Z7orHuiAKW0qmNXPyoPyrIo9Vcx6yE7N7sAlvHmGu+kTZ4 GGjyqo8sx5S8Q== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 55506442200; Fri, 26 Jan 2024 08:04:25 -0500 (EST) Received: from pastel (unknown [45.72.206.68]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2A0C8120483; Fri, 26 Jan 2024 08:04:25 -0500 (EST) From: Stefan Monnier In-Reply-To: <86bk98bk9k.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Jan 2024 09:56:23 +0200") Message-ID: References: <86o7d9dg5e.fsf@gnu.org> <6f61db136adaa613660edbae970840b9@finder.org> <86bk98bk9k.fsf@gnu.org> Date: Fri, 26 Jan 2024 08:04:17 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > A local run of HEAD (as of Jan 17, I'm at daec3e) with >> > "./configure --with-pgtk" has mouse-wheel-up-event set to wheel-down >> > because (featurep 'pgtk-win) is t, even with -nw on the command line. >> > Testing on Windows at Emacs 29.1 shows the same behavior. >>=20 >> This has been changed on `master` around Jan 19. Now `mwheel.el` uses >> `wheel-up/down` unconditionally and `mouse-wheel-up/down-event` is only >> used for *other* events (defaults to `mouse-4/5`). > > Was this reflected in the documentation? The ELisp Reference manual > still says > > The =E2=80=98wheel-up=E2=80=99 and =E2=80=98wheel-down=E2=80=99 even= ts are generated only on some > kinds of systems. On other systems, other events like =E2=80=98mous= e-4=E2=80=99 > and =E2=80=98mouse-5=E2=80=99 are used instead. Portable code shoul= d handle both > =E2=80=98wheel-up=E2=80=99 and =E2=80=98wheel-down=E2=80=99 events a= s well as the events specified > in the variables =E2=80=98mouse-wheel-up-event=E2=80=99 and > =E2=80=98mouse-wheel-down-event=E2=80=99, defined in =E2=80=98mwheel= .el=E2=80=99. Beware that for > historical reasons the =E2=80=98mouse-wheel-_up_-event=E2=80=99 is t= he variable > that holds an event that should be handled similarly to > =E2=80=98wheel-_down_=E2=80=99 and vice versa. > > Is that still correct and accurate? (And what about a similar issue > with wheel-left/right?). Yup, before Jan 19 the text was different :-) Stefan From unknown Sun Jun 22 07:48:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stefan Monnier Subject: bug#68698: closed (Re: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down`) Message-ID: References: X-Gnu-PR-Message: they-closed 68698 X-Gnu-PR-Package: emacs Reply-To: 68698@debbugs.gnu.org Date: Sun, 28 Jan 2024 23:53:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1706485982-22720-1" This is a multi-part message in MIME format... ------------=_1706485982-22720-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #68698: 30.0.50; Making xt-mouse emit `wheel-up/down` which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 68698@debbugs.gnu.org. --=20 68698: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68698 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1706485982-22720-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 68698-done) by debbugs.gnu.org; 28 Jan 2024 23:52:25 +0000 Received: from localhost ([127.0.0.1]:58673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUEwr-0005tf-7b for submit@debbugs.gnu.org; Sun, 28 Jan 2024 18:52:25 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUEwp-0005tS-VR for 68698-done@debbugs.gnu.org; Sun, 28 Jan 2024 18:52:24 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CE3DB10007D; Sun, 28 Jan 2024 18:52:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706485924; bh=yLKyWSMz6vgZVDjFU20oV0Ms12uN0a/r83QSPiUpYqc=; h=From:To:Subject:In-Reply-To:References:Date:From; b=EO+yebRauLKty+0oOr77uCJLHVzoXLWAt/6W4/WLVZN/+kix6wCQNDGbyVMAv5g12 G9blt0LbyFgMSYX/3x+UUPAuDi1tDns3ab5+7j98+xXHLzshv9utGQnCJbtkvJwavc YaE6Bxx+2B5RM0zLWtOT0ofEFW1IaJ8j/8B1BH0i4V8VMHSkJw+v7vcPC/D+KaLO0I OPXammDfrCgwfBOj+3tr/Hozv25qmtJiwRWD/DS4l2ML71gn70yMWyfRf9lf01746B C4swJknawQpgKlzwTn6vswbYMWE5CWxqZHxtzUKA4Ov5HbH+vaxzSuJyTczJ8P1nRj BazJNQ2irYSxA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id ACBA910001D; Sun, 28 Jan 2024 18:52:04 -0500 (EST) Received: from alfajor (unknown [45.72.206.68]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8198F120A6F; Sun, 28 Jan 2024 18:52:04 -0500 (EST) From: Stefan Monnier To: 68698-done@debbugs.gnu.org Subject: Re: bug#68698: 30.0.50; Making xt-mouse emit `wheel-up/down` In-Reply-To: (Stefan Monnier's message of "Wed, 24 Jan 2024 15:31:32 -0500") Message-ID: References: Date: Sun, 28 Jan 2024 18:52:02 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.124 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68698-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Pushed to `master`, closing, Stefan ------------=_1706485982-22720-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Jan 2024 20:33:16 +0000 Received: from localhost ([127.0.0.1]:46695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSjvw-00030l-39 for submit@debbugs.gnu.org; Wed, 24 Jan 2024 15:33:16 -0500 Received: from lists.gnu.org ([2001:470:142::17]:41756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSjvu-00030M-0L for submit@debbugs.gnu.org; Wed, 24 Jan 2024 15:33:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSjvi-0002sb-C7 for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 15:33:02 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSjvg-0006MF-5C for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 15:33:01 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B655F10007D for ; Wed, 24 Jan 2024 15:32:58 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706128377; bh=EP+r4wFH0r8wzH646aKpYZxlJF6bf319kXKLV9S3F4g=; h=From:To:Subject:Date:From; b=BNoJ4xEren8An9hq/znHzZwdlb3B+S6Dfdf9+VTY/zvjA8VbWHpobueLKpzAR0oiH CZ1M8w4BQvTaAoVuhsoLoK7352tiuHsObrtp48pttMEY7DNmWWbtISoSAOOv+CRYiI TjBnEXcxxzNufcaD5IEc9BSFVfr19lUeSjKWA78DtxjfzfmCCHcrPZXpmy7LEPuWsl 2Lkbhl8VeecNFcQKsQX9zR1VbyUDv1qN69R4to5jd2HuJNe6VeMRAsjsZmEJ/Ss3Cm ArMI7qsVxyFURezKEDo3WTrvxJFSakDm1cvASpdaPVn4NGRZt88C3QJy6mU4wQyva3 xZzXWCdBG7gig== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AA1B810001D for ; Wed, 24 Jan 2024 15:32:57 -0500 (EST) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9D962120BF6 for ; Wed, 24 Jan 2024 15:32:57 -0500 (EST) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Making xt-mouse emit `wheel-up/down` X-Debbugs-Cc: Date: Wed, 24 Jan 2024 15:31:32 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.252 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Package: Emacs Version: 30.0.50 Currently, wheel-up/down events are generated in most setups instead of the old mouse-4/5. There are still two exceptions: - X11 builds not using XInput2. - text terminals. The attached patch intends to fix the second bullet. Text terminals themselves only give us info equivalent to `mouse-4/5` and don't actually tell us that it's a wheel movement, but we can still turn those things into `wheel-up/down`. This is related to bug#49803. The second step would be to do something similar for the non-XInput2 X11 build: make it generate `wheel-up/down` events according to `mouse-wheel-down/up-event` settings. Then packages like `completion-preview` and `mwheel` won't need to pay attention to the (confusingly named) `mouse-wheel-down/up-event` vars any more. Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=xtmouse.patch diff --git a/lisp/mwheel.el b/lisp/mwheel.el index 53042085bf6..66a1fa1a706 100644 --- a/lisp/mwheel.el +++ b/lisp/mwheel.el @@ -59,7 +59,7 @@ mouse-wheel-change-button (defvar mouse-wheel-obey-old-style-wheel-buttons t "If non-nil, treat mouse-4/5/6/7 events as mouse wheel events. These are the event names used historically in X11 before XInput2. -They are sometimes generated by things like `xterm-mouse-mode' as well.") +They are sometimes generated by things like text-terminals as well.") (defcustom mouse-wheel-down-event (if mouse-wheel-obey-old-style-wheel-buttons 'mouse-4) diff --git a/lisp/xt-mouse.el b/lisp/xt-mouse.el index cd00467f14f..fcc0db1d9eb 100644 --- a/lisp/xt-mouse.el +++ b/lisp/xt-mouse.el @@ -40,6 +40,8 @@ ;;; Code: +(require 'mwheel) + (defvar xterm-mouse-debug-buffer nil) (defun xterm-mouse-translate (_event) @@ -193,6 +195,12 @@ xterm-mouse--read-number-from-terminal (cons n c)) (cons (- (setq c (xterm-mouse--read-coordinate)) 32) c)))) +(defun xterm-mouse--same-button-p (event btn) + (and (symbolp event) + (string-prefix-p "mouse-" (symbol-name event)) + (eq btn (car (read-from-string (symbol-name event) + (length "mouse-")))))) + ;; XTerm reports mouse events as ;; in default mode, and ;; ";" ";" <"M" or "m"> in extended mode. @@ -231,12 +239,24 @@ xterm-mouse--read-event-sequence ;; event: assume, that the last button was button 1. (t 1))) (sym (if move 'mouse-movement - (intern (concat (if ctrl "C-" "") - (if meta "M-" "") - (if shift "S-" "") - (if down "down-" "") - "mouse-" - (number-to-string btn)))))) + (intern + (concat + (if ctrl "C-" "") + (if meta "M-" "") + (if shift "S-" "") + (if down "down-" "") + (cond + ;; BEWARE: `mouse-wheel-UP-event' corresponds to + ;; `wheel-DOWN' events and vice versa!! + ((xterm-mouse--same-button-p mouse-wheel-down-event btn) + "wheel-up") + ((xterm-mouse--same-button-p mouse-wheel-up-event btn) + "wheel-down") + ((xterm-mouse--same-button-p mouse-wheel-left-event btn) + "wheel-left") + ((xterm-mouse--same-button-p mouse-wheel-right-event btn) + "wheel-right") + (t (format "mouse-%d" btn)))))))) (list sym (1- x) (1- y)))) (defun xterm-mouse--set-click-count (event click-count) --=-=-=-- ------------=_1706485982-22720-1--