GNU bug report logs - #68696
[PATCH] gnu: Add guile-lmdb.

Previous Next

Full log

Message #11 received at 68696 <at> debbugs.gnu.org (full text, mbox):

From: Artyom Bologov <mail <at> aartaka.me>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 68696 <at> debbugs.gnu.org, Artyom Bologov <mail <at> aartaka.me>
Subject: Re: [bug#68696] [PATCH] gnu: Add guile-lmdb.
Date: Fri, 26 Jan 2024 19:50:07 +0400

[Message part 1 (text/plain, inline)]

Hi Oleg,

Thanks for your patience in this review! I addressed most of comments
and ran guix lint on the installed package (not sure how exactly that
should work, but it didn't error at least). Find the new patch attached.

[0001-gnu-Add-guile-lmdb.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

> You may simplify this part a little by using G-Expressions:

That's on my learning TODO list, haven't got to them yet!

> You may drop \n here.

Did it out of pure mimicking for other packages. Nice that I don't need
to cargo-cult it 😃

Thanks,
--
Artyom.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.