Subject: bug#68689: 30.0.50; minibuffer-visible-completions should change completion-show-help

From: Spencer Baugh <[email-masked]>
Date: Wed, 24 Jan 2024 12:22:00 -0500

Juri Linkov <[email-masked]> writes:

>> completion-show-help shows some useful help for new users.
>> However, it suggests suboptimal bindings when
>> minibuffer-visible-completions is on.  minibuffer-visible-completions
>> should change the help shown by completion-show-help.
>>
>> A patch to do this will follow.
>
> It's hard to see what your patch will output.
> Could you please send the outputs of `emacs -Q`
> to compare before and after your patch.

With minibuffer-visible-completions=nil, there's no change.

With minibuffer-visible-completions=t, before my patch:

Click or type M-RET on a completion to select it.
Type M-<down> or M-<up> to move point between completions.

After my patch:

Click or type RET on a completion to select it.
Type <right>, <left>, <down>, <up> to move point between completions.