From unknown Sat Jun 21 12:25:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68689: 30.0.50; minibuffer-visible-completions should change completion-show-help Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 68689@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17061125654559 (code B ref -1); Wed, 24 Jan 2024 16:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Jan 2024 16:09:25 +0000 Received: from localhost ([127.0.0.1]:46356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSfob-0001BT-89 for submit@debbugs.gnu.org; Wed, 24 Jan 2024 11:09:25 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSfoZ-0001BE-7G for submit@debbugs.gnu.org; Wed, 24 Jan 2024 11:09:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSfoO-0003lC-4M for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 11:09:12 -0500 Received: from mxout6.mail.janestreet.com ([64.215.233.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSfoM-0005K8-EP for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 11:09:11 -0500 From: Spencer Baugh Date: Wed, 24 Jan 2024 11:09:08 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1706112549; bh=Li84/ZowrHMYMWRoG+roO5qrSuUk8rgIouxDOELXncM=; h=From:To:Subject:Date; b=vDdQKoSFzJvDlB3PuwDM/JPJ0v9OYADKyzpi8ZhAsIL/63uLGmPv3o+XAeqrgdcph GNlL2IkK71HLjS+0RDbaA+VEF5BRpJZ7aKvdVictBioaLfLhyYu6fHCpT7UW5HixWN 7qt1eIJdrB9Ixhpil0U0biOMFw8u01OV09k65lmOVsKEH4xl1TOCQv6Gc7unvD0kU5 SUHzCwlUinot0zVANsLOk96qpxY+aF8OOWsGC1z2F8lO84aL41WeCuJtfFD1C84jQk 4o9Ati6ik38oFwlds4G6u//UMWUJRL5B+/FcRTUnsvh3Wfw25TjVz2qBeI5ZQH/XYA rM9n8cj+INqNA== Received-SPF: pass client-ip=64.215.233.21; envelope-from=sbaugh@janestreet.com; helo=mxout6.mail.janestreet.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) completion-show-help shows some useful help for new users. However, it suggests suboptimal bindings when minibuffer-visible-completions is on. minibuffer-visible-completions should change the help shown by completion-show-help. A patch to do this will follow. In GNU Emacs 30.0.50 (build 20, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2023-12-27 built on igm-qws-u22796a Repository revision: b9c0ce0a400f18e1bba4e3491c94994d73ef9405 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Rocky Linux 8.9 (Green Obsidian) Configured using: 'configure -C 'CFLAGS=-O0 -g3' --with-gif=ifavailable --with-x-toolkit=lucid' Configured features: CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 64909 12153) (symbols 48 9546 0) (strings 32 22818 1610) (string-bytes 1 676937) (vectors 16 10394) (vector-slots 8 158028 13136) (floats 8 40 19) (intervals 56 262 0) (buffers 984 10)) From unknown Sat Jun 21 12:25:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68689: 30.0.50; minibuffer-visible-completions should change completion-show-help Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 68689@debbugs.gnu.org Received: via spool by 68689-submit@debbugs.gnu.org id=B68689.17061126894838 (code B ref 68689); Wed, 24 Jan 2024 16:12:02 +0000 Received: (at 68689) by debbugs.gnu.org; 24 Jan 2024 16:11:29 +0000 Received: from localhost ([127.0.0.1]:46362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSfqa-0001Fw-SN for submit@debbugs.gnu.org; Wed, 24 Jan 2024 11:11:29 -0500 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:38229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSfqY-0001Fg-L6 for 68689@debbugs.gnu.org; Wed, 24 Jan 2024 11:11:27 -0500 From: Spencer Baugh In-Reply-To: (Spencer Baugh's message of "Wed, 24 Jan 2024 11:09:08 -0500") References: Date: Wed, 24 Jan 2024 11:11:16 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1706112676; bh=aMIVWqoRjRAwEV9+sUZgKXIzW+v9HtJE3WANPmIe6aM=; h=From:To:Subject:In-Reply-To:References:Date; b=e5igTIKTs7RTYfPSnwsJjb8IZCVRzktiTXt7Pm1BuwlBBqqJdaOxcMKU4LTW9eCn/ wpqosUN42cy2PE/M6B1iUTLiRFnTT3JlDRt7SON6o5u9QdbX6Ll3jKTLXjQ5gUrpMH FQxPN34150/DfUH5jFUrvHthuVrbJHM5OtMeYIhwdLhuA4v7b0xgHe50XXfzZ8px76 XiS4xyv55MOXVixvVCSqPZ3P3QY6taLfdCD7CcJmFG/LzvTOPsbsYxLvQubOJPJluT +KDJYDJ/ZykRZ7p03Fdk8MJz/t4B1lS/YN8U+MPcGgwrvvoykmrzaPuotIrqjB400A NyqtVR70peV0Q== X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Patch to fix --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Update-minibuffer-show-help-based-on-minibuffer-visi.patch >From c70736c52262cacb905ed1e564b2335a3c87f5b4 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Wed, 24 Jan 2024 11:10:40 -0500 Subject: [PATCH] Update minibuffer-show-help based on minibuffer-visible-completions minibuffer-visible-completions makes some more convenient bindings available, but the help shown by minibuffer-show-help wasn't suggesting them. Now it is. * lisp/simple.el (completion-setup-function): Change help text when minibuffer-visible-completions is non-nil. (bug#68689) --- lisp/simple.el | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index 35fd76b8d1a..23019dd1138 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -10232,13 +10232,27 @@ completion-setup-function ;; Maybe insert help string. (when completion-show-help (goto-char (point-min)) - (insert (substitute-command-keys - (if (display-mouse-p) - "Click or type \\[minibuffer-choose-completion] on a completion to select it.\n" - "Type \\[minibuffer-choose-completion] on a completion to select it.\n"))) - (insert (substitute-command-keys - "Type \\[minibuffer-next-completion] or \\[minibuffer-previous-completion] \ -to move point between completions.\n\n")))))) + (if minibuffer-visible-completions + (let ((helps + (with-current-buffer (window-buffer (active-minibuffer-window)) + (list + (substitute-command-keys + (if (display-mouse-p) + "Click or type \\[minibuffer-choose-completion-or-exit] on a completion to select it.\n" + "Type \\[minibuffer-choose-completion-or-exit] on a completion to select it.\n")) + (substitute-command-keys + "Type \\[minibuffer-next-completion], \\[minibuffer-previous-completion], \ +\\[minibuffer-next-line-completion], \\[minibuffer-previous-line-completion] \ +to move point between completions.\n\n"))))) + (dolist (help helps) + (insert help))) + (insert (substitute-command-keys + (if (display-mouse-p) + "Click or type \\[minibuffer-choose-completion] on a completion to select it.\n" + "Type \\[minibuffer-choose-completion] on a completion to select it.\n"))) + (insert (substitute-command-keys + "Type \\[minibuffer-next-completion] or \\[minibuffer-previous-completion] \ +to move point between completions.\n\n"))))))) (add-hook 'completion-setup-hook #'completion-setup-function) -- 2.39.3 --=-=-=-- From unknown Sat Jun 21 12:25:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68689: 30.0.50; minibuffer-visible-completions should change completion-show-help Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Spencer Baugh Cc: 68689@debbugs.gnu.org Received: via spool by 68689-submit@debbugs.gnu.org id=B68689.17061150429302 (code B ref 68689); Wed, 24 Jan 2024 16:51:02 +0000 Received: (at 68689) by debbugs.gnu.org; 24 Jan 2024 16:50:42 +0000 Received: from localhost ([127.0.0.1]:46432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSgSY-0002Py-3y for submit@debbugs.gnu.org; Wed, 24 Jan 2024 11:50:42 -0500 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]:33457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSgSU-0002PT-5t for 68689@debbugs.gnu.org; Wed, 24 Jan 2024 11:50:38 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 797C71C000C; Wed, 24 Jan 2024 16:50:25 +0000 (UTC) From: Juri Linkov In-Reply-To: (Spencer Baugh's message of "Wed, 24 Jan 2024 11:09:08 -0500") Organization: LINKOV.NET References: Date: Wed, 24 Jan 2024 18:47:41 +0200 Message-ID: <86le8e3cgi.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > completion-show-help shows some useful help for new users. > However, it suggests suboptimal bindings when > minibuffer-visible-completions is on. minibuffer-visible-completions > should change the help shown by completion-show-help. > > A patch to do this will follow. It's hard to see what your patch will output. Could you please send the outputs of `emacs -Q` to compare before and after your patch. From unknown Sat Jun 21 12:25:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68689: 30.0.50; minibuffer-visible-completions should change completion-show-help Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 68689@debbugs.gnu.org Received: via spool by 68689-submit@debbugs.gnu.org id=B68689.170611693323293 (code B ref 68689); Wed, 24 Jan 2024 17:23:02 +0000 Received: (at 68689) by debbugs.gnu.org; 24 Jan 2024 17:22:13 +0000 Received: from localhost ([127.0.0.1]:46511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSgx2-00063c-Tq for submit@debbugs.gnu.org; Wed, 24 Jan 2024 12:22:13 -0500 Received: from mxout1.mail.janestreet.com ([38.105.200.78]:43563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSgx1-00063F-Bf for 68689@debbugs.gnu.org; Wed, 24 Jan 2024 12:22:11 -0500 From: Spencer Baugh In-Reply-To: <86le8e3cgi.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 24 Jan 2024 18:47:41 +0200") References: <86le8e3cgi.fsf@mail.linkov.net> Date: Wed, 24 Jan 2024 12:22:00 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1706116920; bh=FWRTqP3SDFdKAloRT55RGBlgFwaemD3cJYmL/DxxdlA=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=0YCRr+xqrJHqJsBRpnQLCmK38SXgy/Tc7I/aEsDIcfC55A33vEBbXzJXVwg6dP6q8 bIfU36mv3o31VbWOblmTD8rCdvctdfn9PIudNEJk9D4wUDvLEsAmW44IZD6RxTHYGU ZirUo21ZGZvAxn5C7FyMWwMVRYMFgLvP77s8HKXvvMho6egPlqjJQtM9TKWAmCYqZO F4Tp4yPeBhPUuSFdv6ihwIH26yat4Rfwn2mDS3UnQq5uKXgyTeVxOegWqqLObneaGm NX4z0rXOWOOs43MQFNM1agm8s4V4wYQy/UIWbexlrZrE9FWHA8n3qizweZaUJJw0DQ 6//aL8aobZt5Q== X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> completion-show-help shows some useful help for new users. >> However, it suggests suboptimal bindings when >> minibuffer-visible-completions is on. minibuffer-visible-completions >> should change the help shown by completion-show-help. >> >> A patch to do this will follow. > > It's hard to see what your patch will output. > Could you please send the outputs of `emacs -Q` > to compare before and after your patch. With minibuffer-visible-completions=nil, there's no change. With minibuffer-visible-completions=t, before my patch: Click or type M-RET on a completion to select it. Type M- or M- to move point between completions. After my patch: Click or type RET on a completion to select it. Type , , , to move point between completions. From unknown Sat Jun 21 12:25:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68689: 30.0.50; minibuffer-visible-completions should change completion-show-help Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 07:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Spencer Baugh Cc: 68689@debbugs.gnu.org Received: via spool by 68689-submit@debbugs.gnu.org id=B68689.17061691148545 (code B ref 68689); Thu, 25 Jan 2024 07:52:02 +0000 Received: (at 68689) by debbugs.gnu.org; 25 Jan 2024 07:51:54 +0000 Received: from localhost ([127.0.0.1]:47225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSuWf-0002Dk-Mz for submit@debbugs.gnu.org; Thu, 25 Jan 2024 02:51:53 -0500 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:44985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSuWc-0002DF-Uf; Thu, 25 Jan 2024 02:51:51 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3B0D940004; Thu, 25 Jan 2024 07:51:35 +0000 (UTC) From: Juri Linkov In-Reply-To: (Spencer Baugh's message of "Wed, 24 Jan 2024 12:22:00 -0500") Organization: LINKOV.NET References: <86le8e3cgi.fsf@mail.linkov.net> Date: Thu, 25 Jan 2024 09:50:16 +0200 Message-ID: <86r0i57sxz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 68689 30.0.50 thanks > With minibuffer-visible-completions=nil, there's no change. > > With minibuffer-visible-completions=t, before my patch: > > Click or type M-RET on a completion to select it. > Type M- or M- to move point between completions. > > After my patch: > > Click or type RET on a completion to select it. > Type , , , to move point between completions. Thanks, this looks nice. Now pushed to master and closed.