GNU bug report logs - #68678
29.1; package-recompile-all should skip system packages in package-directory-list

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68678: closed (29.1; package-recompile-all should skip system
 packages in package-directory-list)
Date: Sun, 11 Feb 2024 21:54:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 11 Feb 2024 21:52:45 +0000
with message-id <87sf1ysm6q.fsf <at> posteo.net>
and subject line Re: bug#68678: 29.1; package-recompile-all should skip system packages in package-directory-list
has caused the debbugs.gnu.org bug report #68678,
regarding 29.1; package-recompile-all should skip system packages in package-directory-list
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68678: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68678
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Allen Li <darkfeline <at> felesatra.moe>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.1; package-recompile-all should skip system packages in
 package-directory-list
Date: Tue, 23 Jan 2024 15:48:35 -0800

[Message part 3 (text/plain, inline)]

package-recompile-all currently attempts to recompile all packages,
including the system packages listed in package-directory-list.

System packages are generally byte compiled as part of installation, and
are not writeable by normal users.

package-recompile-all attempts to recompile these, which will almost
certainly error out due to this.

It would be better if package-recompile-all only tries user installed
packages (in package-user-dir), which are more likely to need
recompilation.  Perhaps as a prefix arg option?

In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37,
 cairo version 1.16.0) of 2023-09-03, modified by Debian built on
 kokoro-ubuntu
System Description: Debian GNU/Linux rodete

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Allen Li <darkfeline <at> felesatra.moe>
Cc: 68678-done <at> debbugs.gnu.org
Subject: Re: bug#68678: 29.1; package-recompile-all should skip system
 packages in package-directory-list
Date: Sun, 11 Feb 2024 21:52:45 +0000

Philip Kaludercic <philipk <at> posteo.net> writes:

> Allen Li <darkfeline <at> felesatra.moe> writes:
>
>> On Sun, Jan 28, 2024 at 1:40 PM Philip Kaludercic <philipk <at> posteo.net>
>> wrote:
>>>
>>> Allen Li <darkfeline <at> felesatra.moe> writes:
>>> >
>>> > That works for me, though it's possible that someone may want errors
>>> > recompiling user packages surfaced directly.
>>>
>>> That is why I used `with-demoted-errors', which propagates errors if
>>> `debug-on-error' is non-nil.  Or do you mean permanently and
>>> specifically related to this issue, e.g. in form of a user option.
>>
>> My bad, yes, `with-demoted-errors' sounds fine to me.  At the risk of
>> repeating myself,
>> I don't have a use case for surfacing the errors, but I think some
>> other users might.
>
> OK, then this is the patch I propse:
>
>
>
> Any objections?

As there haven't been any comment, I have pushed the patch to master.  Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.