From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 23 18:49:05 2024 Received: (at submit) by debbugs.gnu.org; 23 Jan 2024 23:49:05 +0000 Received: from localhost ([127.0.0.1]:44128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSQVs-0007Mu-Tk for submit@debbugs.gnu.org; Tue, 23 Jan 2024 18:49:05 -0500 Received: from lists.gnu.org ([2001:470:142::17]:33428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSQVr-0007MO-9O for submit@debbugs.gnu.org; Tue, 23 Jan 2024 18:49:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSQVg-0000qB-Kq for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 18:48:52 -0500 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSQVe-00053g-ME for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 18:48:52 -0500 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50e4e36c09cso1352455e87.1 for ; Tue, 23 Jan 2024 15:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20230601.gappssmtp.com; s=20230601; t=1706053727; x=1706658527; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=FcNDn1vKHee6c3lP+mwyBFjWoPWy3SI14/f+gcKUcrE=; b=vQa1tmwPfdRedRvf4lQCtYWhmUCIUxC+KPeIP2fldqlmgQT4Q8j1jZwalMGQi8h0vz 2LQ9z3kbYElFFV7KMUxRCPqSrzIo0p4zW1yuVfaGjCubPAoq5KTVwrMzxM7tdRTh/Crz Wj9fpfiH7rPbnSH2xLKT+lqjCvRkafjeLrZlStIPVbMfrcnQfYX6GBD5KqbyIAt7phL3 uUNY5exliiBXo+ikNhdmmtr9jjcZd+tk5e1Srge9EHmy8vxP67azRtCoYAhl7DVOh/g4 ITfRWJ2HjEETLG8D1c1i8m+YgATUhTM2VpyeR7UJj2upMekA0V40pRx1vn9Q6L5/TN09 s74A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706053727; x=1706658527; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FcNDn1vKHee6c3lP+mwyBFjWoPWy3SI14/f+gcKUcrE=; b=WyGJYNETa9yERSx8yuYjqIUrELTVuJay3/WwayKux1mhCp89SOugJR/pc4ZPg0nTNr Y3hlEneSAihW6mObgUFMiQECg7VFE5j/iAfRcNXB50yMLRHRfKO7GPNbGb332YoXR//J uhbeuDa3AyMZJn+2xo/2BlcsElWGb/sLooSRBaNLvZJ1Y9tqJQFYZ5W0b6z6k/ifBgXP iTA99pdtQTS1+WU/P3Ox8ZXI43gKCpYEZSHc+UqpkdTnSP2a3KZrlPu63uagS+PKI11t +SaISXm4E3WMKGOil9S8chNy6lddQi0DVZp5NQimGOjET/ZOBHwBQ45jJc3XVUG2rJkH +dfA== X-Gm-Message-State: AOJu0YwTmg3r+diasN/VUj7D2s8JhQodDHKo6HrsP6Bcbi2bP9biQeNC 35/ekZhXrkfM35mPc4rreMv6vFdisiFsAUjzrHwnw7tfMefxMU1R0zmKuEciqadVBjOR7bgDoCk Kl3rC3Tz+n09kbrD7lreRdNXVB9mztwJ6/Ga1QVNuZDCKssvE0yuyyA== X-Google-Smtp-Source: AGHT+IG9FA8FrfWlai7ONCxTU1Qz6YIqPX4XVgr5AJFUebX2anCSUd9uN3IdMkkIJbCFJtAlP9nJsIwXev9fe20B8nY= X-Received: by 2002:a19:4f10:0:b0:510:c55:a407 with SMTP id d16-20020a194f10000000b005100c55a407mr378131lfb.4.1706053726717; Tue, 23 Jan 2024 15:48:46 -0800 (PST) MIME-Version: 1.0 From: Allen Li Date: Tue, 23 Jan 2024 15:48:35 -0800 Message-ID: Subject: 29.1; package-recompile-all should skip system packages in package-directory-list To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000595d25060fa59678" Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=darkfeline@felesatra.moe; helo=mail-lf1-x12b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000595d25060fa59678 Content-Type: text/plain; charset="UTF-8" package-recompile-all currently attempts to recompile all packages, including the system packages listed in package-directory-list. System packages are generally byte compiled as part of installation, and are not writeable by normal users. package-recompile-all attempts to recompile these, which will almost certainly error out due to this. It would be better if package-recompile-all only tries user installed packages (in package-user-dir), which are more likely to need recompilation. Perhaps as a prefix arg option? In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) of 2023-09-03, modified by Debian built on kokoro-ubuntu System Description: Debian GNU/Linux rodete --000000000000595d25060fa59678 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
package-recompile-all currently attempts to recompile all = packages,
including the system packages listed in package-directory-list= .

System packages are generally byte compiled as part of installatio= n, and
are not writeable by normal users.

package-recompile-all a= ttempts to recompile these, which will almost
certainly error out due to= this.

It would be better if package-recompile-all only tries user i= nstalled
packages (in package-user-dir), which are more likely to needrecompilation.=C2=A0 Perhaps as a prefix arg option?

In GNU Emacs= 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37,
=C2=A0cairo v= ersion 1.16.0) of 2023-09-03, modified by Debian built on
=C2=A0kokoro-u= buntu
System Description: Debian GNU/Linux rodete
--000000000000595d25060fa59678-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 24 17:17:48 2024 Received: (at 68678) by debbugs.gnu.org; 24 Jan 2024 22:17:48 +0000 Received: from localhost ([127.0.0.1]:46798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSlZ5-0000GE-Sf for submit@debbugs.gnu.org; Wed, 24 Jan 2024 17:17:48 -0500 Received: from mout01.posteo.de ([185.67.36.65]:59663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSlZ2-0000Fs-Q9 for 68678@debbugs.gnu.org; Wed, 24 Jan 2024 17:17:46 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D06D4240027 for <68678@debbugs.gnu.org>; Wed, 24 Jan 2024 23:17:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1706134652; bh=Z1ZvSNJtXPpdfK+t5NsNcmU/aTw1jOmhCPQ6f2e0oOY=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=Scqbn6j0E1L61bRmT4n+geuFVxfaUNXsZpbGnml+h6HwJnI5NyDwp5BwUfDvLlwDK BJHjgHAqxo+4k6ChZebBEswVpyrFzr4b3Iuw6ptrhW3Yds2fQFovbnvAl51u7TPdUN wQKLlDLIUQPPZmXUHgjeeqd0CrENskj2ae3WC48SSegBUIs7vHoO6L/M/XUa5T3QxS xzlIqp2SCpHz1sskvKduxIHb8ORpo/J0edhuBiODJUzndYznMcC2hWRx2snJ6ZtpBy Au+hVsY/JRp7jlC9K8KD3p+WlzzqATMSe4N3JkyT+TxZDu9UF5icdX02NQdTrkb0GH NN5LVTYQAIHew== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TKyxm1K0Qz9rxD; Wed, 24 Jan 2024 23:17:32 +0100 (CET) From: Philip Kaludercic To: Allen Li Subject: Re: bug#68678: 29.1; package-recompile-all should skip system packages in package-directory-list In-Reply-To: (Allen Li's message of "Tue, 23 Jan 2024 15:48:35 -0800") References: Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Wed, 24 Jan 2024 22:17:31 +0000 Message-ID: <87jznyfkas.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68678 Cc: 68678@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Allen Li writes: > package-recompile-all currently attempts to recompile all packages, > including the system packages listed in package-directory-list. > > System packages are generally byte compiled as part of installation, and > are not writeable by normal users. > > package-recompile-all attempts to recompile these, which will almost > certainly error out due to this. > > It would be better if package-recompile-all only tries user installed > packages (in package-user-dir), which are more likely to need > recompilation. Perhaps as a prefix arg option? Would this patch resolve the issue for you: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 868373f46c2..fe7b10f569a 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2610,7 +2610,8 @@ package-recompile-all are invalid due to changed byte-code, macros or the like." (interactive) (pcase-dolist (`(_ ,pkg-desc) package-alist) - (package-recompile pkg-desc))) + (with-demoted-errors "Error while recompiling: %S" + (package-recompile pkg-desc)))) ;;;###autoload (defun package-autoremove () --=-=-= Content-Type: text/plain > In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, > cairo version 1.16.0) of 2023-09-03, modified by Debian built on > kokoro-ubuntu > System Description: Debian GNU/Linux rodete --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 17:59:03 2024 Received: (at 68678) by debbugs.gnu.org; 25 Jan 2024 22:59:04 +0000 Received: from localhost ([127.0.0.1]:49548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT8gZ-0004eo-GS for submit@debbugs.gnu.org; Thu, 25 Jan 2024 17:59:03 -0500 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:40015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT8gW-0004eI-2P for 68678@debbugs.gnu.org; Thu, 25 Jan 2024 17:59:02 -0500 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-5101ebc74ecso294825e87.0 for <68678@debbugs.gnu.org>; Thu, 25 Jan 2024 14:58:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20230601.gappssmtp.com; s=20230601; t=1706223528; x=1706828328; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5zxHi21Wwb3erbBkipyASt8L1CK/NHYBlaW5YS87EJY=; b=MF4gcpA2OjvjzvyrMGvdMA8KItlZjBQFlhJ0vgrby57C5Qjwo5GdnmpsB7YVRt5r0F IbSLuO+UxyKwCm1h3YWD8pvF1YhKAS9wYEMQ3QPqZ4I8Kxq06pwLQXmojs2mMEnPXvpb m96KuGl0rFnjefrAhjtovL4qQdxljgkIP5bfawLqraY+B5wJiABZQzJ+H84FkN7Jc4Kw ForHbyyH3eRaeMKfRF52f1CyD+XNmmePNNET48wzheuouNEUq4GpPC2ilhoQJmACbyd9 T0V6T73MxGH660LAiSNDd1xLHSkc5hTloxWHlqWCqNpUQk9XMjVSxd9vFMHeVyO3pgf1 52Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706223528; x=1706828328; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5zxHi21Wwb3erbBkipyASt8L1CK/NHYBlaW5YS87EJY=; b=a9AXRdMEwCukyaCabIqCnHMlLIHWxtMzj/Aodjywo/xuZaXoTjaIMHUf3g7Kr1FZ/4 lAyGP/igCKQckvE43n7QTegEPKgrW4itW0Q+ScIsjhsvIRyT/9bNlGW1yOMKoqw7l17f vV6zzkVH/grHgWvTj6uUd1gafioQsnPBPgqrX0PSGcP0XhlK/RqPTqYw9Vz35wTwQ2FP OdluQmkpEwp47w8vudGbFBgpi9u6sqdRkYv6gzXihLpZuMpYEs9rAul4taQBpKFcEcDK qj8xF+wEI9yQq3dxkz2H/G1lOHfsrUReU16wpP2iQsqKeeLo2zEADI8oTFbNPbEtYmq4 PTVw== X-Gm-Message-State: AOJu0YxaguJ1PgeBDm6TP2IY3v3Qv5RsyEJ9gbp/J/C7ZAKn50hpPkeF 9F1RbAi0Z3uT/1juAyNbdSGsSJIfbtjnwqMfnucTRBa1yCOoWU/x3iHGlVYD6h5QHjuPIg02DaU uwdbDS0oxMLSd5QeMfsjCNlU8ILH9nHA+/xXyRw== X-Google-Smtp-Source: AGHT+IGwpFEy3MslkcfpT68ADdVtQO2JoJ+zXDxeEJv4M5i8R4kYe2mBS/VNINh+JghK9FsuMTcY4kaSBQjlkXSMHs0= X-Received: by 2002:a19:4f07:0:b0:50e:84f9:22dc with SMTP id d7-20020a194f07000000b0050e84f922dcmr642800lfb.2.1706223527680; Thu, 25 Jan 2024 14:58:47 -0800 (PST) MIME-Version: 1.0 References: <87jznyfkas.fsf@posteo.net> In-Reply-To: <87jznyfkas.fsf@posteo.net> From: Allen Li Date: Thu, 25 Jan 2024 14:58:36 -0800 Message-ID: Subject: Re: bug#68678: 29.1; package-recompile-all should skip system packages in package-directory-list To: Philip Kaludercic Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68678 Cc: 68678@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Jan 24, 2024 at 2:17=E2=80=AFPM Philip Kaludercic wrote: > > Would this patch resolve the issue for you: > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 868373f46c2..fe7b10f569a 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -2610,7 +2610,8 @@ package-recompile-all > are invalid due to changed byte-code, macros or the like." > (interactive) > (pcase-dolist (`(_ ,pkg-desc) package-alist) > - (package-recompile pkg-desc))) > + (with-demoted-errors "Error while recompiling: %S" > + (package-recompile pkg-desc)))) > > ;;;###autoload > (defun package-autoremove () That works for me, though it's possible that someone may want errors recompiling user packages surfaced directly. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 28 16:40:47 2024 Received: (at 68678) by debbugs.gnu.org; 28 Jan 2024 21:40:47 +0000 Received: from localhost ([127.0.0.1]:58478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUCtS-0001tM-TT for submit@debbugs.gnu.org; Sun, 28 Jan 2024 16:40:47 -0500 Received: from mout02.posteo.de ([185.67.36.66]:37163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUCtP-0001t8-RP for 68678@debbugs.gnu.org; Sun, 28 Jan 2024 16:40:45 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7CABB240101 for <68678@debbugs.gnu.org>; Sun, 28 Jan 2024 22:40:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1706478029; bh=hdPiqucHL7868BOjWzwm8j6nKYQTypCGEYRgu0YPhAU=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=Gpscxu+zvEzUqC2jMeC+DQ+RtsoOQRXfshH1nMwdBAH6y2pl0jRNf/qGiclwPMTfy rqjjeQUvEbPKtDYwH/4RA7s/knHsp/VDzcSMzxqOSTIreaoRyygg9087RnaoJZ7tx5 Vr7bvMJi2IEiFIDwqBxiX+ASHngdoUXYp9wHLfEaDFLdHjgaP2kMmCl0F2NOA2gOWR 6KUKUnO8lUwcvUnmI/B49KQv9LLtH3qt/GUKjPRKTf/Glk5mCvy1b89WyurV1VCb17 2bX4IUBIE83Xnm8057xUaRG9sZ4wDfqvXx8BL75BUNJbQaBLHy8tLyuyr8oBOUg2Fj yuIbH6qv2rOLg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TNPx85XwPz6tvk; Sun, 28 Jan 2024 22:40:28 +0100 (CET) From: Philip Kaludercic To: Allen Li Subject: Re: bug#68678: 29.1; package-recompile-all should skip system packages in package-directory-list In-Reply-To: (Allen Li's message of "Thu, 25 Jan 2024 14:58:36 -0800") References: <87jznyfkas.fsf@posteo.net> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Sun, 28 Jan 2024 21:40:28 +0000 Message-ID: <87ttmx16ib.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68678 Cc: 68678@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Allen Li writes: > On Wed, Jan 24, 2024 at 2:17=E2=80=AFPM Philip Kaludercic wrote: >> >> Would this patch resolve the issue for you: >> >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> index 868373f46c2..fe7b10f569a 100644 >> --- a/lisp/emacs-lisp/package.el >> +++ b/lisp/emacs-lisp/package.el >> @@ -2610,7 +2610,8 @@ package-recompile-all >> are invalid due to changed byte-code, macros or the like." >> (interactive) >> (pcase-dolist (`(_ ,pkg-desc) package-alist) >> - (package-recompile pkg-desc))) >> + (with-demoted-errors "Error while recompiling: %S" >> + (package-recompile pkg-desc)))) >> >> ;;;###autoload >> (defun package-autoremove () > > That works for me, though it's possible that someone may want errors > recompiling user packages surfaced directly. That is why I used `with-demoted-errors', which propagates errors if `debug-on-error' is non-nil. Or do you mean permanently and specifically related to this issue, e.g. in form of a user option. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 02 03:10:57 2024 Received: (at 68678) by debbugs.gnu.org; 2 Feb 2024 08:10:57 +0000 Received: from localhost ([127.0.0.1]:43692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVodU-0000Ge-Pk for submit@debbugs.gnu.org; Fri, 02 Feb 2024 03:10:57 -0500 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]:41334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVodR-0000GK-Fa for 68678@debbugs.gnu.org; Fri, 02 Feb 2024 03:10:55 -0500 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2cd3aea2621so3154831fa.1 for <68678@debbugs.gnu.org>; Fri, 02 Feb 2024 00:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20230601.gappssmtp.com; s=20230601; t=1706861436; x=1707466236; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GENjeFkWZYHGy5MuGxJwVUo+k74KZAfVrrlBX0SIK+8=; b=YbwLO6IAbgrkkqrKzkcoQmx8yXssxYOdiOZ+RxI9+h7cq2B7wzb9ioIJs+a7THxJfE 6VOXRxPqNTHPnRj9x9KrhrVdvfXm4kN4skKAT460ydHRNhx1zq0PqShb0pZnB9zS6YJ9 mQ+F325PbClPd+FMU7kaTckvlj8tTU2mjjAGiwWV2o1YYsuk5yX6jz3yu9z81j7EWfCB sVOg7IRvr9jKJTKg4DJbX8QSETH4iFO7IyNNAVf0ZjF0lReByxaGx/NmPpIYMNpXic2s 95DzPH6xbiU1Vhfv81Br7OIGcq+hef+4W9ITnQbLAQItju/IcTrVDtIn7dJ6jUdbuxIv LOpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706861436; x=1707466236; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GENjeFkWZYHGy5MuGxJwVUo+k74KZAfVrrlBX0SIK+8=; b=dvtISqOjbARSYM7HGkL1OjghuEcVl6dsezK+hO5Cd7/1ep25X49a3xgcSlSM4Y43xs ziN0BxtOvnTRQ3atwxy5sD4lZTkHpahwBi7LzQN6baOvQpWPhdoTqRhELoLaNGa7f7gX W9f2/mgtc4QTFao9m8+3BOyxXRdXIm7lPCqRVa82/Rhf4l8QWx8UkE3gPvOsnROWejQ/ datsQQFswHYJksf5AJNKz1WpVaGuzbeZYVUa9mllFF3ThpITBTHQXyu+3OWyjAzmIEs5 yh1cI22F5r1J1aye8PNwxBno+RHkHrFjXJXWnvzQ8isrE2+bXCrYZtN0ajYKDcs2ijjR 3YXQ== X-Gm-Message-State: AOJu0YxZY+ubJfLF0EkqHDsbSlro8aM7ckbKuOKDMhHHwahymLZatXbL KhKczDEHuCqZYpZy/ucGccMSMG+SqOcQcGwES1GxQWGTQoIQTUTBrZ2nOV1nKBTq1rzJOdCp8r5 ETT5IQv6cl3PHLN0GIi5mE1y7/X2tpPBOfyTZJTKWiPUi+7twVmU= X-Google-Smtp-Source: AGHT+IFO9DTvoBGzrh+jKYgufTMg9DKF5YANrtHs5rK3ThrUHMAVegsC33Vh3EL0BUQLMJdNgsuL+4nWJ3K5lRqE9Qg= X-Received: by 2002:ac2:484f:0:b0:511:3131:51c8 with SMTP id 15-20020ac2484f000000b00511313151c8mr2615535lfy.1.1706861436437; Fri, 02 Feb 2024 00:10:36 -0800 (PST) MIME-Version: 1.0 References: <87jznyfkas.fsf@posteo.net> <87ttmx16ib.fsf@posteo.net> In-Reply-To: <87ttmx16ib.fsf@posteo.net> From: Allen Li Date: Fri, 2 Feb 2024 00:10:24 -0800 Message-ID: Subject: Re: bug#68678: 29.1; package-recompile-all should skip system packages in package-directory-list To: Philip Kaludercic Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68678 Cc: 68678@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jan 28, 2024 at 1:40=E2=80=AFPM Philip Kaludercic wrote: > > Allen Li writes: > > > > That works for me, though it's possible that someone may want errors > > recompiling user packages surfaced directly. > > That is why I used `with-demoted-errors', which propagates errors if > `debug-on-error' is non-nil. Or do you mean permanently and > specifically related to this issue, e.g. in form of a user option. My bad, yes, `with-demoted-errors' sounds fine to me. At the risk of repeating myself, I don't have a use case for surfacing the errors, but I think some other users might. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 06 14:13:37 2024 Received: (at 68678) by debbugs.gnu.org; 6 Feb 2024 19:13:37 +0000 Received: from localhost ([127.0.0.1]:55124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXQsy-0000qJ-Ov for submit@debbugs.gnu.org; Tue, 06 Feb 2024 14:13:37 -0500 Received: from mout02.posteo.de ([185.67.36.66]:49831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXQsw-0000q0-Qh for 68678@debbugs.gnu.org; Tue, 06 Feb 2024 14:13:35 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D6BF5240105 for <68678@debbugs.gnu.org>; Tue, 6 Feb 2024 20:13:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707246795; bh=ERnxxgKGbZZgVnk8dnwfSNCoAT2OgyWbe2vUDX6qBpw=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=Dr7wRenkrd8wxskGYFAOUQ9BmYiaO1UwcPY1oCaxNlq+LaBgmsfjLYbJKQzaIVBdm 1qFGRGeeDJONk4KgqPhTlnQ3jFKAe6nnQRVaM7XEXLKM14ZT5dc/Qj2BVp+KzqCbfF ASqSgP1HxE7/V/7lXx5eyhgvsqbmfcNcgOJ6F0SRSIaewAoRB+QcFMuR+CnG8DdPPJ LCgh/EDY9PtTBlHZjsteYJupuaa9lu9NnTfaRJCkYSriiEvO1oEKEKKXokFiLCKS57 nD/HrpyENttmOJhQWNfUCmRO7jcDXO+MG2p9Dltj6hirwTWDLiecFQkWHUBzWMAHFj E8/ypR8OSWukg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TTtF732cQz6txm; Tue, 6 Feb 2024 20:13:15 +0100 (CET) From: Philip Kaludercic To: Allen Li Subject: Re: bug#68678: 29.1; package-recompile-all should skip system packages in package-directory-list In-Reply-To: (Allen Li's message of "Fri, 2 Feb 2024 00:10:24 -0800") References: <87jznyfkas.fsf@posteo.net> <87ttmx16ib.fsf@posteo.net> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Tue, 06 Feb 2024 19:13:14 +0000 Message-ID: <877cjhs8xh.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68678 Cc: 68678@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Allen Li writes: > On Sun, Jan 28, 2024 at 1:40=E2=80=AFPM Philip Kaludercic > wrote: >> >> Allen Li writes: >> > >> > That works for me, though it's possible that someone may want errors >> > recompiling user packages surfaced directly. >> >> That is why I used `with-demoted-errors', which propagates errors if >> `debug-on-error' is non-nil. Or do you mean permanently and >> specifically related to this issue, e.g. in form of a user option. > > My bad, yes, `with-demoted-errors' sounds fine to me. At the risk of > repeating myself, > I don't have a use case for surfacing the errors, but I think some > other users might. OK, then this is the patch I propse: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Tolerate-errors-while-recompiling-all-packages.patch >From a6c1e5259d413f3ca488e32f2c38d51353494fc6 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Tue, 6 Feb 2024 20:12:15 +0100 Subject: [PATCH] Tolerate errors while recompiling all packages * lisp/emacs-lisp/package.el (package-recompile-all): Demote errors raised by 'package-recompile'. (Bug#68678) --- lisp/emacs-lisp/package.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 868373f46c2..fe7b10f569a 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2610,7 +2610,8 @@ package-recompile-all are invalid due to changed byte-code, macros or the like." (interactive) (pcase-dolist (`(_ ,pkg-desc) package-alist) - (package-recompile pkg-desc))) + (with-demoted-errors "Error while recompiling: %S" + (package-recompile pkg-desc)))) ;;;###autoload (defun package-autoremove () -- 2.39.2 --=-=-= Content-Type: text/plain Any objections? --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 16:53:11 2024 Received: (at 68678-done) by debbugs.gnu.org; 11 Feb 2024 21:53:11 +0000 Received: from localhost ([127.0.0.1]:51378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZHl9-0004fC-1z for submit@debbugs.gnu.org; Sun, 11 Feb 2024 16:53:11 -0500 Received: from mout01.posteo.de ([185.67.36.65]:56441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZHl7-0004ek-Gf for 68678-done@debbugs.gnu.org; Sun, 11 Feb 2024 16:53:10 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 11009240027 for <68678-done@debbugs.gnu.org>; Sun, 11 Feb 2024 22:52:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707688367; bh=QNpzmKxsEDhaWmmn4q54F44vxbRPrPRuIZcVxrj0f0o=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=hZOFDWEXd05yX+Pyw2Uq8PhT3lQlJxhZJIcqNZrC8ge9EhhMCmsxeJ8OCmUI07iMl T0zpav5MnyTxng7nzlLt3bMe79rb4rr/Rs1xlaACybem1ZkqGQEovERFHm/xM8E/62 ynDdjbP/SO80fL6KUnpuusSATCxKGzD06beFfn07FdtSifZzMqXGAKVf0eYvmztsMD HFcTCb6LuhOZgVqpFTAm8L3eUs9G8JdULTjYm6gWcThCY3T44Eon4prhYodqC8z7Ke wdelWqMXRymo0n5ufgOWLzzTfguqZymnQRu98Bf//vDK0RUQciBpwALOGxpfJUUGWp HEzpOOrBm6J7A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TY1Xt2vgwz9rxB; Sun, 11 Feb 2024 22:52:46 +0100 (CET) From: Philip Kaludercic To: Allen Li Subject: Re: bug#68678: 29.1; package-recompile-all should skip system packages in package-directory-list In-Reply-To: <877cjhs8xh.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 06 Feb 2024 19:13:14 +0000") References: <87jznyfkas.fsf@posteo.net> <87ttmx16ib.fsf@posteo.net> <877cjhs8xh.fsf@posteo.net> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Sun, 11 Feb 2024 21:52:45 +0000 Message-ID: <87sf1ysm6q.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68678-done Cc: 68678-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: > Allen Li writes: > >> On Sun, Jan 28, 2024 at 1:40=E2=80=AFPM Philip Kaludercic >> wrote: >>> >>> Allen Li writes: >>> > >>> > That works for me, though it's possible that someone may want errors >>> > recompiling user packages surfaced directly. >>> >>> That is why I used `with-demoted-errors', which propagates errors if >>> `debug-on-error' is non-nil. Or do you mean permanently and >>> specifically related to this issue, e.g. in form of a user option. >> >> My bad, yes, `with-demoted-errors' sounds fine to me. At the risk of >> repeating myself, >> I don't have a use case for surfacing the errors, but I think some >> other users might. > > OK, then this is the patch I propse: > > > > Any objections? As there haven't been any comment, I have pushed the patch to master. Than= ks! From unknown Fri Aug 15 19:22:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 11 Mar 2024 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator