GNU bug report logs - #68671
30.0.50; C-x 8 e s RET persistently breaks C-x 8 e r

Previous Next

Full log

Message #11 received at 68671 <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68671 <at> debbugs.gnu.org
Subject: Re: bug#68671: 30.0.50; C-x 8 e s RET persistently breaks C-x 8 e r
Date: Sat, 27 Jan 2024 14:10:15 +0100

[Message part 1 (text/plain, inline)]

Hi,

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Tue, 23 Jan 2024 11:59:41 +0100
>> From:  Eshel Yaron via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>
>>
>> 1. emacs -Q
>> 2. C-x 8 e s RET
>>    [ i.e. invoke `emoji-search` and exit with an empty minibuffer ]
>> 3. Observe error "Wrong type argument: char-or-string-p, nil".  This
>>    error message could be more friendly, but that's not the issue here.
>> 4. C-x 8 e r
>> 5. Observe error "Wrong type argument: stringp, nil".  That's the issue.
>>
>> What happens is that C-x 8 e s RET adds `nil` to the value of
>> `emoji--recent`, which breaks subsequent C-x 8 e r (`emoji-recent`).
>> This is extra troublesome because `emoji--recent` is used as a
>> multisession variable, so simply restarting Emacs doesn't help.
>>
>> I see this also with Emacs 29.2, FWIW.
>
> Thanks.  Patches for fixing this will be most welcome.

I'm attaching such a patch below.  This provides better feedback when
you exit the `C-x 8 e s` minibuffer with an empty input, and avoids
adding `nil` to `emoji--recent` by bailing beforehand.

[0001-emoji-read-emoji-Signal-error-on-empty-input-Bug-686.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.