From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 23 06:00:05 2024 Received: (at submit) by debbugs.gnu.org; 23 Jan 2024 11:00:05 +0000 Received: from localhost ([127.0.0.1]:42287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSEVg-0007is-Vz for submit@debbugs.gnu.org; Tue, 23 Jan 2024 06:00:05 -0500 Received: from lists.gnu.org ([2001:470:142::17]:59042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSEVf-0007hm-26 for submit@debbugs.gnu.org; Tue, 23 Jan 2024 06:00:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSEVU-0005nq-Lc for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 05:59:52 -0500 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSEVT-0002Kx-4i for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 05:59:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1706007585; bh=rcHQlhoMZiOhpWVbP7qEG76wq8rIlo2GyI3Ghtb3ys4=; h=From:To:Subject:Date:From; b=OFy0MsQQYxtg+IarbIDjvVqCLP50NxeBNftyIYiMsbEBHabMT7r9r2GWqK7tM8uI0 ygRUCHMaumkB46QVdRY1oEHg2tM/yktqYOkeBQoAnxjN1DEFwDoQAK4jYnQIgBFJSD FZ0nSpPCd1tIZ5Yv1b4GyOkQ+Ruv8AfsyO7Qt1y5cYux5+EHiYlbwJdDY23jSsVc43 i6z+awduRoi4JroLZeuWEDpOMBCcEkibg+tBaY10C8C3h43RFHtza+g5JRhxWREAZJ 1BFwxqtUuBpQbdxQpyAxyLVMQjndqgCBBHZg+UPXESxIJ/VPXGNrPBwO86brCLejW9 EO11xyQD5LjdA== From: Eshel Yaron To: bug-gnu-emacs@gnu.org Subject: 30.0.50; C-x 8 e s RET persistently breaks C-x 8 e r X-Debbugs-Cc: Date: Tue, 23 Jan 2024 11:59:41 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) 1. emacs -Q 2. C-x 8 e s RET [ i.e. invoke `emoji-search` and exit with an empty minibuffer ] 3. Observe error "Wrong type argument: char-or-string-p, nil". This error message could be more friendly, but that's not the issue here. 4. C-x 8 e r 5. Observe error "Wrong type argument: stringp, nil". That's the issue. What happens is that C-x 8 e s RET adds `nil` to the value of `emoji--recent`, which breaks subsequent C-x 8 e r (`emoji-recent`). This is extra troublesome because `emoji--recent` is used as a multisession variable, so simply restarting Emacs doesn't help. I see this also with Emacs 29.2, FWIW. In GNU Emacs 30.0.50 (build 58, x86_64-apple-darwin23.0.0, NS appkit-2487.00 Version 14.0 (Build 23A344)) of 2024-01-23 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 27 06:11:18 2024 Received: (at 68671) by debbugs.gnu.org; 27 Jan 2024 11:11:18 +0000 Received: from localhost ([127.0.0.1]:53565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTgak-00016T-6J for submit@debbugs.gnu.org; Sat, 27 Jan 2024 06:11:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTgae-00016B-Mo for 68671@debbugs.gnu.org; Sat, 27 Jan 2024 06:11:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTgaS-0004JV-9Z; Sat, 27 Jan 2024 06:11:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/86nuBIK/wp35FS3k/nREmWqbqvCKxCWQyCOs1c2bdU=; b=Tr4uaWa9WBYm yVd01UT8MqhEIU7PSvRSZv7fIW138M1rXAUBQagmuE99o6e2/g3SRc12x+tcAo9IHlshsEN/tzx85 WkfwzKbC1C9KEeeq59pIvwbLrxN8jRfT0rk3o4fJ8zDQNOR2e41rCxTd1PmJNRUGCrE1QmzG13iaV pd81PwkNfMYQv5uqBGGjLVmuGtEeC7zaRcGZSvXlBOKX0GAdGU3prgL96FXqQcvPYa4U1zZVpDxpD YDYvmov02BLCM2OF5ASjcRGatSggGl7id5sZnyD+FfjXscdqM7/My6n9GXl/VCNT3Cr/ec6nhgWne P8PRB99QA1p6Z9Yp1Se6Wg==; Date: Sat, 27 Jan 2024 13:10:57 +0200 Message-Id: <86cytn820u.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#68671: 30.0.50; C-x 8 e s RET persistently breaks C-x 8 e r References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68671 Cc: 68671@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 23 Jan 2024 11:59:41 +0100 > From: Eshel Yaron via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > 1. emacs -Q > 2. C-x 8 e s RET > [ i.e. invoke `emoji-search` and exit with an empty minibuffer ] > 3. Observe error "Wrong type argument: char-or-string-p, nil". This > error message could be more friendly, but that's not the issue here. > 4. C-x 8 e r > 5. Observe error "Wrong type argument: stringp, nil". That's the issue. > > What happens is that C-x 8 e s RET adds `nil` to the value of > `emoji--recent`, which breaks subsequent C-x 8 e r (`emoji-recent`). > This is extra troublesome because `emoji--recent` is used as a > multisession variable, so simply restarting Emacs doesn't help. > > I see this also with Emacs 29.2, FWIW. Thanks. Patches for fixing this will be most welcome. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 27 08:10:30 2024 Received: (at 68671) by debbugs.gnu.org; 27 Jan 2024 13:10:30 +0000 Received: from localhost ([127.0.0.1]:53626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTiS5-0007Zd-K6 for submit@debbugs.gnu.org; Sat, 27 Jan 2024 08:10:30 -0500 Received: from mail.eshelyaron.com ([107.175.124.16]:42308 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTiS1-0007ZP-Ec for 68671@debbugs.gnu.org; Sat, 27 Jan 2024 08:10:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1706361017; bh=keUk9vzTgG5JK32t4pJEoyFyXmxLRF8rxgY9HBmRyew=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ibsjzMQvDq6W2VwxzMDvHebp3DbHDN/71aCYh3vnLnB2e02bcU/f0km719VzMJpXO mfW62soHNivMvdbMxkHZ66foOf1lke5v7E5t+pjj2o1/lgbG09m410X6U+OTizfCyI PCfYbFcrd4/mlbLIDxf02ELhc5EKtbm3NzkPv5xRInId4JRzb52B6hjY07bS3WrCvG wthROPgbOYMv8tNaDqXzo6w+CNDGT4VlW+fb9zODuQed/nx6gm+Z+40OEhOuiMsm2N 0FwpDNBR8IX0TXFdWyLOm54JknmK4RQVYSmhh6xWcrr4Z1Of8Ork0IQRKOQ3D5AnYx s04izkdLl1EVg== From: Eshel Yaron To: Eli Zaretskii Subject: Re: bug#68671: 30.0.50; C-x 8 e s RET persistently breaks C-x 8 e r In-Reply-To: <86cytn820u.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jan 2024 13:10:57 +0200") References: <86cytn820u.fsf@gnu.org> Date: Sat, 27 Jan 2024 14:10:15 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68671 Cc: 68671@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi, Eli Zaretskii writes: >> Date: Tue, 23 Jan 2024 11:59:41 +0100 >> From: Eshel Yaron via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> >> 1. emacs -Q >> 2. C-x 8 e s RET >> [ i.e. invoke `emoji-search` and exit with an empty minibuffer ] >> 3. Observe error "Wrong type argument: char-or-string-p, nil". This >> error message could be more friendly, but that's not the issue here. >> 4. C-x 8 e r >> 5. Observe error "Wrong type argument: stringp, nil". That's the issue. >> >> What happens is that C-x 8 e s RET adds `nil` to the value of >> `emoji--recent`, which breaks subsequent C-x 8 e r (`emoji-recent`). >> This is extra troublesome because `emoji--recent` is used as a >> multisession variable, so simply restarting Emacs doesn't help. >> >> I see this also with Emacs 29.2, FWIW. > > Thanks. Patches for fixing this will be most welcome. I'm attaching such a patch below. This provides better feedback when you exit the `C-x 8 e s` minibuffer with an empty input, and avoids adding `nil` to `emoji--recent` by bailing beforehand. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-emoji-read-emoji-Signal-error-on-empty-input-Bug-686.patch >From 121c0d8ef1a4cde8cc3538870e165f963227d074 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sat, 27 Jan 2024 14:01:47 +0100 Subject: [PATCH] ; (emoji--read-emoji): Signal error on empty input (Bug#68671) --- lisp/international/emoji.el | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lisp/international/emoji.el b/lisp/international/emoji.el index 3b97d6915af..cab1d2e663c 100644 --- a/lisp/international/emoji.el +++ b/lisp/international/emoji.el @@ -680,11 +680,12 @@ emoji--read-emoji ""))) strings))))) nil t))) - (when (cl-plusp (length name)) - (let ((glyph (if emoji-alternate-names - (cadr (split-string name "\t")) - (gethash name emoji--all-bases)))) - (cons glyph (gethash glyph emoji--derived)))))) + (if (cl-plusp (length name)) + (let ((glyph (if emoji-alternate-names + (cadr (split-string name "\t")) + (gethash name emoji--all-bases)))) + (cons glyph (gethash glyph emoji--derived))) + (user-error "You didn't specify an emoji")))) (defvar-keymap emoji-zoom-map "+" #'emoji-zoom-increase -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 27 08:54:16 2024 Received: (at 68671-done) by debbugs.gnu.org; 27 Jan 2024 13:54:16 +0000 Received: from localhost ([127.0.0.1]:53648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTj8R-0000f9-SQ for submit@debbugs.gnu.org; Sat, 27 Jan 2024 08:54:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTj8N-0000en-LO for 68671-done@debbugs.gnu.org; Sat, 27 Jan 2024 08:54:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTj8A-00020k-WA; Sat, 27 Jan 2024 08:53:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RpTJ9IIAFOghkb0D16vzXJZ5CRM/uCxYRB1/4aRvgew=; b=gAeAe2tQsGJ5 b8p17Sf/mOt9+2HGF3mP+ASe64MbBi8WMh9QpPyzeCJI+eCP/yu3Fh2TbCGTzrTYX2Cuf/jp4PCpE Y7aHPKx0NLeHSSOP5z/Bsa4DtMhxSQV8ZWy+xrR21cyV26y4zfVdKv0X1jHa2Y2wMDDVRPHfIvHQQ 7p6EaLYf6jE9jRNzI83I/X61MbNuoU4y84hEyFHPqGWUF8cC7bWmQucNLln4to3EDxa4LCpszVBGh tpXbTHNpxEjL62qukd+heZzT762CpDlxSsyrmxwkoCObYtluTrxqoh0rxWiYSpF6qEBOvVt0nQei8 3vu308PiPn1m+dd7yAFvxg==; Date: Sat, 27 Jan 2024 15:53:57 +0200 Message-Id: <8634ui991m.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron In-Reply-To: (message from Eshel Yaron on Sat, 27 Jan 2024 14:10:15 +0100) Subject: Re: bug#68671: 30.0.50; C-x 8 e s RET persistently breaks C-x 8 e r References: <86cytn820u.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68671-done Cc: 68671-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eshel Yaron > Cc: 68671@debbugs.gnu.org > Date: Sat, 27 Jan 2024 14:10:15 +0100 > > Eli Zaretskii writes: > > >> Date: Tue, 23 Jan 2024 11:59:41 +0100 > >> From: Eshel Yaron via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> > >> 1. emacs -Q > >> 2. C-x 8 e s RET > >> [ i.e. invoke `emoji-search` and exit with an empty minibuffer ] > >> 3. Observe error "Wrong type argument: char-or-string-p, nil". This > >> error message could be more friendly, but that's not the issue here. > >> 4. C-x 8 e r > >> 5. Observe error "Wrong type argument: stringp, nil". That's the issue. > >> > >> What happens is that C-x 8 e s RET adds `nil` to the value of > >> `emoji--recent`, which breaks subsequent C-x 8 e r (`emoji-recent`). > >> This is extra troublesome because `emoji--recent` is used as a > >> multisession variable, so simply restarting Emacs doesn't help. > >> > >> I see this also with Emacs 29.2, FWIW. > > > > Thanks. Patches for fixing this will be most welcome. > > I'm attaching such a patch below. This provides better feedback when > you exit the `C-x 8 e s` minibuffer with an empty input, and avoids > adding `nil` to `emoji--recent` by bailing beforehand. Thanks, installed on both emacs-29 and master branches, and closing the bug. From unknown Sat Jun 21 10:45:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 Feb 2024 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator