GNU bug report logs - #68670
[PATCH core-updates] doc: Document changes to `copy-recursively'.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68670: closed ([PATCH core-updates] doc: Document changes to
 `copy-recursively'.)
Date: Tue, 23 Jan 2024 14:10:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 23 Jan 2024 09:09:01 -0500
with message-id <87sf2o16rm.fsf <at> gmail.com>
and subject line Re: bug#68670: [PATCH core-updates] doc: Document changes to `copy-recursively'.
has caused the debbugs.gnu.org bug report #68670,
regarding [PATCH core-updates] doc: Document changes to `copy-recursively'.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68670: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68670
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Romain GARBAGE <romain.garbage <at> inria.fr>
To: guix-patches <at> gnu.org
Cc: ludo <at> gnu.org, Romain GARBAGE <romain.garbage <at> inria.fr>,
 maxim.cournoyer <at> gmail.com
Subject: [PATCH core-updates] doc: Document changes to `copy-recursively'.
Date: Tue, 23 Jan 2024 09:42:41 +0100

* doc/guix.texi: Document new key `select?' in `copy-recursively'.

Change-Id: I4b14ae5a1b40e0939456604f75597b5596b76f83
---
 doc/guix.texi | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
---
As requested by Ludo', here is the documentation update that should have
been sent together with issue #68406.

diff --git a/doc/guix.texi b/doc/guix.texi
index df6ce91736..4dbc311468 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -10814,12 +10814,18 @@ Build Utilities
 @deffn {Procedure} copy-recursively source destination @
   [#:log (current-output-port)] [#:follow-symlinks? #f] @
   [#:copy-file copy-file] [#:keep-mtime? #f] [#:keep-permissions? #t]
+  [#:select? (const #t)]
 Copy @var{source} directory to @var{destination}.  Follow symlinks if
 @var{follow-symlinks?}  is true; otherwise, just preserve them.  Call
-@var{copy-file} to copy regular files.  When @var{keep-mtime?} is true,
-keep the modification time of the files in @var{source} on those of
-@var{destination}.  When @var{keep-permissions?} is true, preserve file
-permissions.  Write verbose output to the @var{log} port.
+@var{copy-file} to copy regular files.  Call @var{select?}, taking two
+arguments, @var{file} and @var{stat}, for each entry in @var{source},
+where @var{file} is the entry's absolute file name and @var{stat} is the
+result of @code{lstat} (or @code{stat} if @var{follow-symlinks?} is
+true); exclude entries for which @var{select?} does not return true.
+When @var{keep-mtime?} is true, keep the modification time of the files
+in @var{source} on those of @var{destination}.
+When @var{keep-permissions?} is true, preserve file permissions.  Write
+verbose output to the @var{log} port.
 @end deffn
 
 @deffn {Procedure} delete-file-recursively dir [#:follow-mounts? #f]

base-commit: bafc6efe481d0f209b490c4e2a1ac1b3f7afa06c
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Romain GARBAGE <romain.garbage <at> inria.fr>
Cc: 68670-done <at> debbugs.gnu.org, ludo <at> gnu.org
Subject: Re: bug#68670: [PATCH core-updates] doc: Document changes to
 `copy-recursively'.
Date: Tue, 23 Jan 2024 09:09:01 -0500

Hello!

Romain GARBAGE <romain.garbage <at> inria.fr> writes:

> * doc/guix.texi: Document new key `select?' in `copy-recursively'.
>
> Change-Id: I4b14ae5a1b40e0939456604f75597b5596b76f83
> ---
>  doc/guix.texi | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> ---
> As requested by Ludo', here is the documentation update that should have
> been sent together with issue #68406.
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index df6ce91736..4dbc311468 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -10814,12 +10814,18 @@ Build Utilities
>  @deffn {Procedure} copy-recursively source destination @
>    [#:log (current-output-port)] [#:follow-symlinks? #f] @
>    [#:copy-file copy-file] [#:keep-mtime? #f] [#:keep-permissions? #t]
> +  [#:select? (const #t)]
>  Copy @var{source} directory to @var{destination}.  Follow symlinks if
>  @var{follow-symlinks?}  is true; otherwise, just preserve them.  Call
> -@var{copy-file} to copy regular files.  When @var{keep-mtime?} is true,
> -keep the modification time of the files in @var{source} on those of
> -@var{destination}.  When @var{keep-permissions?} is true, preserve file
> -permissions.  Write verbose output to the @var{log} port.
> +@var{copy-file} to copy regular files.  Call @var{select?}, taking two
> +arguments, @var{file} and @var{stat}, for each entry in @var{source},
> +where @var{file} is the entry's absolute file name and @var{stat} is the
> +result of @code{lstat} (or @code{stat} if @var{follow-symlinks?} is
> +true); exclude entries for which @var{select?} does not return true.
> +When @var{keep-mtime?} is true, keep the modification time of the files
> +in @var{source} on those of @var{destination}.
> +When @var{keep-permissions?} is true, preserve file permissions.  Write
> +verbose output to the @var{log} port.
>  @end deffn
>  
>  @deffn {Procedure} delete-file-recursively dir [#:follow-mounts? #f]

Queued for my next core-updates push.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.