GNU bug report logs - #68664
29.1.50; treesit defun commands broken with nested functions

Previous Next

Full log

Message #35 received at 68664 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68664 <at> debbugs.gnu.org, Troy Brown <brownts <at> troybrown.dev>,
 mardani29 <at> yahoo.es
Subject: Re: bug#68664: 29.1.50; treesit defun commands broken with nested
 functions
Date: Sat, 27 Jan 2024 23:29:36 -0800

> On Jan 27, 2024, at 10:53 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Sat, 27 Jan 2024 20:03:30 -0800
>> Cc: Troy Brown <brownts <at> troybrown.dev>,
>> 68664 <at> debbugs.gnu.org,
>> mardani29 <at> yahoo.es
>> 
>>> Maybe we could support both behaviors via specially-valued prefix
>>> arguments?  Like "C-u" means something, "C-u C-u" means something
>>> else, etc.?
>> 
>> Beginning/end-of-defun already take a numerical interactive arg, unless I missed something we can’t add another. If we want to change behavior interactively we would need something more elaborate, maybe transient maps.
>> 
>>> 
>>>> As for mark-defun, I think it’s similarly equally valid to either mark the next sibling or the parent. Right now mark-defun doesn’t really have a notion of nested defun, we should upgrade it to support nested defun like we did beginning/end-of-defun, either by a toggle like mark-defun-tactic or let user control which defun to mark interactively.
>>> 
>>> Same here.
>>> 
>>> WDYT?
>> 
>> Same for mark-defun, it also has an interactive arg already.
>> 
>> I feel like I missed something, surely you know they already have interactive args :-)
> 
> "C-u" and "C-u 4" are not the same, and can be distinguished by the
> function's body, right?

Ah, you’re right. I didn’t know that. If I use (interactive "P”), C-u gives my '(4) and C-u 4 give me 4. That’s what you mean right?

In that case, yeah I think it could be useful for C-u mark-defun to mark the encoding parent rather than next sibling, and C-u beginning-of-defun to go straight to beg of parent.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.