From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 21 14:56:54 2024 Received: (at submit) by debbugs.gnu.org; 21 Jan 2024 19:56:54 +0000 Received: from localhost ([127.0.0.1]:39050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRdw5-00044Y-Q7 for submit@debbugs.gnu.org; Sun, 21 Jan 2024 14:56:54 -0500 Received: from lists.gnu.org ([2001:470:142::17]:34044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRdw2-00044K-Ff for submit@debbugs.gnu.org; Sun, 21 Jan 2024 14:56:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRdvo-0004ty-W5 for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 14:56:38 -0500 Received: from mail-108-mta80.mxroute.com ([136.175.108.80]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRdvk-0000bM-Ow for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 14:56:35 -0500 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta80.mxroute.com (ZoneMTA) with ESMTPSA id 18d2d98699d0003727.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 21 Jan 2024 19:56:19 +0000 X-Zone-Loop: 437b800ae46e00dfc5aada8f6fc0e53c676ecf16bbc0 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AxqcKxBJt6xlZHaRLX+ufPG2O57BxA5jXQgJdwW5JgE=; b=S8fNkQzztzASykczWyLMdQcNdb 32IrDxUo+EqZiBLBmvNDmGm7K5EYItUBNzN0rEKRZXxRAFW+N/6gsH8BzEBs/NVI10vA0h7DiO0hK aBPpHwGHwuMUjX6VC6ZK0DOC3ikKQbdD8Wc7GWhEbD9l4sF4ifaHYWllXzqZuuj5DA+lMXYOx5g9t 5UuHN20teQp3dfEJh3+1gZIjie06qG0579Mib/PZrLcwHCvHYGZolSzJCtNJdXiyTrcpqU2i1Nmi6 M1uM5bnBXoCUO4AkAzUhoF9UvaW5cSembDlvMjG8dlGkhvH3Tej69laozY+N5cqu+kylELNyFZOtm xKo8HCIw==; From: "J.P." To: bug-gnu-emacs@gnu.org Subject: 30.0.50; ERC 5.x: erc-channel-hide-list doesn't hide certain messages X-Debbugs-CC: emacs-erc@gnu.org Date: Sun, 21 Jan 2024 11:56:16 -0800 Message-ID: <87r0iah34v.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.80; envelope-from=jp@neverwas.me; helo=mail-108-mta80.mxroute.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Tags: easy, help >From emacs -Q: 1. (setopt erc-channel-hide-list '(("#chan" "NICK" "353"))) 2. M-x erc RET ... RET 3. /JOIN #chan 4. Notice the names manifest and nick changes still appear Hints: - How do `erc-server-353' and `erc-server-NICK' find the right buffer(s) to print their messages in? - How does `erc-hide-current-message-p' find the channel name to filter against? - Would allowing `erc-hide-current-message-p' to accept an optional `buffer' argument help? What if `erc-display-message' were to call something like an `erc--hide-current-message-p' instead of `erc-hide-current-message-p'? Any downsides to such indirection? - How might we write a test to demonstrate the current buggy behavior? Although fixing this specific issue is relatively easy and very much welcome, a comprehensive overhaul of all `erc-ignore' related functionality would be even more welcome but is admittedly also more involved. (BTW, please only share answers to the hint questions above if you're willing to take on this bug.) In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.6) of 2024-01-04 built on localhost Repository revision: 1081e975c9370999df1a288b117bfd9053050d21 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 37 (Workstation Edition) Configured using: 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3' PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils compile text-property-search comint ansi-osc ansi-color ring comp-run comp-common erc derived auth-source eieio eieio-core password-cache json map format-spec erc-backend erc-networks easy-mmode byte-opt bytecomp byte-compile erc-common inline cl-extra help-mode erc-compat cl-seq cl-macs gv pcase rx subr-x cl-loaddefs cl-lib erc-loaddefs rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 149907 11404) (symbols 48 11361 0) (strings 32 27740 4779) (string-bytes 1 971593) (vectors 16 17647) (vector-slots 8 310679 13296) (floats 8 27 25) (intervals 56 330 0) (buffers 976 12))