GNU bug report logs - #68642
[PATCH] gnu: Add python-pandas-vet.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68642 in the body.
You can then email your comments to 68642 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-pandas-vet.
Date: Sun, 21 Jan 2024 18:22:09 +0100

* gnu/packages/python-xyz.scm (python-pandas-vet): New variable.
---
 gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index b23108fbf4..dfd786e283 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -13876,6 +13876,31 @@ (define-public python-flake8-isort
 directives.")
     (license license:gpl2+)))
 
+(define-public python-pandas-vet
+  (package
+    (name "python-pandas-vet")
+    ;; Newer versions require flake8>=6.0.0.
+    (version "0.2.3")
+    (source
+     (origin
+       ;; No tests in the PyPI tarball.
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/deppen8/pandas-vet")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1b3pqcargv68p2lpv72q49siq6mxfh3znxhz9vd91rp6fd6lf2cz"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-attrs python-flake8))
+    (native-inputs (list python-pytest))
+    (home-page "https://github.com/deppen8/pandas-vet")
+    (synopsis "Opionated @code{flake8} plugin for @code{pandas} code")
+    (description
+     "This package provides a @code{flake8} plugin to lint @code{pandas} code
+in an opinionated way.")
+    (license license:expat)))
+
 (define-public python-autoflake
   (package
     (name "python-autoflake")

base-commit: 121de47decc1029c06f6e46e5f06d7fefe8e85ec
-- 
2.42.0

Message #8 received at 68642 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 68642 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-pandas-vet.
Date: Mon, 5 Feb 2024 19:11:29 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thank you for the patch!

I started reviewing it, it looks good. I've got question on placement:
- python-science next to pandas
or
- python-check as it is related to lint

What do you think?

Regards,
Oleg

[Message part 2 (text/html, inline)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: guix-patches <at> gnu.org
Subject: Re: [bug#68642] [PATCH] gnu: Add python-pandas-vet.
Date: Mon, 5 Feb 2024 22:12:33 +0100

Hi Oleg,

Originally I put it under python-xyz, because it is a flake8 plugin and
most if not all flake8 plugins are defined in python-xyz.

It does indeed make more sense to have all flake8-related packages in
python-check instead, since it is a linting library. python-pylint is
defined under python-check for example.

For that reason, I would also advise against putting python-pandas-vet
in python-science. I leave the final placement up to you though :-)

Best wishes,

Troy

Message #16 received at 68642-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 68642-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-pandas-vet.
Date: Sun, 11 Feb 2024 21:06:17 +0000

[Message part 1 (text/plain, inline)]

Hi,

I've added the package to python-check based on it's purpose.

Pushed as 579a1a8c029e97b69a7e3597ff9fd287805cf644 to master.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.