From unknown Wed Jun 18 00:24:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68632: [PATCH] Downcase host name to match URL parsing behavior Resent-From: Brad Howes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jan 2024 10:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 68632@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17058333207962 (code B ref -1); Sun, 21 Jan 2024 10:36:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jan 2024 10:35:20 +0000 Received: from localhost ([127.0.0.1]:36674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRVAa-00024H-Kt for submit@debbugs.gnu.org; Sun, 21 Jan 2024 05:35:20 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRUi1-0004Ir-4Q for submit@debbugs.gnu.org; Sun, 21 Jan 2024 05:05:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRUhq-0002OV-3H for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 05:05:34 -0500 Received: from st43p00im-ztbu10073601.me.com ([17.58.63.184]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRUho-0003iS-7I for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 05:05:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=1a1hai; t=1705831528; bh=hpZtYOZeuaNelBVOtyEKGvs2AURv2TuZ1I2QLNO8n3M=; h=From:Content-Type:Mime-Version:Subject:Message-Id:Date:To; b=m+w32g4qzAsZ7E3OTS+2oMSMbqnIYteDf7PzfUA0gngP/sE0jZyLtbsK4o3R8+QnH xdsv7hrsJOjR/E7RQrBlLF87w858p1kdC5+JMo/1Dlj/9JGaj5fK8y8WrsRbGHrKtF SVMO5Dve8xXT7DQbZX3GQ9sSIiOhWGRNz6QpilTtT3pRljdePoiUjq1ME4gjlCqooA gjybUidu9JiIw7iUcLZXXHrZjRxpN6eNcL/QofXGUoxa9+yOhdhXHDzkVM8b8SSnla brdhJOgO/o+srTBbjV2WdEhWvoOnalBe7nO5u4cw1+qaxpK0/s6KrBrH5Op+UXiLnL 5emIR6KH/RxXA== Received: from smtpclient.apple (st43p00im-dlb-asmtp-mailmevip.me.com [17.42.251.41]) by st43p00im-ztbu10073601.me.com (Postfix) with ESMTPSA id A5BB6180178 for ; Sun, 21 Jan 2024 10:05:27 +0000 (UTC) From: Brad Howes Content-Type: multipart/mixed; boundary="Apple-Mail=_C9EC1FE6-6385-4333-9998-454169873A81" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Message-Id: Date: Sun, 21 Jan 2024 11:05:26 +0100 X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Proofpoint-GUID: -RV-zi5N8WKrwNadvYSakTtfWTdpT_hw X-Proofpoint-ORIG-GUID: -RV-zi5N8WKrwNadvYSakTtfWTdpT_hw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-20_06,2024-01-19_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=503 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 clxscore=1011 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2401210078 Received-SPF: pass client-ip=17.58.63.184; envelope-from=bradhowes@mac.com; helo=st43p00im-ztbu10073601.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Mailman-Approved-At: Sun, 21 Jan 2024 05:35:15 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_C9EC1FE6-6385-4333-9998-454169873A81 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Tags: patch Tags: patch Tags: patch When using `comint-osc-process-output' to track directory changes, there can be a failure to match host names due to inconsistent behavior between `url-generic-parse-url' and `ansi-osc-directory-tracker. The former applies `downcase' to the result extracted from the URL but the latter does not. In GNU Emacs 29.1 (build 1, aarch64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.6.6 (Build 21G646)) of 2023-08-17 built on armbob.lan Windowing system distributor 'Apple', version 10.3.2487 System Description: macOS 14.2.1 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules 'CFLAGS=-DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT' --with-x-toolkit=no' --Apple-Mail=_C9EC1FE6-6385-4333-9998-454169873A81 Content-Disposition: attachment; filename=0001-Downcase-host-name-to-match-URL-parsing-behavior.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Downcase-host-name-to-match-URL-parsing-behavior.patch" Content-Transfer-Encoding: quoted-printable =46rom=201be1c11a33b87612dd2b768f3cdf43b11c1ecdc9=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Brad=20Howes=20=0ADate:=20= Sun,=2021=20Jan=202024=2010:07:24=20+0100=0ASubject:=20[PATCH]=20= Downcase=20host=20name=20to=20match=20URL=20parsing=20behavior=0A=0A---=0A= =20lisp/ansi-osc.el=20|=203=20++-=0A=201=20file=20changed,=202=20= insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20a/lisp/ansi-osc.el=20= b/lisp/ansi-osc.el=0Aindex=207e686193f69..8dbaeb45132=20100644=0A---=20= a/lisp/ansi-osc.el=0A+++=20b/lisp/ansi-osc.el=0A@@=20-121,7=20+121,8=20= @@=20ansi-osc-directory-tracker=0A=20=20=20(let=20((url=20= (url-generic-parse-url=20text)))=0A=20=20=20=20=20(when=20(and=20= (string=3D=20(url-type=20url)=20"file")=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(or=20(null=20(url-host=20url))=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(string=3D=20(url-host=20url)=20= (system-name))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20;;=20Use=20`downcase'=20to=20match=20`url-generic-parse-url'=20= behavior=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (string=3D=20(url-host=20url)=20(downcase=20(system-name)))))=0A=20=20=20= =20=20=20=20(ignore-errors=0A=20=20=20=20=20=20=20=20=20(cd-absolute=20= (url-unhex-string=20(url-filename=20url)))))))=0A=20=0A--=20=0A2.39.3=20= (Apple=20Git-145)=0A=0A= --Apple-Mail=_C9EC1FE6-6385-4333-9998-454169873A81 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_C9EC1FE6-6385-4333-9998-454169873A81-- From unknown Wed Jun 18 00:24:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Brad Howes Subject: bug#68632: closed (Re: bug#68632: [PATCH] Downcase host name to match URL parsing behavior) Message-ID: References: <86jznv83rw.fsf@gnu.org> X-Gnu-PR-Message: they-closed 68632 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 68632@debbugs.gnu.org Date: Sat, 27 Jan 2024 10:34:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1706351642-32521-1" This is a multi-part message in MIME format... ------------=_1706351642-32521-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #68632: [PATCH] Downcase host name to match URL parsing behavior which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 68632@debbugs.gnu.org. --=20 68632: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68632 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1706351642-32521-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 68632-done) by debbugs.gnu.org; 27 Jan 2024 10:33:24 +0000 Received: from localhost ([127.0.0.1]:53530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTg04-0008Rd-1z for submit@debbugs.gnu.org; Sat, 27 Jan 2024 05:33:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTg02-0008RO-PL for 68632-done@debbugs.gnu.org; Sat, 27 Jan 2024 05:33:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTfzq-0005ua-AL; Sat, 27 Jan 2024 05:33:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OH8eswXh9ewdEqpM56k1514Fd/w8hQHzRW+i3OgPD3I=; b=Xu8JPCXRUMwG RvRUD6bMurxLDfiT4TogOCtC6A0LcaXEs4ri3mloqcy2JOsodAB7AN2vs3DHJHXIWEt5rv2xm2x+n xMYeR6hEPDqp4Nb5HsmehXR0ERuM1cGf54yGRFFjz3rN1MpOvWbZnkhp3CV6UMyAi3t1X/R+OjPvS K0OgMB5k/P4JFK0in9lLz5lXe7WfxYykj3Va57u+kPIySgmR7H5wZ+Gb5T7ByS62ZyHImck/gbDA7 fyUm1Dh6/N5R6yvdP5EMbw/pnLR66jPENqBgfFQ9yJvhxQptLnv2yr65Z4ZiRUozf5ucZVWIBrTRX kFHXe+HiMMymOsaoJcaKyA==; Date: Sat, 27 Jan 2024 12:33:07 +0200 Message-Id: <86jznv83rw.fsf@gnu.org> From: Eli Zaretskii To: Brad Howes In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#68632: [PATCH] Downcase host name to match URL parsing behavior References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68632-done Cc: 68632-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 21 Jan 2024 11:05:26 +0100 > From: Brad Howes via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > When using `comint-osc-process-output' to track directory changes, there > can be a failure to match host names due to inconsistent behavior > between `url-generic-parse-url' and `ansi-osc-directory-tracker. The > former applies `downcase' to the result extracted from the URL but the > latter does not. Thanks, installed on the master branch, and closing the bug. ------------=_1706351642-32521-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Jan 2024 10:35:20 +0000 Received: from localhost ([127.0.0.1]:36674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRVAa-00024H-Kt for submit@debbugs.gnu.org; Sun, 21 Jan 2024 05:35:20 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRUi1-0004Ir-4Q for submit@debbugs.gnu.org; Sun, 21 Jan 2024 05:05:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRUhq-0002OV-3H for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 05:05:34 -0500 Received: from st43p00im-ztbu10073601.me.com ([17.58.63.184]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRUho-0003iS-7I for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 05:05:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=1a1hai; t=1705831528; bh=hpZtYOZeuaNelBVOtyEKGvs2AURv2TuZ1I2QLNO8n3M=; h=From:Content-Type:Mime-Version:Subject:Message-Id:Date:To; b=m+w32g4qzAsZ7E3OTS+2oMSMbqnIYteDf7PzfUA0gngP/sE0jZyLtbsK4o3R8+QnH xdsv7hrsJOjR/E7RQrBlLF87w858p1kdC5+JMo/1Dlj/9JGaj5fK8y8WrsRbGHrKtF SVMO5Dve8xXT7DQbZX3GQ9sSIiOhWGRNz6QpilTtT3pRljdePoiUjq1ME4gjlCqooA gjybUidu9JiIw7iUcLZXXHrZjRxpN6eNcL/QofXGUoxa9+yOhdhXHDzkVM8b8SSnla brdhJOgO/o+srTBbjV2WdEhWvoOnalBe7nO5u4cw1+qaxpK0/s6KrBrH5Op+UXiLnL 5emIR6KH/RxXA== Received: from smtpclient.apple (st43p00im-dlb-asmtp-mailmevip.me.com [17.42.251.41]) by st43p00im-ztbu10073601.me.com (Postfix) with ESMTPSA id A5BB6180178 for ; Sun, 21 Jan 2024 10:05:27 +0000 (UTC) From: Brad Howes Content-Type: multipart/mixed; boundary="Apple-Mail=_C9EC1FE6-6385-4333-9998-454169873A81" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: [PATCH] Downcase host name to match URL parsing behavior Message-Id: Date: Sun, 21 Jan 2024 11:05:26 +0100 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Proofpoint-GUID: -RV-zi5N8WKrwNadvYSakTtfWTdpT_hw X-Proofpoint-ORIG-GUID: -RV-zi5N8WKrwNadvYSakTtfWTdpT_hw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-20_06,2024-01-19_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=503 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 clxscore=1011 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2401210078 Received-SPF: pass client-ip=17.58.63.184; envelope-from=bradhowes@mac.com; helo=st43p00im-ztbu10073601.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 21 Jan 2024 05:35:15 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_C9EC1FE6-6385-4333-9998-454169873A81 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Tags: patch Tags: patch Tags: patch When using `comint-osc-process-output' to track directory changes, there can be a failure to match host names due to inconsistent behavior between `url-generic-parse-url' and `ansi-osc-directory-tracker. The former applies `downcase' to the result extracted from the URL but the latter does not. In GNU Emacs 29.1 (build 1, aarch64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.6.6 (Build 21G646)) of 2023-08-17 built on armbob.lan Windowing system distributor 'Apple', version 10.3.2487 System Description: macOS 14.2.1 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules 'CFLAGS=-DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT' --with-x-toolkit=no' --Apple-Mail=_C9EC1FE6-6385-4333-9998-454169873A81 Content-Disposition: attachment; filename=0001-Downcase-host-name-to-match-URL-parsing-behavior.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Downcase-host-name-to-match-URL-parsing-behavior.patch" Content-Transfer-Encoding: quoted-printable =46rom=201be1c11a33b87612dd2b768f3cdf43b11c1ecdc9=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Brad=20Howes=20=0ADate:=20= Sun,=2021=20Jan=202024=2010:07:24=20+0100=0ASubject:=20[PATCH]=20= Downcase=20host=20name=20to=20match=20URL=20parsing=20behavior=0A=0A---=0A= =20lisp/ansi-osc.el=20|=203=20++-=0A=201=20file=20changed,=202=20= insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20a/lisp/ansi-osc.el=20= b/lisp/ansi-osc.el=0Aindex=207e686193f69..8dbaeb45132=20100644=0A---=20= a/lisp/ansi-osc.el=0A+++=20b/lisp/ansi-osc.el=0A@@=20-121,7=20+121,8=20= @@=20ansi-osc-directory-tracker=0A=20=20=20(let=20((url=20= (url-generic-parse-url=20text)))=0A=20=20=20=20=20(when=20(and=20= (string=3D=20(url-type=20url)=20"file")=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(or=20(null=20(url-host=20url))=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(string=3D=20(url-host=20url)=20= (system-name))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20;;=20Use=20`downcase'=20to=20match=20`url-generic-parse-url'=20= behavior=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (string=3D=20(url-host=20url)=20(downcase=20(system-name)))))=0A=20=20=20= =20=20=20=20(ignore-errors=0A=20=20=20=20=20=20=20=20=20(cd-absolute=20= (url-unhex-string=20(url-filename=20url)))))))=0A=20=0A--=20=0A2.39.3=20= (Apple=20Git-145)=0A=0A= --Apple-Mail=_C9EC1FE6-6385-4333-9998-454169873A81 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_C9EC1FE6-6385-4333-9998-454169873A81-- ------------=_1706351642-32521-1--