GNU bug report logs - #68612
typescript-ts-mode-test-indentation test fails if tsx grammar not installed

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68612: closed (typescript-ts-mode-test-indentation test fails
 if tsx grammar not installed)
Date: Sun, 21 Jan 2024 05:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 20 Jan 2024 21:12:06 -0800
with message-id <E811791C-DE6E-4D8A-A06B-EB5AB4912CE6 <at> gmail.com>
and subject line Re: bug#68612: typescript-ts-mode-test-indentation test fails if tsx grammar not installed
has caused the debbugs.gnu.org bug report #68612,
regarding typescript-ts-mode-test-indentation test fails if tsx grammar not installed
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68612: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68612
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Matthew Smith <matthew <at> gentoo.org>
To: bug-gnu-emacs <at> gnu.org
Subject: typescript-ts-mode-test-indentation test fails if tsx grammar not
 installed
Date: Sat, 20 Jan 2024 10:35:23 +0000

[Message part 3 (text/plain, inline)]

Severity: minor
Tags: patch

Hi,

typescript-ts-mode-test-indentation only checks if the typescript
language grammar is installed before running the test, but the test
also depends on the tsx language grammar.

A patch is attached that skips the test unless both typescript and tsx
grammars are installed.

Thanks,
Matthew

[typescript-ts-mode-test.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Matthew Smith <matthew <at> gentoo.org>
Cc: 68612-done <at> debbugs.gnu.org
Subject: Re: bug#68612: typescript-ts-mode-test-indentation test fails if tsx
 grammar not installed
Date: Sat, 20 Jan 2024 21:12:06 -0800

> On Jan 20, 2024, at 2:35 AM, Matthew Smith <matthew <at> gentoo.org> wrote:
> 
> Severity: minor
> Tags: patch
> 
> Hi,
> 
> typescript-ts-mode-test-indentation only checks if the typescript
> language grammar is installed before running the test, but the test
> also depends on the tsx language grammar.
> 
> A patch is attached that skips the test unless both typescript and tsx
> grammars are installed.
> 

Thank you Matthew! Pushed to emacs-29.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.