GNU bug report logs - #68559
[PATCH] Improve Python shell completion

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68559: closed ([PATCH] Improve Python shell completion)
Date: Sat, 16 Mar 2024 08:28:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 16 Mar 2024 10:27:05 +0200
with message-id <86edca7fae.fsf <at> gnu.org>
and subject line Re: bug#68559: [PATCH] Improve Python shell completion
has caused the debbugs.gnu.org bug report #68559,
regarding [PATCH] Improve Python shell completion
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68559: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68559
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Liu Hui <liuhui1610 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Improve Python shell completion
Date: Thu, 18 Jan 2024 12:48:37 +0800

[Message part 3 (text/plain, inline)]

Hi,

Currently python-shell-completion-at-point doesn't respect the
delimiter setting of readline completer and always split the text,
resulting in poor completions when completers that don't need word
splitting, e.g. jedi[1], is used. This patch fixes the problem.

Meanwhile, this patch adds an option 'python-shell-readline-completer'
to make Python shell provide better completion experience (e.g.
completing function parameters, dictionary keys) by default if users
are using vanilla Python interpreter with jedi or using IPython, where
the completion support for IPython has been enhanced (e.g. showing
type annotations and function signatures).

BTW, I think it may make sense to move Python snippets to a separate
file to make them easier to be maintained.

Thanks.

Best,

[1] https://jedi.readthedocs.io/en/latest/docs/usage.html#repl-completion

[0001-Improve-Python-shell-completion.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Liu Hui <liuhui1610 <at> gmail.com>
Cc: kobarity <at> gmail.com, 68559-done <at> debbugs.gnu.org, mattias.engdegard <at> gmail.com,
 basil <at> contovou.net
Subject: Re: bug#68559: [PATCH] Improve Python shell completion
Date: Sat, 16 Mar 2024 10:27:05 +0200

> From: Liu Hui <liuhui1610 <at> gmail.com>
> Date: Sat, 16 Mar 2024 14:49:20 +0800
> Cc: kobarity <kobarity <at> gmail.com>, Mattias Engdegård <mattias.engdegard <at> gmail.com>, 
> 	Eli Zaretskii <eliz <at> gnu.org>, 68559 <at> debbugs.gnu.org
> 
> On Thu, Mar 14, 2024 at 10:24 PM Basil L. Contovounesios
> <basil <at> contovou.net> wrote:
> >
> > Thanks, pushed:
> >
> > Detect the readline support for Python shell completion
> > a7057745f5e 2024-03-14 15:09:56 +0100
> > https://git.sv.gnu.org/cgit/emacs.git/commit/?id=a7057745f5e
> >
> > Is there more left to do as part of this bug report?
> 
> I think there is none.

Thanks, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.