GNU bug report logs - #68559
[PATCH] Improve Python shell completion

Previous Next

Full log

Message #200 received at 68559 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <basil <at> contovou.net>
To: Liu Hui <liuhui1610 <at> gmail.com>
Cc: kobarity <kobarity <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 68559 <at> debbugs.gnu.org
Subject: Re: bug#68559: [PATCH] Improve Python shell completion
Date: Mon, 11 Mar 2024 17:02:48 +0100

Liu Hui [2024-03-11 19:35 +0800] wrote:

> On Fri, Mar 8, 2024 at 11:44 PM Basil L. Contovounesios
> <basil <at> contovou.net> wrote:
>>
>> Liu Hui [2024-03-06 18:14 +0800] wrote:
>>
>> > -                   (string-match-p "ipython[23]?\\'" python-shell-interpreter)))))
>> > +                   (or (string-match-p "ipython[23]?\\'" python-shell-interpreter)
>> > +                       (string= python-shell-readline-completer-delims ""))))))
>>
>> Just curious: what does the empty string signify?
>>
>> [ If it's not just a dumb question, perhaps the meaning could be added
>>   to the variable's docstring/commentary. ]
>
> The empty string means no characters are considered delimiters and the
> readline completion could consider the entire line of input without
> breaking it into parts based on typical delimiters like spaces or
> punctuation. The docstring is updated in the attached patch.

Thanks!  But that makes me wonder: in the cases where we check

  (string= python-shell-readline-completer-delims "")

is there a possibility that the variable's value will be nil?
(In which case we should compare with equal instead of string=.)

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.