GNU bug report logs - #68559
[PATCH] Improve Python shell completion

Previous Next

Full log

Message #20 received at 68559 <at> debbugs.gnu.org (full text, mbox):

From: Liu Hui <liuhui1610 <at> gmail.com>
To: kobarity <kobarity <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 68559 <at> debbugs.gnu.org
Subject: Re: bug#68559: [PATCH] Improve Python shell completion
Date: Wed, 24 Jan 2024 18:07:30 +0800

[Message part 1 (text/plain, inline)]

kobarity <kobarity <at> gmail.com> 于2024年1月23日周二 22:15写道：

> Thank you.  I tried the new patch and confirmed that the Python Shell
> buffer allows keyword argument completion on multi-line function
> calls.  However, my expectation is that it can be done in Python
> buffer as well (after calling `python-shell-send-buffer').  Is this
> also possible?

Thank you for the feedback. I have updated the patch to add support in
Python buffer.

> > > I am not sure if Python snippets should be separated.  Do other
> > > language supports keep them separate?
> >
> > I think it allows to reduce code duplication (e.g. the IPython support
> > code existing in both python-shell-completion-setup-code and
> > python-shell-readline-ipython-setup-code) and make code more simple.
> > It seems other languages do not contain as many code snippets as
> > python.el.
>
> Sorry, I misunderstood that snippets meant skeletons.  I agree that
> python.el has long Python codes, which is not easy to maintain.  Are
> you proposing to separate the snippets into .py file?  If it's
> acceptable from the Emacs' source code management perspective, I think
> that is a good approach.

Yes, I'd like to at least put some flags and functions shared by
python-shell-completion-native-setup and python-*-setup-code in a
separate .py file. On the other hand, they are not changed frequently,
so it is not in urgent need.

[0001-Improve-Python-shell-completion-bug-68559.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.