GNU bug report logs - #68559
[PATCH] Improve Python shell completion

Previous Next

Full log

View this message in rfc822 format

From: Liu Hui <liuhui1610 <at> gmail.com>
To: "Basil L. Contovounesios" <basil <at> contovou.net>
Cc: kobarity <kobarity <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>, Mattias Engdegård <mattias.engdegard <at> gmail.com>, 68559 <at> debbugs.gnu.org
Subject: bug#68559: [PATCH] Improve Python shell completion
Date: Mon, 11 Mar 2024 19:35:31 +0800

[Message part 1 (text/plain, inline)]

On Fri, Mar 8, 2024 at 11:44 PM Basil L. Contovounesios
<basil <at> contovou.net> wrote:
>
> Liu Hui [2024-03-06 18:14 +0800] wrote:
>
> > I have updated the patch.
>
> Thanks!  The build and tests succeed here, without skipped tests.
>
> > +                (unless (string-match-p "No readline support" output)
>
> Nit: why not plain 'string-search' instead of a regexp search?

Done.

> > -                   (string-match-p "ipython[23]?\\'" python-shell-interpreter)))))
> > +                   (or (string-match-p "ipython[23]?\\'" python-shell-interpreter)
> > +                       (string= python-shell-readline-completer-delims ""))))))
>
> Just curious: what does the empty string signify?
>
> [ If it's not just a dumb question, perhaps the meaning could be added
>   to the variable's docstring/commentary. ]

The empty string means no characters are considered delimiters and the
readline completion could consider the entire line of input without
breaking it into parts based on typical delimiters like spaces or
punctuation. The docstring is updated in the attached patch.

[0001-Detect-the-readline-support-for-Python-shell-complet.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.