GNU bug report logs - #68559
[PATCH] Improve Python shell completion

Previous Next

Package: emacs;

Reported by: Liu Hui <liuhui1610 <at> gmail.com>

Date: Thu, 18 Jan 2024 04:50:01 UTC

Severity: wishlist

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #194 received at 68559 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <basil <at> contovou.net>
To: Liu Hui <liuhui1610 <at> gmail.com>
Cc: kobarity <kobarity <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 68559 <at> debbugs.gnu.org
Subject: Re: bug#68559: [PATCH] Improve Python shell completion
Date: Fri, 08 Mar 2024 16:44:03 +0100

Liu Hui [2024-03-06 18:14 +0800] wrote:

> I have updated the patch.

Thanks!  The build and tests succeed here, without skipped tests.

> +                (unless (string-match-p "No readline support" output)

Nit: why not plain 'string-search' instead of a regexp search?

> -                   (string-match-p "ipython[23]?\\'" python-shell-interpreter)))))
> +                   (or (string-match-p "ipython[23]?\\'" python-shell-interpreter)
> +                       (string= python-shell-readline-completer-delims ""))))))

Just curious: what does the empty string signify?

[ If it's not just a dumb question, perhaps the meaning could be added
  to the variable's docstring/commentary. ]

-- 
Basil
This bug report was last modified 1 year and 66 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.