GNU bug report logs - #68559
[PATCH] Improve Python shell completion

Previous Next

Full log

Message #191 received at 68559 <at> debbugs.gnu.org (full text, mbox):

From: Liu Hui <liuhui1610 <at> gmail.com>
To: "Basil L. Contovounesios" <basil <at> contovou.net>
Cc: kobarity <kobarity <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 68559 <at> debbugs.gnu.org
Subject: Re: bug#68559: [PATCH] Improve Python shell completion
Date: Wed, 6 Mar 2024 18:14:00 +0800

[Message part 1 (text/plain, inline)]

On Wed, Feb 28, 2024 at 10:50 PM Basil L. Contovounesios
<basil <at> contovou.net> wrote:
>
> Liu Hui [2024-02-26 19:06 +0800] wrote:
>
> > +(add-hook 'python-shell-first-prompt-hook
> > +          'python-shell-readline-detect -90)
>
> This depth currently prepends the function to the hook, but in Emacs 24
> it instead appends to the hook.  Is that a problem?

Thanks for pointing it out!  It is a problem because
python-shell-readline-detect is expected to be executed before
python-shell-completion-native-turn-on-maybe-with-msg, i.e. another
function in the hook.  I have updated the patch.

> > +     (skip-when (null python-shell-readline-completer-delims))
>
> skip-unless here and below?

Done.

[0001-Detect-the-readline-support-for-Python-shell-complet.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.