Subject: Re: bug#68559: [PATCH] Improve Python shell completion

From: "Basil L. Contovounesios" <[email-masked]>
Date: Fri, 08 Mar 2024 16:44:03 +0100

Liu Hui [2024-03-06 18:14 +0800] wrote:

> I have updated the patch.

Thanks!  The build and tests succeed here, without skipped tests.

> +                (unless (string-match-p "No readline support" output)

Nit: why not plain 'string-search' instead of a regexp search?

> -                   (string-match-p "ipython[23]?\\'" python-shell-interpreter)))))
> +                   (or (string-match-p "ipython[23]?\\'" python-shell-interpreter)
> +                       (string= python-shell-readline-completer-delims ""))))))

Just curious: what does the empty string signify?

[ If it's not just a dumb question, perhaps the meaning could be added
  to the variable's docstring/commentary. ]

-- 
Basil