GNU bug report logs - #68535
[PATCH] gnu: spdlog: Update to 1.13.0.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68535: closed ([PATCH] gnu: spdlog: Update to 1.13.0.)
Date: Mon, 05 Feb 2024 22:00:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 05 Feb 2024 22:59:22 +0100
with message-id <87plxaa7yd.fsf <at> gnu.org>
and subject line Re: [bug#68535] [PATCH] gnu: spdlog: Update to 1.13.0.
has caused the debbugs.gnu.org bug report #68535,
regarding [PATCH] gnu: spdlog: Update to 1.13.0.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68535: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68535
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Greg Hogan <code <at> greghogan.com>
To: guix-patches <at> gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH] gnu: spdlog: Update to 1.13.0.
Date: Wed, 17 Jan 2024 17:03:58 +0000

* gnu/packages/logging.scm (spdlog): Update to 1.13.0.
[source]: Remove upstreamed patch.
* gnu/local.mk: Unregister it.
* gnu/packages/patches/spdlog-fix-tests.patch: Delete file.

Change-Id: I78b5021b9841d16f43a283eaee931b4f92746ab8
---
 gnu/local.mk                                |  1 -
 gnu/packages/logging.scm                    |  5 ++--
 gnu/packages/patches/spdlog-fix-tests.patch | 26 ---------------------
 3 files changed, 2 insertions(+), 30 deletions(-)
 delete mode 100644 gnu/packages/patches/spdlog-fix-tests.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 2b0f6eaa60..c27aa5ef38 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -2040,7 +2040,6 @@ dist_patch_DATA =						\
   %D%/packages/patches/source-highlight-gcc-compat.patch	\
   %D%/packages/patches/softhsm-fix-openssl3-tests.patch		\
   %D%/packages/patches/spectre-meltdown-checker-externalize-fwdb.patch \
-  %D%/packages/patches/spdlog-fix-tests.patch			\
   %D%/packages/patches/sphinxbase-fix-doxygen.patch		\
   %D%/packages/patches/sssd-system-directories.patch		\
   %D%/packages/patches/steghide-fixes.patch			\
diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
index 0efd828f8a..47e8cd39c2 100644
--- a/gnu/packages/logging.scm
+++ b/gnu/packages/logging.scm
@@ -213,7 +213,7 @@ (define-public multitail
 (define-public spdlog
   (package
     (name "spdlog")
-    (version "1.12.0")
+    (version "1.13.0")
     (source
      (origin
        (method git-fetch)
@@ -221,9 +221,8 @@ (define-public spdlog
              (url "https://github.com/gabime/spdlog")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
-       (patches (search-patches "spdlog-fix-tests.patch"))
        (sha256
-        (base32 "0yyncv6wjs5rqm76rkqyxpfbsingk1dq5zfcqhy1a7fpw8xdl53k"))))
+        (base32 "0zgdmdgnp2y36jrlk85d4fiyjkjd6anly8pambyc3f3v6sg02zyy"))))
     (build-system cmake-build-system)
     ;; TODO run benchmark. Currently not possible, as adding
     ;; (gnu packages benchmark) forms a dependency cycle
diff --git a/gnu/packages/patches/spdlog-fix-tests.patch b/gnu/packages/patches/spdlog-fix-tests.patch
deleted file mode 100644
index 13dffb309e..0000000000
--- a/gnu/packages/patches/spdlog-fix-tests.patch
+++ /dev/null
@@ -1,26 +0,0 @@
-Remove after next release and package update:
-https://github.com/gabime/spdlog/commit/2ee8bac78e6525a8ad9a9196e65d502ce390d83a
-
-From 2ee8bac78e6525a8ad9a9196e65d502ce390d83a Mon Sep 17 00:00:00 2001
-From: xvitaly <vitaly <at> easycoding.org>
-Date: Sun, 23 Jul 2023 10:15:25 +0200
-Subject: [PATCH] Added missing square bracket to fix the level_to_string_view
- test. (#2827)
-
----
- tests/test_misc.cpp | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/tests/test_misc.cpp b/tests/test_misc.cpp
-index 9f3cb1744..6199641ff 100644
---- a/tests/test_misc.cpp
-+++ b/tests/test_misc.cpp
-@@ -43,7 +43,7 @@ TEST_CASE("log_levels", "[log_levels]")
-     REQUIRE(log_info("Hello", spdlog::level::trace) == "Hello");
- }
- 
--TEST_CASE("level_to_string_view", "[convert_to_string_view")
-+TEST_CASE("level_to_string_view", "[convert_to_string_view]")
- {
-     REQUIRE(spdlog::level::to_string_view(spdlog::level::trace) == "trace");
-     REQUIRE(spdlog::level::to_string_view(spdlog::level::debug) == "debug");

base-commit: 81e7d293941928f6ef1e945eb9644f3b97142c41
-- 
2.40.1

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 68535-done <at> debbugs.gnu.org
Subject: Re: [bug#68535] [PATCH] gnu: spdlog: Update to 1.13.0.
Date: Mon, 05 Feb 2024 22:59:22 +0100

Hi,

Greg Hogan <code <at> greghogan.com> skribis:

> * gnu/packages/logging.scm (spdlog): Update to 1.13.0.
> [source]: Remove upstreamed patch.
> * gnu/local.mk: Unregister it.
> * gnu/packages/patches/spdlog-fix-tests.patch: Delete file.
>
> Change-Id: I78b5021b9841d16f43a283eaee931b4f92746ab8

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.