GNU bug report logs - #68508
[PATCH] ; (dom-print): Use HTML entities for reserved characters.

Previous Next

Package: emacs;

Reported by: Eshel Yaron <me <at> eshelyaron.com>

Date: Tue, 16 Jan 2024 13:26:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eshel Yaron <me <at> eshelyaron.com>
Subject: bug#68508: closed (Re: bug#68508: [PATCH] ; (dom-print): Use HTML
 entities for reserved characters.)
Date: Sat, 20 Jan 2024 09:43:02 +0000

[Message part 1 (text/plain, inline)]
Your bug report

#68508: [PATCH] ; (dom-print): Use HTML entities for reserved characters.

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 68508 <at> debbugs.gnu.org.

-- 
68508: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68508
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: 68508-done <at> debbugs.gnu.org
Subject: Re: bug#68508: [PATCH] ; (dom-print): Use HTML entities for
 reserved characters.
Date: Sat, 20 Jan 2024 11:42:07 +0200

> From: Eshel Yaron <me <at> eshelyaron.com>
> Cc: 68508 <at> debbugs.gnu.org
> Date: Tue, 16 Jan 2024 17:29:12 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks, but could you please also add tests for this?
> 
> Sure, I've added a test to dom-tests.el in the updated patch below.

Thanks, installed on master, and closing the bug.


[Message part 3 (message/rfc822, inline)]
From: Eshel Yaron <me <at> eshelyaron.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; (dom-print): Use HTML entities for reserved characters.
Date: Tue, 16 Jan 2024 14:24:40 +0100

[Message part 4 (text/plain, inline)]
Tags: patch

This makes `dom-print` encode HTML reserved characters that occur in
string elements of the DOM, to ensure the validity of the result.

For example, put the following in `foo.html`:

--8<---------------cut here---------------start------------->8---
<html><body>
Add ‘<samp class="samp">&lt;div class="default"&gt; &lt;/div&gt;</samp>’ tags around the fontified body.
<body><html>
--8<---------------cut here---------------end--------------->8---
(Fragment from https://www.gnu.org/software/emacs/manual/html_mono/htmlfontify.html)

Open that file in Emacs and say `M-: (require 'dom)` and then
`(dom-print (libxml-parse-html-region))` in the HTML buffer.  This
produces invalid HTML since `libxml-parse-html-region` correctly decodes
HTML entities, but `dom-print` doesn't encode (without this patch).




[0001-dom-print-Use-HTML-entities-for-reserved-characters.patch (text/patch, attachment)]
This bug report was last modified 1 year and 119 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.