Subject: Re: [PATCH v3] gnu: torbrowser: Add support for language localisation.

From: André Batista <[email-masked]>
Date: Sat, 20 Jan 2024 18:29:52 -0300

Hi Clément,

qui 18 jan 2024 às 23:46:49 (1705632409), [email-masked] enviou:
> ...
>
> diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
> index b20e17e4cea8..fbd5f0a0af78 100644
> --- a/gnu/packages/tor.scm
> +++ b/gnu/packages/tor.scm
> ...
>
> @@ -503,6 +503,36 @@ (define %torbrowser-version "13.0.8")
>  ;; "src-firefox-tor-browser-".
>  (define %torbrowser-firefox-version "115.6.0esr-13.0-1-build2")
>  
> +;; Use the list in tor-browser-build/rbm.conf.
> +(define %torbrowser-locales
> +  '("ar" "ca" "cs" "da" "de" "el" "es-ES" "fa" "fi" "fr" "ga-IE" "he" "hu"
> +    "id" "is" "it" "ja" "ka" "ko" "lt" "mk" "ms" "my" "nb-NO" "nl" "pl"
> +    "pt-BR" "ro" "ru" "sq" "sv-SE" "th" "tr" "uk" "vi" "zh-CN" "zh-TW"))
> +
> +;; See tor-browser-build/projects/translation/config.
> +(define translation-base-browser
> +  (origin
> +    (method git-fetch)
> +    (uri (git-reference
> +          (url "https://gitlab.torproject.org/tpo/translation.git")
> +          (commit "5490489a8d356a44d792300b4dfddba792d10f2e")))
> +    (file-name "translation-base-browser")
> +    (sha256
> +     (base32
> +      "1knxary2zp2705xzzs76gpy37ri69yp32ajpmpxki3z5hp7mla7q"))))
> +
> +;; See tor-browser-build/projects/translation/config.
> +(define translation-tor-browser
> +  (origin
> +    (method git-fetch)
> +    (uri (git-reference
> +          (url "https://gitlab.torproject.org/tpo/translation.git")
> +          (commit "e92772b4a11ced855c27eafd299cf972bef5cd8f")))

The above commit is the one on the 'main' branch, but the current stable
browser follows 'maint-13.0' (which has now changed in preparation for
v13.0.9 release next Tuesday) and there is a tag for each release. The
release tag for version 13.0.8 (tbb-13.0.8-build1) contains a different
commit number (273592eca488ca3bf535d3789b1130fd1970f09a).

Other than that, everything seems to perfectly mirror upstream build
process. I've also built it, did some testing and it's working as
expected.

You are doing an awesome work, thanks!

PS: I'm sorry to have left you hanging on the lyrebird patch. I'll
review it and, if I find anything worth of attention, I'll ping back.
For now, I can only say that bridges are working just fine.

Cheers!