From unknown Sat Aug 16 18:47:29 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#68488] [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader. Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Jan 2024 21:58:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68488 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 68488@debbugs.gnu.org Cc: Tomas Volf <~@wolfsden.cz> X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170535587614422 (code B ref -1); Mon, 15 Jan 2024 21:58:03 +0000 Received: (at submit) by debbugs.gnu.org; 15 Jan 2024 21:57:56 +0000 Received: from localhost ([127.0.0.1]:47162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPUxv-0003kX-Jv for submit@debbugs.gnu.org; Mon, 15 Jan 2024 16:57:55 -0500 Received: from lists.gnu.org ([2001:470:142::17]:50360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1rPUxt-0003kL-Pg for submit@debbugs.gnu.org; Mon, 15 Jan 2024 16:57:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rPUxn-0000S0-RV for guix-patches@gnu.org; Mon, 15 Jan 2024 16:57:47 -0500 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rPUxl-0008U0-Md for guix-patches@gnu.org; Mon, 15 Jan 2024 16:57:47 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id B47942527FF; Mon, 15 Jan 2024 21:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1705355861; bh=J10XwWesXFMgULMUWU5XyRBHZ1X2BvOQmAsu6w1DnfQ=; h=From:To:Cc:Subject:Date; b=FO6g5yZmjZfJ2l4auat8HksZDhJfJdavhz5Od57HEYiubIogUVnG+YDYBFo3qIHXK v8kwC5cWafqCvcOYDZWDNxSiA+r6vf9gq3D7/WYNxW5xP4Aapk1MZzrRrar58jUY/d ov1XvUBIOlTTDVOn+JaXGpvEuXSeqJBSjt7Os+pfPCrwFsz5uNKgu0yAlMU+aSeVOf 1gZWxCT+zGSzOqA9I7EMv5WDtO0fK1hXFFFnXSRUjfeYTbO7zO97aY/r8uTghtwg7D I3pwZFlLrKvzz6y96abWxAbJG7jd0MnV5UGQSoVKCaPAD7MuZhTjHrb0+nkQgUGmo1 Fj4VIowIYRNs3sNoQfp4hcPDvYSZPv5Mz3MTO0HLrUYtXFKZnLbgfDGxDh2F6yi/zC Nn0g/KBL6KEWLtd+dfnE6qqGx5EIuACk8uzAAXMwiEh+NNp+GP+60ku1zGvLzeSQrq lECgAyeJjzLmhMMXyh6/cPENRNZh0V1g2nHi50p3bV5q+iFHtKaYIlkz3QDM8kaIRg 3AcFgjsBscBQKZ+APkK9ddMW0wCKJoapIUsrSeuqOWEOI2tvjG5FaMtLfB+SA4YL0O 9kLN52c5VfTMj/xqvlIIubZ3CIUE1fbtTdfoeT7tdAYropTJB9FrNJaud25fFgDszX R7LY62ihPBSbRwyUeignxhyA= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [193.32.127.174]) by wolfsden.cz (Postfix) with ESMTPSA id 58C5325199C; Mon, 15 Jan 2024 21:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1705355861; bh=J10XwWesXFMgULMUWU5XyRBHZ1X2BvOQmAsu6w1DnfQ=; h=From:To:Cc:Subject:Date; b=FO6g5yZmjZfJ2l4auat8HksZDhJfJdavhz5Od57HEYiubIogUVnG+YDYBFo3qIHXK v8kwC5cWafqCvcOYDZWDNxSiA+r6vf9gq3D7/WYNxW5xP4Aapk1MZzrRrar58jUY/d ov1XvUBIOlTTDVOn+JaXGpvEuXSeqJBSjt7Os+pfPCrwFsz5uNKgu0yAlMU+aSeVOf 1gZWxCT+zGSzOqA9I7EMv5WDtO0fK1hXFFFnXSRUjfeYTbO7zO97aY/r8uTghtwg7D I3pwZFlLrKvzz6y96abWxAbJG7jd0MnV5UGQSoVKCaPAD7MuZhTjHrb0+nkQgUGmo1 Fj4VIowIYRNs3sNoQfp4hcPDvYSZPv5Mz3MTO0HLrUYtXFKZnLbgfDGxDh2F6yi/zC Nn0g/KBL6KEWLtd+dfnE6qqGx5EIuACk8uzAAXMwiEh+NNp+GP+60ku1zGvLzeSQrq lECgAyeJjzLmhMMXyh6/cPENRNZh0V1g2nHi50p3bV5q+iFHtKaYIlkz3QDM8kaIRg 3AcFgjsBscBQKZ+APkK9ddMW0wCKJoapIUsrSeuqOWEOI2tvjG5FaMtLfB+SA4YL0O 9kLN52c5VfTMj/xqvlIIubZ3CIUE1fbtTdfoeT7tdAYropTJB9FrNJaud25fFgDszX R7LY62ihPBSbRwyUeignxhyA= From: Tomas Volf <~@wolfsden.cz> Date: Mon, 15 Jan 2024 22:57:35 +0100 Message-ID: <8591c1022344b09e865048d2c20fbb8ee3375654.1705355855.git.~@wolfsden.cz> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Without this change, trying to create a system image with efi-raw type while using grub-efi-removable-bootloader fails with fairly confusing message: EFI bootloader required with GPT partitioning * gnu/system/image.scm (system-disk-image): Consider grub-efi-removable-bootloader to be EFI bootloader. Change-Id: I5f5e1a94e825fd29d6880c5bafb330e16a5ac962 --- gnu/system/image.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/system/image.scm b/gnu/system/image.scm index 2cc1012893..5456b3a5a0 100644 --- a/gnu/system/image.scm +++ b/gnu/system/image.scm @@ -535,7 +535,8 @@ (define* (system-disk-image image (when (and (gpt-image? image) (not - (memq (bootloader-name bootloader) '(grub-efi grub-efi32)))) + (memq (bootloader-name bootloader) + '(grub-efi grub-efi32 grub-efi-removable-bootloader)))) (raise (formatted-message (G_ "EFI bootloader required with GPT partitioning")))) base-commit: 31e736dac29e6f0ff8a2de3f28e210a68684ad21 -- 2.41.0 From unknown Sat Aug 16 18:47:29 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tomas Volf <~@wolfsden.cz> Subject: bug#68488: closed (Re: [bug#68488] [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader.) Message-ID: References: <8734uwl20c.fsf@gnu.org> <8591c1022344b09e865048d2c20fbb8ee3375654.1705355855.git.~@wolfsden.cz> X-Gnu-PR-Message: they-closed 68488 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 68488@debbugs.gnu.org Date: Wed, 17 Jan 2024 09:54:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1705485242-13460-1" This is a multi-part message in MIME format... ------------=_1705485242-13460-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #68488: [PATCH] image: Consider grub-efi-removable-bootloader to be EFI boo= tloader. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 68488@debbugs.gnu.org. --=20 68488: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68488 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1705485242-13460-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 68488-done) by debbugs.gnu.org; 17 Jan 2024 09:53:36 +0000 Received: from localhost ([127.0.0.1]:50811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQ2c3-0003US-Kd for submit@debbugs.gnu.org; Wed, 17 Jan 2024 04:53:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQ2c1-0003UA-PF for 68488-done@debbugs.gnu.org; Wed, 17 Jan 2024 04:53:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ2bu-0004ax-OZ; Wed, 17 Jan 2024 04:53:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=sYx/MmE/lT9gHXxX0GX1SpGgoi1GlxsNZr2v7P7VVXg=; b=A6yW0pjqRbpvudnf6KmR EwVR3ibknhMnBKqSmWcC4BZHbME+ASyfLMEgd5dTGA3DR5BxU9skW2aJk8sVkWKjTFYXS0jKMkitc OGkVPpTmq3kRWIZRPRpllg/vlqwx5qHbjlTUii+N1QHJc0UfZyR4G+Ib2gdMLIUfl0nCmuzHAfqVM L3Say2QHC20NlTYd17ceiSMgjRxu7lycirl6cjikmJMkKaXPew0lzngCNCljcIBGWYtyGiHyaL2ZQ +bM85LicsWIac3wkrJgYd/Cf6qQmihs2bTla7PWJWPRBIgrzlap/xkuX70MPiFZwqWO4Gye0i2QEK ucqwiKZCEqHgiw==; From: Mathieu Othacehe To: Tomas Volf <~@wolfsden.cz> Subject: Re: [bug#68488] [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader. In-Reply-To: <8591c1022344b09e865048d2c20fbb8ee3375654.1705355855.git.~@wolfsden.cz> (Tomas Volf's message of "Mon, 15 Jan 2024 22:57:35 +0100") References: <8591c1022344b09e865048d2c20fbb8ee3375654.1705355855.git.~@wolfsden.cz> Date: Wed, 17 Jan 2024 10:53:23 +0100 Message-ID: <8734uwl20c.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68488-done Cc: 68488-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > Without this change, trying to create a system image with efi-raw type while > using grub-efi-removable-bootloader fails with fairly confusing message: > > EFI bootloader required with GPT partitioning > > * gnu/system/image.scm (system-disk-image): Consider > grub-efi-removable-bootloader to be EFI bootloader. Looks good, applied. I agree the error message is misleading. Would you like to give a try at rewording it? The goal is to prevent the failing combination GPT + non-EFI bootloader. Thanks, Mathieu ------------=_1705485242-13460-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Jan 2024 21:57:56 +0000 Received: from localhost ([127.0.0.1]:47162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPUxv-0003kX-Jv for submit@debbugs.gnu.org; Mon, 15 Jan 2024 16:57:55 -0500 Received: from lists.gnu.org ([2001:470:142::17]:50360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1rPUxt-0003kL-Pg for submit@debbugs.gnu.org; Mon, 15 Jan 2024 16:57:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rPUxn-0000S0-RV for guix-patches@gnu.org; Mon, 15 Jan 2024 16:57:47 -0500 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rPUxl-0008U0-Md for guix-patches@gnu.org; Mon, 15 Jan 2024 16:57:47 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id B47942527FF; Mon, 15 Jan 2024 21:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1705355861; bh=J10XwWesXFMgULMUWU5XyRBHZ1X2BvOQmAsu6w1DnfQ=; h=From:To:Cc:Subject:Date; b=FO6g5yZmjZfJ2l4auat8HksZDhJfJdavhz5Od57HEYiubIogUVnG+YDYBFo3qIHXK v8kwC5cWafqCvcOYDZWDNxSiA+r6vf9gq3D7/WYNxW5xP4Aapk1MZzrRrar58jUY/d ov1XvUBIOlTTDVOn+JaXGpvEuXSeqJBSjt7Os+pfPCrwFsz5uNKgu0yAlMU+aSeVOf 1gZWxCT+zGSzOqA9I7EMv5WDtO0fK1hXFFFnXSRUjfeYTbO7zO97aY/r8uTghtwg7D I3pwZFlLrKvzz6y96abWxAbJG7jd0MnV5UGQSoVKCaPAD7MuZhTjHrb0+nkQgUGmo1 Fj4VIowIYRNs3sNoQfp4hcPDvYSZPv5Mz3MTO0HLrUYtXFKZnLbgfDGxDh2F6yi/zC Nn0g/KBL6KEWLtd+dfnE6qqGx5EIuACk8uzAAXMwiEh+NNp+GP+60ku1zGvLzeSQrq lECgAyeJjzLmhMMXyh6/cPENRNZh0V1g2nHi50p3bV5q+iFHtKaYIlkz3QDM8kaIRg 3AcFgjsBscBQKZ+APkK9ddMW0wCKJoapIUsrSeuqOWEOI2tvjG5FaMtLfB+SA4YL0O 9kLN52c5VfTMj/xqvlIIubZ3CIUE1fbtTdfoeT7tdAYropTJB9FrNJaud25fFgDszX R7LY62ihPBSbRwyUeignxhyA= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [193.32.127.174]) by wolfsden.cz (Postfix) with ESMTPSA id 58C5325199C; Mon, 15 Jan 2024 21:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1705355861; bh=J10XwWesXFMgULMUWU5XyRBHZ1X2BvOQmAsu6w1DnfQ=; h=From:To:Cc:Subject:Date; b=FO6g5yZmjZfJ2l4auat8HksZDhJfJdavhz5Od57HEYiubIogUVnG+YDYBFo3qIHXK v8kwC5cWafqCvcOYDZWDNxSiA+r6vf9gq3D7/WYNxW5xP4Aapk1MZzrRrar58jUY/d ov1XvUBIOlTTDVOn+JaXGpvEuXSeqJBSjt7Os+pfPCrwFsz5uNKgu0yAlMU+aSeVOf 1gZWxCT+zGSzOqA9I7EMv5WDtO0fK1hXFFFnXSRUjfeYTbO7zO97aY/r8uTghtwg7D I3pwZFlLrKvzz6y96abWxAbJG7jd0MnV5UGQSoVKCaPAD7MuZhTjHrb0+nkQgUGmo1 Fj4VIowIYRNs3sNoQfp4hcPDvYSZPv5Mz3MTO0HLrUYtXFKZnLbgfDGxDh2F6yi/zC Nn0g/KBL6KEWLtd+dfnE6qqGx5EIuACk8uzAAXMwiEh+NNp+GP+60ku1zGvLzeSQrq lECgAyeJjzLmhMMXyh6/cPENRNZh0V1g2nHi50p3bV5q+iFHtKaYIlkz3QDM8kaIRg 3AcFgjsBscBQKZ+APkK9ddMW0wCKJoapIUsrSeuqOWEOI2tvjG5FaMtLfB+SA4YL0O 9kLN52c5VfTMj/xqvlIIubZ3CIUE1fbtTdfoeT7tdAYropTJB9FrNJaud25fFgDszX R7LY62ihPBSbRwyUeignxhyA= From: Tomas Volf <~@wolfsden.cz> To: guix-patches@gnu.org Subject: [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader. Date: Mon, 15 Jan 2024 22:57:35 +0100 Message-ID: <8591c1022344b09e865048d2c20fbb8ee3375654.1705355855.git.~@wolfsden.cz> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Tomas Volf <~@wolfsden.cz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Without this change, trying to create a system image with efi-raw type while using grub-efi-removable-bootloader fails with fairly confusing message: EFI bootloader required with GPT partitioning * gnu/system/image.scm (system-disk-image): Consider grub-efi-removable-bootloader to be EFI bootloader. Change-Id: I5f5e1a94e825fd29d6880c5bafb330e16a5ac962 --- gnu/system/image.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/system/image.scm b/gnu/system/image.scm index 2cc1012893..5456b3a5a0 100644 --- a/gnu/system/image.scm +++ b/gnu/system/image.scm @@ -535,7 +535,8 @@ (define* (system-disk-image image (when (and (gpt-image? image) (not - (memq (bootloader-name bootloader) '(grub-efi grub-efi32)))) + (memq (bootloader-name bootloader) + '(grub-efi grub-efi32 grub-efi-removable-bootloader)))) (raise (formatted-message (G_ "EFI bootloader required with GPT partitioning")))) base-commit: 31e736dac29e6f0ff8a2de3f28e210a68684ad21 -- 2.41.0 ------------=_1705485242-13460-1--