GNU bug report logs - #6847
23.2; ibuffer-filter-by-filename ignores buffer directory names

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6847 in the body.
You can then email your comments to 6847 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Damyan Pepper <damyanp <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2; ibuffer-filter-by-filename ignores buffer directory names
Date: Thu, 12 Aug 2010 11:06:34 +0100

When using ibuffer.el if I set it to filter by filename then dired
buffers visiting directories are not included in the filter.  This is
inconsistent with the way that ibuffer displays the buffers.

For example, if I start with emacs -Q, open a few buffers and run M-x ibuffer:

MR Name                    Size Mode             Filename/Process
-- ----                    ---- ----             ----------------
[ Default ]
   README                  5276 Fundamental      c:/emacs-23.2/README
 % emacs-23.2               857 Dired by name    c:/emacs-23.2/
 % etc                     5627 Dired by name    c:/emacs-23.2/etc/
 % bin                     1299 Dired by name    c:/emacs-23.2/bin/
   *scratch*                191 Lisp Interaction
*  *Messages*               131 Fundamental

   6 buffers              13381                  4 files, no processes

and then press "/ f emacs" I get:

MR Name                    Size Mode             Filename/Process
-- ----                    ---- ----             ----------------
[ Default ]
   README                  5276 Fundamental      c:/emacs-23.2/README

   1 buffer                5276                  1 file, no processes


Note that the emacs-23.2, etc and bin buffers all have an entry in the
"Filename/Process" column that is ignored by the filter.


In GNU Emacs 23.2.1 (i386-mingw-nt5.2.3790)
of 2010-05-08 on G41R2F1
Windowing system distributor `Microsoft Corp.', version 5.2.3790
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/xpm/include'

Important settings:
 value of $LC_ALL: nil
 value of $LC_COLLATE: nil
 value of $LC_CTYPE: nil
 value of $LC_MESSAGES: nil
 value of $LC_MONETARY: nil
 value of $LC_NUMERIC: nil
 value of $LC_TIME: nil
 value of $LANG: ENG
 value of $XMODIFIERS: nil
 locale-coding-system: cp1252
 default enable-multibyte-characters: t

Message #8 received at 6847 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: 6847 <at> debbugs.gnu.org
Subject: Re: bug#6847: 23.2; ibuffer-filter-by-filename ignores buffer
 directory names
Date: Sun, 4 Aug 2019 19:41:16 +0200

[Message part 1 (text/plain, inline)]

tags 6847 + patch
quit

Damyan Pepper <damyanp <at> gmail.com> writes:

> When using ibuffer.el if I set it to filter by filename then dired
> buffers visiting directories are not included in the filter.  This is
> inconsistent with the way that ibuffer displays the buffers.
>
> For example, if I start with emacs -Q, open a few buffers and run M-x ibuffer:
>
> MR Name                    Size Mode             Filename/Process
> -- ----                    ---- ----             ----------------
> [ Default ]
>    README                  5276 Fundamental      c:/emacs-23.2/README
>  % emacs-23.2               857 Dired by name    c:/emacs-23.2/
>  % etc                     5627 Dired by name    c:/emacs-23.2/etc/
>  % bin                     1299 Dired by name    c:/emacs-23.2/bin/
>    *scratch*                191 Lisp Interaction
> *  *Messages*               131 Fundamental
>
>    6 buffers              13381                  4 files, no processes
>
> and then press "/ f emacs" I get:
>
> MR Name                    Size Mode             Filename/Process
> -- ----                    ---- ----             ----------------
> [ Default ]
>    README                  5276 Fundamental      c:/emacs-23.2/README
>
>    1 buffer                5276                  1 file, no processes
>
>
> Note that the emacs-23.2, etc and bin buffers all have an entry in the
> "Filename/Process" column that is ignored by the filter.

I think this use case should be mostly covered by the recently added
ibuffer-filter-by-directory command:

    commit 35aaa6b6aa9a2e7b42465603fb32355a009c510f
    Author: Christopher Genovese <genovese <at> cmu.edu>
    Date:   Tue Dec 20 17:41:56 2016 +0900

        ibuffer: New filters and commands

But it would seem that this command never got a key binding.  This is an
excerpt from C-h f ibuffer-mode:

    Filtering commands:

      ‘M-x ibuffer-filter-chosen-by-completion’ - Select and apply
filter chosen by completion.
      ‘/ RET’ - Add a filter by any major mode.
      ‘/ m’ - Add a filter by a major mode now in use.
      ‘/ M’ - Add a filter by derived mode.
      ‘/ n’ - Add a filter by buffer name.
      ‘/ c’ - Add a filter by buffer content.
      ‘/ b’ - Add a filter by basename.
      ‘M-x ibuffer-filter-by-directory’ - Add a filter by directory name.
      ‘/ f’ - Add a filter by filename.
      ‘/ .’ - Add a filter by file extension.

I suggest to add the keybinding "/ F" for ibuffer-filter-by-directory
and "/ SPC" for ibuffer-filter-chosen-by-completion.  Perhaps "/ d" or
"/ D" would be more natural for the directory case, but alas they are
already taken.

Please see the attached patch.

Thanks,
Stefan Kangas

[0001-Add-key-bindings-for-ibuffer-filter-commands.patch (application/x-patch, attachment)]

Message #13 received at 6847 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: 6847 <at> debbugs.gnu.org
Subject: Re: bug#6847: 23.2; ibuffer-filter-by-filename ignores buffer
 directory names
Date: Sat, 14 Sep 2019 02:09:34 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> I suggest to add the keybinding "/ F" for ibuffer-filter-by-directory
> and "/ SPC" for ibuffer-filter-chosen-by-completion.  Perhaps "/ d" or
> "/ D" would be more natural for the directory case, but alas they are
> already taken.
>
> Please see the attached patch.

Unless there are any objections, I'll commit this change in a couple of days.

Best regards,
Stefan Kangas

Message #16 received at 6847 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: 6847 <at> debbugs.gnu.org
Subject: Re: bug#6847: 23.2; ibuffer-filter-by-filename ignores buffer
 directory names
Date: Thu, 26 Sep 2019 18:57:46 +0200

fixed 6847 26.1
close 6847
quit

Stefan Kangas <stefan <at> marxist.se> writes:

> > I suggest to add the keybinding "/ F" for ibuffer-filter-by-directory
> > and "/ SPC" for ibuffer-filter-chosen-by-completion.  Perhaps "/ d" or
> > "/ D" would be more natural for the directory case, but alas they are
> > already taken.
> >
> > Please see the attached patch.
>
> Unless there are any objections, I'll commit this change in a couple of days.

No comments in 12 days, so I've now pushed this as commit 9d002e5049.

This bug was technically already fixed already in 26.1, as mentioned
earlier.  I'm therefore closing this bug as such.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.