Subject: Re: bug#68448: Add guile-rsv package definition.

From: Ludovic Courtès <[email-masked]>
Date: Sun, 28 Jan 2024 22:34:46 +0100

Hi Yulav,

Yuval Langer <[email-masked]> skribis:

> From c5361f0bf17b02a385b4782a2435c52519095c7a Mon Sep 17 00:00:00 2001
> Message-Id: <c536[email-masked]>
> From: Yuval Langer <[email-masked]>
> Date: Sun, 14 Jan 2024 14:54:10 +0200
> Subject: [PATCH] Add guile-rsv package definition.

Nice!

> +(define-public guile-rsv
> +  (let ((commit-string "ecf0cbd486bb5f73e335e9e04212b0985f3efc35")
> +        (base32-string "0cgnilix4050717xx3b2n45nfvr2hag1asbw92zs6mz6srq7xclq")
> +        (git-repository-url "https://codeberg.org/kakafarm/guile-rsv/"))
> +    (package
> +     (name "guile-rsv")
> +     (version "0.1.0")
> +     (source
> +      (origin
> +       (uri (git-reference
> +             (url git-repository-url)
> +             (commit commit-string)))
> +       (method git-fetch)
> +       (file-name (git-file-name name version))
> +       (sha256 (base32 base32-string))))

[...]

> +          (add-after 'install 'link-and-wrap-executable
> +                     (lambda _
> +                       (let* ([bin (string-append #$output
> +                                                  "/bin")] ;; bin directory for PATH.

[...]

> +     (home-page git-repository-url)
> +     (synopsis "R7RS Scheme library for reading and writing RSV data format")
> +     (description "R7RS Scheme library for reading and writing RSV (Rows of String
> +Values) data format.  Specified in
> +https://github.com/Stenway/RSV-Specification and demonstrated in
> +https://www.youtube.com/watch?v=tb_70o6ohMA.")

Could you please follow the conventions and style used elsewhere in the
code, in particular regarding how to deal with snapshots, avoiding
square brackets, possibly running ‘guix style guile-rsv’, and writing
synopsis and description following our guidelines:

  https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html
  https://guix.gnu.org/manual/devel/en/html_node/Version-Numbers.html

Could you send an updated version?

Thanks in advance!

Ludo’.