GNU bug report logs - #68414
[PATCH] doc: Improve documentation for submitting patches

Previous Next

Package: guix-patches;

Reported by: Ale Abdo <abdo <at> member.fsf.org>

Date: Sat, 13 Jan 2024 05:10:01 UTC

Severity: minor

Tags: patch

Full log


View this message in rfc822 format

From: Clément Lassieur <clement <at> lassieur.org>
To: Ale Abdo <abdo <at> member.fsf.org>
Cc: 68414 <at> debbugs.gnu.org
Subject: [bug#68414] [PATCH] doc: Improve documentation for submitting patches
Date: Sat, 13 Jan 2024 12:27:44 +0100
On Sat, Jan 13 2024, Ale Abdo wrote:

>...     You may also send patches inline, as each patch file
> +generated by @command{git format-patch} is a single valid email message, but
> +you'd be advised to pay attention if your email client changes anything like
> +line breaks or indentation, which could potentially break the patches.

Hi, I haven't read all your patch, but this is wrong, I'm sorry.
Sending patches inline without using git send-email mostly doesn't work
for technical issues and is a waste of time for reviewers who try to
figure out why the patch doesn't apply.  We should not encourage this.

Thanks,
Clément




This bug report was last modified 1 year and 114 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.