GNU bug report logs - #68401
30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt

Previous Next

Full log

Message #121 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Emanuel Berg <incal <at> dataswamp.org>
To: bug-gnu-emacs <at> gnu.org
Cc: emacs-erc <at> gnu.org
Subject: Re: bug#68401: 30.0.50;
 ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'. 2nd attempt
Date: Sat, 17 Feb 2024 09:52:43 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

J.P. wrote:

>> (erc-cmd-GMSG, erc-cmd-AME, erc-cmd-GME): new IRC slash commands
>                                            ^                     ^
> [...]
>> * lisp/erc/erc.el (erc-cmd-GME): should be #'erc--connected-and-joined-p,
>> not (erc--connected-and-joined-p)
>> (Bug#68401)
>
> This last item appears to describe an incremental patch revision only
> known to this discussion thread on the tracker [...]
>
> FWIW, other Emacs commit messages don't seem to have these
> interspersed sub-headers [...]
>
>   Try to start each NEWS entry with a sentence [...]
>
>> +Also, the new IRC slash commands `erc-cmd-GMSG',
>> +`erc-cmd-AME', and `erc-cmd-GME' were added and are available
>    ^~~~~~~~~~~~^
>
> For etc/*NEWS, I believe they prefer single 'quotes' [...]
>
>> -stalled and restart it.  The default is	after 120 seconds.
>> +stalled and restart it.  The default is   after 120 seconds.
>                                           ~~~
>
> Please collapse the expanded TAB into a single space [...]
>> -paragraph-separate: "[ 	]*$"
>> +paragraph-separate: "[  ]*$"
>                           ^
> I believe the TAB here is intentional, so please undo
> this hunk.

I sent a reply to this but it hasn't appeared yet, it seems.
Anyway, I finally understood all of what you asked for,
I think, so you can disregard that post and instead have
a look at the below patch, hopefully it covers it.

[0368-Make-erc-cmd-AMSG-session-local-add-GMSG-AME-and-GME.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

-- 
underground experts united
https://dataswamp.org/~incal

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.