GNU bug report logs - #68395
30.0.50; ERC 5.6-git: erc-cmd-GMSG, erc-cmd-AMSG, erc-cmd-GME, erc-cmd-AME

Previous Next

Full log

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Emanuel Berg <incal <at> dataswamp.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#68395: 30.0.50;
 ERC 5.6-git: erc-cmd-GMSG, erc-cmd-AMSG, erc-cmd-GME, erc-cmd-AME
Date: Fri, 12 Jan 2024 06:52:42 +0100

J.P. wrote:

>> Patch
>
> I think debbugs wants the full "Tags: patch".

It is there, what you cite is just what I wrote in the message
instead of a bug report.

> At some point, you'll need to include a commit message.

I added a message, if not 'git commit' wouldn't have worked.

>> ---
>>  lisp/erc/erc.el | 156 ++++++++++++++++++++++++++++--------------------
>>  1 file changed, 90 insertions(+), 66 deletions(-)
>>
>> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
>> index 478683a77f5..12078f6970d 100644
>> --- a/lisp/erc/erc.el
>> +++ b/lisp/erc/erc.el
>> @@ -2003,10 +2003,10 @@ erc-get-buffer
>>  (defun erc--buffer-p (buf predicate proc)
>>    (with-current-buffer buf
>>      (and (derived-mode-p 'erc-mode)
>> -	 (or (not proc)
>> -	     (eq proc erc-server-process))
>> -	 (funcall predicate)
>> -	 buf)))
>> +         (or (not proc)
>> +             (eq proc erc-server-process))
>> +         (funcall predicate)
>> +         buf)))
>
> I haven't looked at the proposed commands yet, but can you
> remove all these hopefully inadvertent white space changes
> in the meantime, please?

Ah, you are using tabs in the source, saving the buffer
changed them to whitespace. This is what happens if you use
tabs! But you are right it wasn't intended for the patch.

-- 
underground experts united
https://dataswamp.org/~incal

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.