GNU bug report logs - #68376
30.0.50; auth-source-search doesn't support numeric port on macOS

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68376 in the body.
You can then email your comments to 68376 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Kirill A. Korinsky" <kirill <at> korins.ky>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; auth-source-search doesn't support numeric port on macOS
Date: Thu, 11 Jan 2024 01:57:21 +0100

[Message part 1 (text/plain, inline)]

Greeting,

I'd like to share a bug with simple reproducer:

(auth-source-search :host "some.host" :port "123" :user "user")
(auth-source-search :host "some.host" :port 123 :user "user")

The first line works as expected, and the second one fails as:

Debugger entered--Lisp error: (wrong-type-argument stringp 123)
  call-process("/usr/bin/security" nil t nil "find-generic-password" "-g" "-c" "some.host" "-a" "user" "-s" 123)
  auth-source-macos-keychain-search-items("default" macos-keychain-generic 1 "some.host" 123 "user" :type macos-keychain-generic :user "user")
  apply(auth-source-macos-keychain-search-items "default" macos-keychain-generic 1 "some.host" 123 "user" (:type macos-keychain-generic :user "user"))
  auth-source-macos-keychain-search(:backend #<auth-source-backend auth-source-backend-1ff08463df92> :type macos-keychain-generic :max 1 :require nil :create nil :delete nil :host "some.host" :port 123 :user "user")
  auth-source-search-backends((#<auth-source-backend auth-source-backend-1ff08463df92> #<auth-source-backend auth-source-backend-1ff0887f79e6> #<auth-source-backend auth-source-backend-1ff07046d5fe> #<auth-source-backend auth-source-backend-1ff070457074>) (:host "some.host" :port 123 :user "user") 1 nil nil nil)
  auth-source-search(:host "some.host" :port 123 :user "user")
  eval((auth-source-search :host "some.host" :port 123 :user "user") nil)
  elisp--eval-last-sexp(nil)
  eval-last-sexp(nil)
  funcall-interactively(eval-last-sexp nil)
  command-execute(eval-last-sexp)

on

In GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin21.6.0, NS
 appkit-2113.60 Version 12.7.1 (Build 21G920)) of 2024-01-10 built on
 Kirills-MBP.sa31-home.catap.net
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.7.1

Configured using:
 'configure --prefix=/opt/local --disable-silent-rules --without-dbus
 --without-gconf --without-libotf --without-m17n-flt --with-libgmp
 --with-gnutls --with-json --with-xml2 --with-modules --with-sqlite3
 --with-webp --infodir /opt/local/share/info/emacs --with-ns
 --with-lcms2 --without-harfbuzz --without-xaw3d --with-imagemagick
 --with-rsvg --with-native-compilation=aot --with-tree-sitter
 'CFLAGS=-pipe -Os
 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -arch
 x86_64' 'CPPFLAGS=-I/opt/local/include
 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk'
 'LDFLAGS=-L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-rpath
 /opt/local/lib/gcc13
 -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk
 -arch x86_64''

which was build from https://github.com/emacs-mirror/emacs/commit/d9462e24a967e32d550ee886b5150f0cc78358f6 <https://github.com/emacs-mirror/emacs/commit/d9462e24a967e32d550ee886b5150f0cc78358f6>
--
wbr, Kirill

[Message part 2 (text/html, inline)]

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 68376 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: "Kirill A. Korinsky" <kirill <at> korins.ky>
Cc: 68376 <at> debbugs.gnu.org
Subject: Re: bug#68376: 30.0.50; auth-source-search doesn't support numeric
 port on macOS
Date: Thu, 11 Jan 2024 11:12:17 +0100

[Message part 1 (text/plain, inline)]

"Kirill A. Korinsky" <kirill <at> korins.ky> writes:

> Greeting,

Hi Kirill,

> I'd like to share a bug with simple reproducer:
>
> (auth-source-search :host "some.host" :port "123" :user "user")
> (auth-source-search :host "some.host" :port 123 :user "user")
>
> The first line works as expected, and the second one fails as:
>
> Debugger entered--Lisp error: (wrong-type-argument stringp 123)
>   call-process("/usr/bin/security" nil t nil "find-generic-password"
> "-g" "-c" "some.host" "-a" "user" "-s" 123)

call-process requires strings as arguments. This must be converted
in auth-source-macos-keychain-search-items if needed.

Could you, please, check whether the appended patch works? I cannot test
myself, I have no macOS machine.

Best regards, Michael.

[Message part 2 (text/x-patch, attachment)]

Message #11 received at 68376 <at> debbugs.gnu.org (full text, mbox):

From: "Kirill A. Korinsky" <kirill <at> korins.ky>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 68376 <at> debbugs.gnu.org
Subject: Re: bug#68376: 30.0.50; auth-source-search doesn't support numeric
 port on macOS
Date: Thu, 11 Jan 2024 11:38:05 +0100

[Message part 1 (text/plain, inline)]

> On 11. Jan 2024, at 11:12, Michael Albinus <michael.albinus <at> gmx.de> wrote:
> 
> Could you, please, check whether the appended patch works? I cannot test
> myself, I have no macOS machine.


It works, thanks.

--
wbr, Kirill

[signature.asc (application/pgp-signature, attachment)]

Message #16 received at 68376-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: "Kirill A. Korinsky" <kirill <at> korins.ky>
Cc: 68376-done <at> debbugs.gnu.org
Subject: Re: bug#68376: 30.0.50; auth-source-search doesn't support numeric
 port on macOS
Date: Thu, 11 Jan 2024 12:32:57 +0100

Version: 30.1

"Kirill A. Korinsky" <kirill <at> korins.ky> writes:

Hi Kirill,

>> Could you, please, check whether the appended patch works? I cannot test
>> myself, I have no macOS machine.
>
> It works, thanks.

Thanks for the feedback. I've pushed the fix to the master branch,
closing the bug.

> wbr, Kirill

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.