GNU bug report logs - #68374
min-width is not correctly treated by buffer-text-pixel-size

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68374 in the body.
You can then email your comments to 68374 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: JD Smith <jdtsmith <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: min-width is not correctly treated by buffer-text-pixel-size
Date: Wed, 10 Jan 2024 17:22:53 -0500

When the ‘display min-width property is used on characters in a buffer, window/buffer-text-pixel-size does not include this min-width padding in its calculation of the text's pixel width.  

This can be seen by using a range of minimum character widths and noticing that the width is identical; see below.  Other ‘display properties like space :width and space :align-to do seem to be correctly handled by pixel size calculations. 

This is relevant because various elements on the mode-line use ‘display min-width, so performing pixel alignment on the mode-line text is impacted.

+++

(eval-when-compile 'cl-lib)
(cl-loop
 for w from 0. to 100. by 20. 
 collect
 (with-current-buffer (get-buffer-create "*pixel-sizes*")
   (erase-buffer)
   (insert ">>>" (propertize " " 'display `(min-width (,w))) "<<<")
   (cons w (buffer-text-pixel-size))))
  
;; ((0 49 . 14) (20 49 . 14) (40 49 . 14) (60 49 . 14) (80 49 . 14) (100 49 . 14))

Message #8 received at 68374 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: JD Smith <jdtsmith <at> gmail.com>
Cc: 68374 <at> debbugs.gnu.org
Subject: Re: bug#68374: min-width is not correctly treated by
 buffer-text-pixel-size
Date: Thu, 11 Jan 2024 12:24:04 +0200

> From: JD Smith <jdtsmith <at> gmail.com>
> Date: Wed, 10 Jan 2024 17:22:53 -0500
> 
> 
> When the ‘display min-width property is used on characters in a buffer, window/buffer-text-pixel-size does not include this min-width padding in its calculation of the text's pixel width.  

For some reason I cannot understand, we were ignoring min-width when
simulating display (as opposed to actually displaying stuff in a
window).  I can only assume it's some kind of left-over from when Lars
was developing this feature, where calls from functions that simulate
display caused him trouble, so he disabled that and forgot to
re-enable later.  At least I cannot find any discussion of this, and
the code which disables min-width in these situations was in the
initial version that landed on master.

So please try running with the patch below for a couple of weeks, and
if it doesn't cause you any trouble, I will install it on master.
Please configure your builds with --enable-checking='yes,glyphs' for
the duration of this test period, to activate some run-time tests and
assertions that will hopefully flag any problems this change might
have.

TIA

diff --git a/src/xdisp.c b/src/xdisp.c
index 14cf030..29ac4a4 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -5487,9 +5487,6 @@ display_min_width (struct it *it, ptrdiff_t bufpos,
   if (!NILP (it->min_width_property)
       && !EQ (width_spec, it->min_width_property))
     {
-      if (!it->glyph_row)
-	return;
-
       /* When called from display_string (i.e., the mode line),
 	 we're being called with a string as the object, and we
 	 may be called with many sub-strings belonging to the same

Message #11 received at 68374 <at> debbugs.gnu.org (full text, mbox):

From: JD Smith <jdtsmith <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68374 <at> debbugs.gnu.org
Subject: Re: bug#68374: min-width is not correctly treated by
 buffer-text-pixel-size
Date: Thu, 11 Jan 2024 14:53:57 -0500

Great, this small patch seems to work.  I’ve enabled glyph checking and will report here if anything untoward comes up.  Should I be keeping track of the *warnings* buffer?

> 
> On Jan 11, 2024, at 5:24 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: JD Smith <jdtsmith <at> gmail.com>
>> Date: Wed, 10 Jan 2024 17:22:53 -0500
>> 
>> 
>> When the ‘display min-width property is used on characters in a buffer, window/buffer-text-pixel-size does not include this min-width padding in its calculation of the text's pixel width.  
> 
> For some reason I cannot understand, we were ignoring min-width when
> simulating display (as opposed to actually displaying stuff in a
> window).  I can only assume it's some kind of left-over from when Lars
> was developing this feature, where calls from functions that simulate
> display caused him trouble, so he disabled that and forgot to
> re-enable later.  At least I cannot find any discussion of this, and
> the code which disables min-width in these situations was in the
> initial version that landed on master.
> 
> So please try running with the patch below for a couple of weeks, and
> if it doesn't cause you any trouble, I will install it on master.
> Please configure your builds with --enable-checking='yes,glyphs' for
> the duration of this test period, to activate some run-time tests and
> assertions that will hopefully flag any problems this change might
> have.
> 
> TIA
> 
> diff --git a/src/xdisp.c b/src/xdisp.c
> index 14cf030..29ac4a4 100644
> --- a/src/xdisp.c
> +++ b/src/xdisp.c
> @@ -5487,9 +5487,6 @@ display_min_width (struct it *it, ptrdiff_t bufpos,
>   if (!NILP (it->min_width_property)
>       && !EQ (width_spec, it->min_width_property))
>     {
> -      if (!it->glyph_row)
> -	return;
> -
>       /* When called from display_string (i.e., the mode line),
> 	 we're being called with a string as the object, and we
> 	 may be called with many sub-strings belonging to the same

Message #14 received at 68374 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: JD Smith <jdtsmith <at> gmail.com>
Cc: 68374 <at> debbugs.gnu.org
Subject: Re: bug#68374: min-width is not correctly treated by
 buffer-text-pixel-size
Date: Fri, 12 Jan 2024 09:05:46 +0200

> From: JD Smith <jdtsmith <at> gmail.com>
> Date: Thu, 11 Jan 2024 14:53:57 -0500
> Cc: 68374 <at> debbugs.gnu.org
> 
> Great, this small patch seems to work.  I’ve enabled glyph checking and will report here if anything untoward comes up.  Should I be keeping track of the *warnings* buffer?

Yes, and also look out for redisplay errors in *Messages*.

Thanks.

Message #17 received at 68374 <at> debbugs.gnu.org (full text, mbox):

From: JD Smith <jdtsmith <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68374 <at> debbugs.gnu.org
Subject: Re: bug#68374: min-width is not correctly treated by
 buffer-text-pixel-size
Date: Fri, 12 Jan 2024 11:45:02 -0500

[Message part 1 (text/plain, inline)]

I suppose the occasional:

Error during redisplay: (jit-lock-function 3483) signaled (quit)
Error during redisplay: (jit-lock-function 3510) signaled (quit)

in *Messages* isn’t related or harmful?  Soon I’ll be using pixel width calculations to layout the mode line; and will keep a close eye on it.  

> On Jan 12, 2024, at 2:05 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: JD Smith <jdtsmith <at> gmail.com>
>> Date: Thu, 11 Jan 2024 14:53:57 -0500
>> Cc: 68374 <at> debbugs.gnu.org
>> 
>> Great, this small patch seems to work.  I’ve enabled glyph checking and will report here if anything untoward comes up.  Should I be keeping track of the *warnings* buffer?
> 
> Yes, and also look out for redisplay errors in *Messages*.
> 
> Thanks.

[Message part 2 (text/html, inline)]

Message #20 received at 68374 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: JD Smith <jdtsmith <at> gmail.com>
Cc: 68374 <at> debbugs.gnu.org
Subject: Re: bug#68374: min-width is not correctly treated by
 buffer-text-pixel-size
Date: Fri, 12 Jan 2024 20:09:25 +0200

> From: JD Smith <jdtsmith <at> gmail.com>
> Date: Fri, 12 Jan 2024 11:45:02 -0500
> Cc: 68374 <at> debbugs.gnu.org
> 
> I suppose the occasional:
> 
>  Error during redisplay: (jit-lock-function 3483) signaled (quit)
>  Error during redisplay: (jit-lock-function 3510) signaled (quit)
> 
> in *Messages* isn’t related or harmful?

Did you type C-g because something in font-lock was taking too long?

But yes, in general this is not the kind of problems I'd expect from
the change.

Message #23 received at 68374 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: JD Smith <jdtsmith <at> gmail.com>
Cc: 68374 <at> debbugs.gnu.org
Subject: Re: bug#68374: min-width is not correctly treated by
 buffer-text-pixel-size
Date: Sun, 11 Feb 2024 10:47:01 +0200

> From: JD Smith <jdtsmith <at> gmail.com>
> Date: Thu, 11 Jan 2024 14:53:57 -0500
> Cc: 68374 <at> debbugs.gnu.org
> 
> Great, this small patch seems to work.  I’ve enabled glyph checking and will report here if anything untoward comes up.

Any news?  Should I install this now?

Thanks.

Message #26 received at 68374 <at> debbugs.gnu.org (full text, mbox):

From: JD Smith <jdtsmith <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68374 <at> debbugs.gnu.org
Subject: Re: bug#68374: min-width is not correctly treated by
 buffer-text-pixel-size
Date: Sun, 11 Feb 2024 07:20:21 -0500

I haven't noticed anything unusual in a couple weeks of use, so please do.  Thanks.

> On Feb 11, 2024, at 3:47 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: JD Smith <jdtsmith <at> gmail.com>
>> Date: Thu, 11 Jan 2024 14:53:57 -0500
>> Cc: 68374 <at> debbugs.gnu.org
>> 
>> Great, this small patch seems to work.  I’ve enabled glyph checking and will report here if anything untoward comes up.
> 
> Any news?  Should I install this now?
> 
> Thanks.

Message #31 received at 68374-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: JD Smith <jdtsmith <at> gmail.com>
Cc: 68374-done <at> debbugs.gnu.org
Subject: Re: bug#68374: min-width is not correctly treated by
 buffer-text-pixel-size
Date: Sun, 11 Feb 2024 15:22:57 +0200

> From: JD Smith <jdtsmith <at> gmail.com>
> Date: Sun, 11 Feb 2024 07:20:21 -0500
> Cc: 68374 <at> debbugs.gnu.org
> 
> I haven't noticed anything unusual in a couple weeks of use, so please do.  Thanks.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.